1 |
On 13-07-2007 23:33:05 +1000, Ben Peddell wrote: |
2 |
> Fabian Groffen wrote: |
3 |
> > On 13-07-2007 22:50:31 +1000, Ben Peddell wrote: |
4 |
> >> Fabian Groffen wrote: |
5 |
> >>> On 12-07-2007 21:01:28 +0200, Elias Pipping wrote: |
6 |
> >>>> Mail.app tends to integrate text attachments into the body of the mail, |
7 |
> >>>> so you no longer know where the patch begins and where it ends. Might |
8 |
> >>>> become ugly with tabs/spaces, too. |
9 |
> >>> It horks the spaces/tabs. |
10 |
> >>> |
11 |
> >> If it weren't for the spaces/tabs issue, all would be fine. As long as: |
12 |
> >> 1. The patch is in unified format, |
13 |
> >> 2. The MUA doesn't gobble any spaces, and |
14 |
> >> 3. You don't start any of your lines with +, - or @, |
15 |
> >> the entire message body can be the patch. |
16 |
> >> patch has no problem with stripping any leading / trailing lines from |
17 |
> >> the patch. |
18 |
> > |
19 |
> > Of course I tried it, and the patch failed to apply because of spaces |
20 |
> > mismatches. |
21 |
> > |
22 |
> Hmm. No problem with spaces here. |
23 |
> ==================================================================== |
24 |
> ~/src/doxygen-1.5.2 $ bzcat ~/Documents/doxygen-1.5.2-libiconv.patch.bz2 |
25 |
> | patch --dry-run -p0 --verbose |
26 |
> Hmm... Looks like a unified diff to me... |
27 |
> The text leading up to this was: |
28 |
> -------------------------- |
29 |
> |--- src/portable.cpp~ 2007-07-12 20:41:27 +0200 |
30 |
> |+++ src/portable.cpp 2007-05-06 14:30:18 +0200 |
31 |
> -------------------------- |
32 |
> Patching file src/portable.cpp using Plan A... |
33 |
> Hunk #1 succeeded at 373. |
34 |
> done |
35 |
> ==================================================================== |
36 |
> Is there a patch that patches the same area of |
37 |
> doxygen-1.5.2/src/portable.cpp? I'll find out when I've finished |
38 |
> fetching the latest alt-prefix overlay. |
39 |
> |
40 |
> I don't know what the "Inappropriate ioctl for device" error would have |
41 |
> been caused by. Perhaps bzcat expected to be able to seek in the stream. |
42 |
|
43 |
OK, but you're using the bz2 version. Anyway. Thanks for the hints. |
44 |
It made its way into the tree anyway ;) |
45 |
|
46 |
|
47 |
-- |
48 |
Fabian Groffen |
49 |
Gentoo on a different level |
50 |
-- |
51 |
gentoo-alt@g.o mailing list |