From: Felix Bier <Felix.Bier@rohde-schwarz.com>
To: "gentoo.catalyst@xxoo.ws" <gentoo.catalyst@xxoo.ws>,
"mattst88@gentoo.org" <mattst88@gentoo.org>
Cc: "gentoo-catalyst@lists.gentoo.org" <gentoo-catalyst@lists.gentoo.org>
Subject: [gentoo-catalyst] Re: [PATCH] Fix specifying target_profiles in repo_name:path format
Date: Sat, 27 Feb 2021 23:31:41 +0000 [thread overview]
Message-ID: <04fc602be54c42352128ac1ca34daaac56cd6af0.camel@rohde-schwarz.com> (raw)
In-Reply-To: <CAEdQ38FKF3NKourkBKxk4R1miWSUM95gVQ=4MQJgP263=ZWWVA@mail.gmail.com>
Am Samstag, dem 27.02.2021 um 13:52 -0500 schrieb Matt Turner:
> On Thu, Feb 25, 2021 at 8:09 AM Daniel Cordero
> <gentoo.catalyst@xxoo.ws> wrote:
> >
> > From: Daniel Cordero <catalyst@0xdc.io>
> >
> > This fixes commit a500400592aaa309
>
> Felix also mentioned on IRC that he wanted this functionality.
>
> <felixb> | mattst88_: Ok thank you for the information. I will look
> into the profile problem after I'm done with the PORTDIR removal
> patches. So guess the right approach would be to restore the eselect
> call in some form, improving the documentation and possibly ensuring
> that eselect is only called once. I think it would also make sense to
> remove the manual symlink logic in config_profile_link, since that
> would be redundant with eselect and is more limited (i.e. it
> <felixb> | would take some work to adapt the manual symlinking to
> deal
> with profiles outside of the main repo and parsing profile names such
> as myrepo:myprofile, which eselect can resolve).
>
> So, cc'ing him to see what he thinks.
Hi, I'm happy with how Daniel solved this. I was worried about the
maintenance cost of duplicating eselect functionality, but this is very
compact.
I assumed that eselect would resolve profile names without repo: prefix
by looping over all repos to find a matching profile, but after
analysing eselect it seems such profile names are expected to always be
in the main repo. So using eselect would give no addtional
functionality compared to this patch.
I did not find any helper functions in the portage library for handling
this task.
Possibly we could improve error reporting (failing early if the link is
broken, instead of waiting for emerge to fail later), but I'm fine with
this being done in a separate step.
Best regards,
Felix
next prev parent reply other threads:[~2021-02-27 23:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 20:21 [gentoo-catalyst] [PATCH 01/11] targets: Remove unused 'enter' command Matt Turner
2021-01-18 20:21 ` [gentoo-catalyst] [PATCH 02/11] targets: Remove some obvious comments Matt Turner
2021-01-18 20:21 ` [gentoo-catalyst] [PATCH 03/11] targets: Update seed stage's sys-apps/portage Matt Turner
2021-01-18 20:21 ` [gentoo-catalyst] [PATCH 04/11] targets: Update BINPKG_COMPRESS to new zstd default Matt Turner
2021-01-18 20:21 ` [gentoo-catalyst] [PATCH 05/11] targets: Update the @changed-subslot set by default Matt Turner
2021-01-18 20:21 ` [gentoo-catalyst] [PATCH 06/11] catalyst: Store references to functions Matt Turner
2021-01-18 20:21 ` [gentoo-catalyst] [PATCH 07/11] catalyst: Call config_profile_link for all targets Matt Turner
2021-02-25 13:09 ` [gentoo-catalyst] [PATCH] Fix specifying target_profiles in repo_name:path format Daniel Cordero
2021-02-27 18:52 ` [gentoo-catalyst] " Matt Turner
2021-02-27 23:31 ` Felix Bier [this message]
2021-01-18 20:21 ` [gentoo-catalyst] [PATCH 08/11] catalyst: Deduplicate prepare_sequence assignments Matt Turner
2021-01-18 20:21 ` [gentoo-catalyst] [PATCH 09/11] catalyst: Deduplicate the common build_sequence steps Matt Turner
2021-01-18 20:21 ` [gentoo-catalyst] [PATCH 10/11] catalyst: Add option to enter the chroot before building Matt Turner
2021-01-18 20:21 ` [gentoo-catalyst] [PATCH 11/11] catalyst: Remove update_seed spec option Matt Turner
2021-01-19 11:02 ` Daniel Cordero
2021-01-19 14:58 ` Matt Turner
2021-01-21 5:12 ` Matt Turner
2021-01-21 10:20 ` Daniel Cordero
2021-01-22 0:04 ` Matt Turner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04fc602be54c42352128ac1ca34daaac56cd6af0.camel@rohde-schwarz.com \
--to=felix.bier@rohde-schwarz.com \
--cc=gentoo-catalyst@lists.gentoo.org \
--cc=gentoo.catalyst@xxoo.ws \
--cc=mattst88@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox