From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id B8EC3138322 for ; Tue, 8 Jan 2013 03:32:16 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 8D07B21C034 for ; Tue, 8 Jan 2013 03:32:14 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 4F96521C02D for ; Tue, 8 Jan 2013 03:17:53 +0000 (UTC) Received: from [192.168.1.210] (xx250174254.cipherkey.com [205.250.174.254]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: dolsen) by smtp.gentoo.org (Postfix) with ESMTPSA id 71DAC33DABD for ; Tue, 8 Jan 2013 03:17:52 +0000 (UTC) Message-ID: <1357615048.4289.12.camel@big_daddy.dol-sen.ca> Subject: Re: [gentoo-catalyst] Catalyst tree move code changes. [3 of 4] From: Brian Dolbec To: gentoo-catalyst@lists.gentoo.org Date: Mon, 07 Jan 2013 19:17:28 -0800 In-Reply-To: <1357613628.4289.4.camel@big_daddy.dol-sen.ca> References: <1357613628.4289.4.camel@big_daddy.dol-sen.ca> Organization: Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-75lwCLRDU986nOyv7IDk" X-Mailer: Evolution 3.4.4 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org Mime-Version: 1.0 X-Archives-Salt: 39fd2716-71b2-4fa4-af1e-55c17e1ad2a6 X-Archives-Hash: 99bded36856d1d6bd97ee925b471c9e0 --=-75lwCLRDU986nOyv7IDk Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2013-01-07 at 18:53 -0800, Brian Dolbec wrote: > use the portdir setting rather than hard-coded path. > --=20 > Brian Dolbec >=20 > --=20 > Brian Dolbec Now that #3 has fianly made it to the list... What about some of the other paths in cleanables? Perhaps they too should be config'd and then use the the config value, rather than be hard-coded here. But not being involved in using catalyst, that is something I don't know. I see 'resolv.conf' and '/var/tmp/*' that probably should be config'd, what about 'root/*' By doing that. It would put all control back to the config, making it one place to edit for a simple path change. Easing maintenance for the future. >=20 =46rom 773edaaf1db072c5b15b3680413d1fb9e5841593 Mon Sep 17 00:00:00 2001 From: Brian Dolbec Date: Wed, 19 Dec 2012 18:10:15 -0800 Subject: [PATCH] use the portdir setting rather than hard-coded path --- modules/tinderbox_target.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/tinderbox_target.py b/modules/tinderbox_target.py index 46fe082..d6d3ea3 100644 --- a/modules/tinderbox_target.py +++ b/modules/tinderbox_target.py @@ -29,8 +29,8 @@ class tinderbox_target(generic_stage_target): raise CatalystError,"Tinderbox aborting due to error." =20 def set_cleanables(self): - self.settings["cleanables"]=3D["/etc/resolv.conf","/var/tmp/*","/root/*",\ - "/usr/portage"] + self.settings["cleanables"]=3D["/etc/resolv.conf","/var/tmp/*","/root/*", + self.settings['portdir']] =20 def set_action_sequence(self): #Default action sequence for run method --=20 1.8.0 --=20 Brian Dolbec --=-75lwCLRDU986nOyv7IDk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQEcBAABAgAGBQJQ64/IAAoJECIU2QoBTxfLG/sH/iBMs4VYoIeajnqeHOYLrHWJ 8wk4EBGXysMH1qN5XBFcEZ1iksu2BFBixYx3TwZZbfQ4MMOuVHeA+vr5eq4B1dj/ +JRcBz1nwVl06Lbu2pQ6xRy7giOJFuwk6r1evOXjw/2CiGEYDAWTVSqU/a1qB+Ug fUxvcqvrDmcuiXJY2f30K0/5bmfcniAas9GnloJgJgrYBlOkm9xw0E72AhXo7igD ZfnwOsjBLaBP2HmDpEo5N7BO0hp014CpO3qFn3zdloP6+8IR7efipMj3y669u6RR MPdNuDlhoGuhmKRBot6RRSZnSBZv/eJwHT5H4FfAMxHCoRTPL0ghyuf8HWOFUAs= =IETJ -----END PGP SIGNATURE----- --=-75lwCLRDU986nOyv7IDk--