From: Brian Dolbec <dolsen@gentoo.org>
To: gentoo-catalyst@lists.gentoo.org
Cc: Brian Dolbec <dolsen@gentoo.org>
Subject: [gentoo-catalyst] [PATCH 2/3] Remove unused variable new and an undefined variable s.
Date: Fri, 13 Dec 2013 19:28:27 -0800 [thread overview]
Message-ID: <1386991708-9385-3-git-send-email-dolsen@gentoo.org> (raw)
In-Reply-To: <1386991708-9385-1-git-send-email-dolsen@gentoo.org>
Commit b3475906d5f51a21ecaf4ff048002a2f44face52 introduced an
undefined variable "s". The code must always be hitting the
general except: pass block. Seems useless, if not maybe it'll
spit out a true error, so the real problem can be fixed. Removed it all.
---
catalyst/support.py | 8 --------
1 file changed, 8 deletions(-)
diff --git a/catalyst/support.py b/catalyst/support.py
index 0ddf98d..2133799 100644
--- a/catalyst/support.py
+++ b/catalyst/support.py
@@ -433,15 +433,7 @@ def spawn(mycommand,env={},raw_exit_code=False,opt_name=None,fd_pipes=None,retur
if trg_fd[x] == src_fd[x]:
continue
if trg_fd[x] in src_fd[x+1:]:
- new=os.dup2(trg_fd[x],max(src_fd) + 1)
os.close(trg_fd[x])
- try:
- while True:
- src_fd[s.index(trg_fd[x])]=new
- except SystemExit, e:
- raise
- except:
- pass
# transfer the fds to their final pre-exec position.
for x in range(0,len(trg_fd)):
--
1.8.3.2
next prev parent reply other threads:[~2013-12-14 3:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-14 3:28 [gentoo-catalyst] rewite-on-master patches round-3 Brian Dolbec
2013-12-14 3:28 ` [gentoo-catalyst] [PATCH 1/3] Remove unused urllib import Brian Dolbec
2013-12-14 3:28 ` Brian Dolbec [this message]
2013-12-14 3:28 ` [gentoo-catalyst] [PATCH 3/3] Fix undefined variable: RLIMIT_NOFILE Brian Dolbec
2013-12-14 5:28 ` [gentoo-catalyst] rewite-on-master patches round-3 Matt Turner
2013-12-14 23:53 ` W. Trevor King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386991708-9385-3-git-send-email-dolsen@gentoo.org \
--to=dolsen@gentoo.org \
--cc=gentoo-catalyst@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox