From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id CBDDE138247 for ; Sat, 14 Dec 2013 16:23:02 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 46A08E0B06; Sat, 14 Dec 2013 16:23:00 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id ACE79E0B06 for ; Sat, 14 Dec 2013 16:22:59 +0000 (UTC) Received: from [192.168.1.210] (S010600222de111ff.vc.shawcable.net [96.49.5.156]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: dolsen) by smtp.gentoo.org (Postfix) with ESMTPSA id D0A2433F2AD for ; Sat, 14 Dec 2013 16:22:58 +0000 (UTC) Message-ID: <1387038167.3897.159.camel@big_daddy.dol-sen.ca> Subject: Re: [gentoo-catalyst] [PATCH 3/4] Adapt commit c52962b6bd2 to use the new configured settings values. From: Brian Dolbec To: gentoo-catalyst@lists.gentoo.org Date: Sat, 14 Dec 2013 08:22:47 -0800 In-Reply-To: <693519560.0lWei86J99@moiraine> References: <1386990436-9198-1-git-send-email-dolsen@gentoo.org> <1386990436-9198-4-git-send-email-dolsen@gentoo.org> <693519560.0lWei86J99@moiraine> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-dM1ulvPjdrPBaEy3OfDi" X-Mailer: Evolution 3.6.4 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org Mime-Version: 1.0 X-Archives-Salt: bc332784-1e61-4521-9e25-a631e072f1b8 X-Archives-Hash: 5aaa2c8f22acb05da0cb114720ad16e4 --=-dM1ulvPjdrPBaEy3OfDi Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, 2013-12-14 at 06:54 -0800, Dylan Baker wrote: > On Friday, December 13, 2013 07:07:15 PM Brian Dolbec wrote: > > --- > > modules/generic_stage_target.py | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > >=20 > > diff --git a/modules/generic_stage_target.py > > b/modules/generic_stage_target.py index 342c65b..1fbc733 100644 > > --- a/modules/generic_stage_target.py > > +++ b/modules/generic_stage_target.py > > @@ -1066,9 +1066,9 @@ class generic_stage_target(generic_target): > > "/use will cause portage to ignore" > > print "\tpackage.use in the profile and portage_confdir.=20 > You've been > > warned!" > >=20 > > - myf.write('PORTDIR=3D"/usr/portage"\n') > > - myf.write('DISTDIR=3D"${PORTDIR}/distfiles"\n') > > - myf.write('PKGDIR=3D"${PORTDIR}/packages"\n') > > + myf.write('PORTDIR=3D"%s"\n' % self.settings['portdir']) > > + myf.write('DISTDIR=3D"%s"\n' % self.settings['distdir']) > > + myf.write('PKGDIR=3D"%s"\n' % self.settings['packagedir']) >=20 > what is the point of this? These produce exactly the same output, except = the=20 > previous is more readable. >=20 Sure it is more readable in that one spot. BUT... The point is the entire reason for the whole re-write I started in the first place. Removing hard coded paths scattered throughout the code. Putting them in one easily modified and maintainable place.=20 > >=20 > > """ Setup the portage overlay """ > > if "portage_overlay" in self.settings: --=-dM1ulvPjdrPBaEy3OfDi Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQF8BAABCgBmBQJSrIXXXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ4Njg4RkQxQ0M3MUMxQzA0RUFFQTQyMzcy MjE0RDkwQTAxNEYxN0NCAAoJECIU2QoBTxfLXigH/A/WDiSJsTtPK1MfLVuB1Xxt HsQWYp6QLRUzlvbwRYiPJaOYTHLZ+bEuBAtBRHCalnarvXWkJqfOU9+qfJtJNs3F lDiPUBulr4iVs37pFlcCUoOMMenM+lNbkIcZnkxsibWFM0XU/Zw1ha6Qlqn7qtMU AMPgSLmVh8v70NsB9j15cyAxXapE5oWcCmZ/5BSNgTKMlz0eQ4sWlaTAgDRLjj7J P2ZEJJMS4owri0Lzf17DNZ/Xa78Z1f3qtdTeD4gHJht6j7z9jWh68WfdlBu1TFou APhKAA9/5uDOPA/LxwYs/ysA1gtLi1ydLXgMPycl7K6/rsWpPFiVuUAsObDY2jc= =VeW4 -----END PGP SIGNATURE----- --=-dM1ulvPjdrPBaEy3OfDi--