From: Brian Dolbec <dolsen@gentoo.org>
To: gentoo-catalyst@lists.gentoo.org
Subject: Re: [gentoo-catalyst] [PATCH 1/3] Remove some troublesome trailing slashes from paths
Date: Tue, 17 Dec 2013 21:40:52 -0800 [thread overview]
Message-ID: <1387345252.3897.208.camel@big_daddy.dol-sen.ca> (raw)
In-Reply-To: <20131218034105.GF25409@odin.tremily.us>
[-- Attachment #1: Type: text/plain, Size: 830 bytes --]
On Tue, 2013-12-17 at 19:41 -0800, W. Trevor King wrote:
> On Tue, Dec 17, 2013 at 05:12:09PM -0800, Brian Dolbec wrote:
> > - self.settings["snapshot"]+"/")
> > + self.settings["snapshot"])
> > …
> > - "/tmp/"+self.settings["target_subpath"]+"/")
> > + "/tmp/"+self.settings["target_subpath"])
> > …
> > - self.settings["version_stamp"]+"/")
> > + self.settings["version_stamp"])
>
> Acked by me, although I think path consumers should be able to handle
> both forms.
>
> Cheers,
> Trevor
>
They should, but I found catalyst's code to be fragile, fixing these
issues got things working again. I also found that once fixed, things
seemed to be more stable when making changes.
Plus I like it better when looking through output to see it not have //
or /// in the middle of a path.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 620 bytes --]
next prev parent reply other threads:[~2013-12-18 5:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-18 1:12 [gentoo-catalyst] Path addition fixes to prevent multiple slashes in paths Brian Dolbec
2013-12-18 1:12 ` [gentoo-catalyst] [PATCH 1/3] Remove some troublesome trailing slashes from paths Brian Dolbec
2013-12-18 3:41 ` W. Trevor King
2013-12-18 5:40 ` Brian Dolbec [this message]
2013-12-18 1:12 ` [gentoo-catalyst] [PATCH 2/3] Remove an extra slash in the path Brian Dolbec
2013-12-18 3:42 ` W. Trevor King
2013-12-18 1:12 ` [gentoo-catalyst] [PATCH 3/3] Fix a relative path bug Brian Dolbec
2013-12-18 3:48 ` W. Trevor King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387345252.3897.208.camel@big_daddy.dol-sen.ca \
--to=dolsen@gentoo.org \
--cc=gentoo-catalyst@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox