From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id B8782138247 for ; Wed, 18 Dec 2013 05:41:09 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 53F4CE0AA9; Wed, 18 Dec 2013 05:41:08 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id CE1D5E0AA9 for ; Wed, 18 Dec 2013 05:41:07 +0000 (UTC) Received: from [192.168.1.210] (S010600222de111ff.vc.shawcable.net [96.49.5.156]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: dolsen) by smtp.gentoo.org (Postfix) with ESMTPSA id D393D33F59B for ; Wed, 18 Dec 2013 05:41:06 +0000 (UTC) Message-ID: <1387345252.3897.208.camel@big_daddy.dol-sen.ca> Subject: Re: [gentoo-catalyst] [PATCH 1/3] Remove some troublesome trailing slashes from paths From: Brian Dolbec To: gentoo-catalyst@lists.gentoo.org Date: Tue, 17 Dec 2013 21:40:52 -0800 In-Reply-To: <20131218034105.GF25409@odin.tremily.us> References: <1387329131-25890-1-git-send-email-dolsen@gentoo.org> <1387329131-25890-2-git-send-email-dolsen@gentoo.org> <20131218034105.GF25409@odin.tremily.us> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-osOpiztM2IIS9q6makbA" X-Mailer: Evolution 3.6.4 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org Mime-Version: 1.0 X-Archives-Salt: 21097f8c-8e1a-4ae8-9225-4c81ff4271a1 X-Archives-Hash: fbf14ddaee51034e20645cf394c73bac --=-osOpiztM2IIS9q6makbA Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2013-12-17 at 19:41 -0800, W. Trevor King wrote: > On Tue, Dec 17, 2013 at 05:12:09PM -0800, Brian Dolbec wrote: > > - self.settings["snapshot"]+"/") > > + self.settings["snapshot"]) > > =E2=80=A6 > > - "/tmp/"+self.settings["target_subpath"]+"/") > > + "/tmp/"+self.settings["target_subpath"]) > > =E2=80=A6 > > - self.settings["version_stamp"]+"/") > > + self.settings["version_stamp"]) >=20 > Acked by me, although I think path consumers should be able to handle > both forms. >=20 > Cheers, > Trevor >=20 They should, but I found catalyst's code to be fragile, fixing these issues got things working again. I also found that once fixed, things seemed to be more stable when making changes. Plus I like it better when looking through output to see it not have // or /// in the middle of a path.=20 --=-osOpiztM2IIS9q6makbA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQF8BAABCgBmBQJSsTVkXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ4Njg4RkQxQ0M3MUMxQzA0RUFFQTQyMzcy MjE0RDkwQTAxNEYxN0NCAAoJECIU2QoBTxfLy9UIANWUC8vqilRhbvEGqmoecW0Y W3cjjyiZ8t4Z52I0Fdo8Bu0KDpgrm3uPd8xyxpFp3iXzBiSejr3TXyIBiR+JtfYx E4UtD9lli9ZdwsUgEhUjmYu7f6ro5DybIUxd6amDfq+cS44e35Swm1tJ3qjYIiin XSXsoxXz18zOgJqo3YXT+OtPGRWHm+DupIFs/+Enun6ypUqSzTDIKfeDc/frp81m lSAYUAqUwtIUGMgBk+ldr9jpuXl/YkMQpxEpCQeD/LyN/nEggAfjKKVslNE8JfeB LKc/dFPVD9hySs2Cw8gdklLqXe6RYVYkCNg82p2muWdjRMA6Q7Mg2C8pg0qN1Go= =0lq3 -----END PGP SIGNATURE----- --=-osOpiztM2IIS9q6makbA--