From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id B2567138247 for ; Thu, 19 Dec 2013 07:34:54 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 16DC8E07D7; Thu, 19 Dec 2013 07:34:53 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 92960E07D7 for ; Thu, 19 Dec 2013 07:34:52 +0000 (UTC) Received: from [192.168.1.210] (S010600222de111ff.vc.shawcable.net [96.49.5.156]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: dolsen) by smtp.gentoo.org (Postfix) with ESMTPSA id A842C33F605 for ; Thu, 19 Dec 2013 07:34:51 +0000 (UTC) Message-ID: <1387438476.3897.222.camel@big_daddy.dol-sen.ca> Subject: Re: [gentoo-catalyst] [PATCH 2/2] modules/generic_stage_target.py, modules/stage1_target.py: Add a target_mounts dictionary From: Brian Dolbec To: gentoo-catalyst@lists.gentoo.org Date: Wed, 18 Dec 2013 23:34:36 -0800 In-Reply-To: <20131218053547.GL25409@odin.tremily.us> References: <1387328847-25840-1-git-send-email-dolsen@gentoo.org> <1387328847-25840-3-git-send-email-dolsen@gentoo.org> <20131218032857.GD25409@odin.tremily.us> <1387343884.3897.204.camel@big_daddy.dol-sen.ca> <20131218053547.GL25409@odin.tremily.us> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-US/SMF1+fOqZI9SJ/DAR" X-Mailer: Evolution 3.6.4 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org Mime-Version: 1.0 X-Archives-Salt: 2b7a9baa-34a3-46e6-92b1-ac1a01b8fb7a X-Archives-Hash: ac6d66ea66e52a47dbf2c5356f4fe4b5 --=-US/SMF1+fOqZI9SJ/DAR Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2013-12-17 at 21:35 -0800, W. Trevor King wrote: > On Tue, Dec 17, 2013 at 09:18:04PM -0800, Brian Dolbec wrote: > > On Tue, 2013-12-17 at 19:28 -0800, W. Trevor King wrote: > > > On Tue, Dec 17, 2013 at 05:07:27PM -0800, Brian Dolbec wrote: > > > > - self.mounts.append("/var/log/portage") > > > > - self.mountmap["/var/log/portage"]=3Dself.settings["port_logdir"= ] > > > > - self.env["PORT_LOGDIR"]=3D"/var/log/portage" > > > > + self.mounts.append("port_logdir") > > > > + self.mountmap["port_logdir"]=3Dself.settings["port_logdir"] > > > > + self.env["PORT_LOGDIR"]=3Dself.settings["port_logdir"] > > >=20 > > > I also think that the PORT_LOGDIR environment variable > > > should be: > > >=20 > > > self.env["PORT_LOGDIR"] =3D self.target_mounts["port_logdir"] > I don't care about caps, I was trying to fix settings =E2=86=92 target_mo= unts, > since settings holds the mount source ;). >=20 > Cheers, > Trevor >=20 No, this code block is adding it to the environment if defined in settings. This patch was just removing the hard coded paths. This is the full if block: if "port_logdir" in self.settings: self.mounts.append("port_logdir") self.mountmap["port_logdir"]=3Dself.settings["port_logdir"] self.env["PORT_LOGDIR"]=3Dself.settings["port_logdir"] self.env["PORT_LOGDIR_CLEAN"]=3D'find "${PORT_LOGDIR}" -type f ! -name "= summary.log*" -mtime +30 -delete' So far it is not used from the new TARGET_MOUNTS_DEFAULTS. =20 It is so far only enabled if uncommented and defined in catalyst.conf or from the cli. Should I remove it from the TARGET_MOUNTS_DEFAULTS for the time being? --=20 Brian Dolbec --=-US/SMF1+fOqZI9SJ/DAR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQF8BAABCgBmBQJSsqGMXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ4Njg4RkQxQ0M3MUMxQzA0RUFFQTQyMzcy MjE0RDkwQTAxNEYxN0NCAAoJECIU2QoBTxfL6FkH+wcEwLmXKNb2hiCHjyDv7QrJ i3iMuAlePeGwdbUwv+4RzI6FGFGzrwIeMyZEykiWtKYUcadPcPARQInIZIMS1fY3 i5YbXqaAbxIP1x3jgorV2MT6Wi8Tm2JyokQ5gfFNlz1SxhEmyl7b8E8YaKSEcx0k zSjDqKT2p2Tn+0vgm5HUjmWz3aH/R5zB5VX9i70MdXAfJWanproL3eKvtKMjqeG+ M12urJvu4NZiXyIlcxOJpeS4lK7igDAdXWZRwX1tcFyFN+Ux+ecscrPfs6qAU0LE JancMjNrifAJQtB7bv9e5RYywmcO/enGwgaKB8voAuhjQDRLshpX1JsCI7Pyl/k= =6Ixe -----END PGP SIGNATURE----- --=-US/SMF1+fOqZI9SJ/DAR--