On Wed, 2013-12-18 at 23:34 -0800, Brian Dolbec wrote:
> On Tue, 2013-12-17 at 21:35 -0800, W. Trevor King wrote:
> > On Tue, Dec 17, 2013 at 09:18:04PM -0800, Brian Dolbec wrote:
> > > On Tue, 2013-12-17 at 19:28 -0800, W. Trevor King wrote:
> > > > On Tue, Dec 17, 2013 at 05:07:27PM -0800, Brian Dolbec wrote:
> 
> > > > > -			self.mounts.append("/var/log/portage")
> > > > > -			self.mountmap["/var/log/portage"]=self.settings["port_logdir"]
> > > > > -			self.env["PORT_LOGDIR"]="/var/log/portage"
> > > > > +			self.mounts.append("port_logdir")
> > > > > +			self.mountmap["port_logdir"]=self.settings["port_logdir"]
> > > > > +			self.env["PORT_LOGDIR"]=self.settings["port_logdir"]
> > > > 
> 
> > > >  I also think that the PORT_LOGDIR environment variable
> > > > should be:
> > > > 
> > > >   self.env["PORT_LOGDIR"] = self.target_mounts["port_logdir"]
> 
> > I don't care about caps, I was trying to fix settings → target_mounts,
> > since settings holds the mount source ;).
> > 
> > Cheers,
> > Trevor
> > 
> 
> No, this code block is adding it to the environment if defined in
> settings.  This patch was just removing the hard coded paths.
> 
> This is the full if block:
> 
> 		if "port_logdir" in self.settings:
> 			self.mounts.append("port_logdir")
> 			self.mountmap["port_logdir"]=self.settings["port_logdir"]
> 			self.env["PORT_LOGDIR"]=self.settings["port_logdir"]
> 			self.env["PORT_LOGDIR_CLEAN"]='find "${PORT_LOGDIR}" -type f ! -name "summary.log*" -mtime +30 -delete'
> 
> So far it is not used from the new TARGET_MOUNTS_DEFAULTS.  
> It is so far only enabled if uncommented and defined in catalyst.conf or
> from the cli.
> 
> Should I remove it from the TARGET_MOUNTS_DEFAULTS for the time being?

What we could do is add a "PortageLog" to the options setting which
would turn on and use the defaults unless otherwise overridden by
setting the port_logdir config option.  But that would be something to
add later.

This patch is to fix/complete the mounts, mountmap changes from the
hard-coded paths and paths as keys.