From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 4A214138247 for ; Sun, 29 Dec 2013 04:58:35 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 99E2AE0AF8; Sun, 29 Dec 2013 04:58:33 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 20F97E0AF8 for ; Sun, 29 Dec 2013 04:58:33 +0000 (UTC) Received: from [192.168.1.210] (S010600222de111ff.vc.shawcable.net [96.49.5.156]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: dolsen) by smtp.gentoo.org (Postfix) with ESMTPSA id 32B7733F6F8 for ; Sun, 29 Dec 2013 04:58:32 +0000 (UTC) Message-ID: <1388293089.24088.25.camel@big_daddy.dol-sen.ca> Subject: Re: [gentoo-catalyst] [PATCH 5/6] modules/generic_stage_target.py, modules/stage1_target.py: Add a target_mounts dictionary From: Brian Dolbec To: gentoo-catalyst@lists.gentoo.org Date: Sat, 28 Dec 2013 20:58:09 -0800 In-Reply-To: <20131229035239.GK29195@odin.tremily.us> References: <1388282230-3563-1-git-send-email-dolsen@gentoo.org> <1388282230-3563-6-git-send-email-dolsen@gentoo.org> <20131229024911.GH29195@odin.tremily.us> <20131229035239.GK29195@odin.tremily.us> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-ErZZ43/YbEdAEzSu/8Tg" X-Mailer: Evolution 3.6.4 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org Mime-Version: 1.0 X-Archives-Salt: 307a63b1-2855-4cba-b85f-1cf31f825a4d X-Archives-Hash: ac176bfe63d216491454974f0e02cd1b --=-ErZZ43/YbEdAEzSu/8Tg Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, 2013-12-28 at 19:52 -0800, W. Trevor King wrote: > On Sat, Dec 28, 2013 at 06:49:11PM -0800, W. Trevor King wrote: > > On Sat, Dec 28, 2013 at 05:57:09PM -0800, Brian Dolbec wrote: > > > - self.mounts.append("/tmp/stage1root/proc") > > > - self.mountmap["/tmp/stage1root/proc"]=3D"/proc" > > > + self.mounts.append("stage1root/proc") > > > + self.target_mounts["stage1root/proc"] =3D "/tmp/stage1root/proc" > > > + self.mountmap["stage1root/proc"]=3D"/proc" > >=20 > > Hmm. I'm not how this is handled at the moment, but don't we want: > >=20 > > mount -t proc none /tmp/stage1root/proc > >=20 > > instead of: > >=20 > > mount --bind /proc /tmp/stage1root/proc > >=20 > > The handbook is currently using --rbind as well [1]. > >=20 > > Maybe food for a future series :p. >=20 > After Douglas Freed talked me off the devtmpfs ledge on > #gentoo-releng, my current suggested mount changes are: >=20 > -t: > proc > --rbind: > sys > dev > portdir =20 > port_logdir > port_tmpdir > kerncache > ccache > icecream > drop: > devpts (now that we --rbind /dev) > distdir (now that we --rbind portdir) > packagedir (now that we --rbind portdir) >=20 > For distdir/packagedir, I'd be find if the source defaulted to None > (meaning =E2=80=9Cdon't mount anything=E2=80=9D) but could be configured = to a path > (meaning =E2=80=9C--rbind this after you've --rbind-mounted portdir=E2=80= =9D). >=20 > Cheers, > Trevor >=20 This series of patches was to just fix the migration from hard coded paths to centrally configurable ones. These mount changes should be commits unto themselves. Please don't confuse the issues... we have lots more changes to get through. I'm not saying anything against your proposed changes, just they're not for this commit. --=-ErZZ43/YbEdAEzSu/8Tg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQF8BAABCgBmBQJSv6vhXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ4Njg4RkQxQ0M3MUMxQzA0RUFFQTQyMzcy MjE0RDkwQTAxNEYxN0NCAAoJECIU2QoBTxfL3VEH+wT6HgpXpvOqMZJQcvo7YbWI syc+nWn+vIBylQydKlpWf24pUrne4DKIiQMK3QmLCJcfPveDFDjZK98zOnslG14Q r8a14FMucVAHrYlBdzLsyyQZmPjNL6MD9KeTkSiXPsulZw/3zDZHYc75sUsVjlD7 QeS8yU5QexqRkY28uNQQW1urqM5dSFtJLF30dMxhXQcwy3qICZw19mJs6+T5UMH0 40oI/DlcCOZQOgkIAKX+mPnIc2k3Urn/bharPVEM25cl9A0XL/VbXdWKHkLAA8ru SJDIuWRLc4Kikv5Gwgg/GNrtaog2+z0H/aCUzCgbjG7GE6Cycer9SgKJ2mPq4Zc= =HVH4 -----END PGP SIGNATURE----- --=-ErZZ43/YbEdAEzSu/8Tg--