On Sat, 2013-12-28 at 18:49 -0800, W. Trevor King wrote: > On Sat, Dec 28, 2013 at 05:57:09PM -0800, Brian Dolbec wrote: > > +# temporary location. It will be moved to a > > +# new defaults file in a later comit > > Hopefully those later commits will land, but maybe they won't. I'd > rather comment on future goals in the Git commit instead of in the > source code. Fair enough... > > > + # initialize our target mounts. > > + # later I plan to make these configurable so the > > + # defaults can be easily overridden if desired. > > + self.target_mounts = TARGET_MOUNTS_DEFAULTS.copy() > > See above about future goals in the Git commit. > > > - self.mounts.append("/var/log/portage") > > - self.mountmap["/var/log/portage"]=self.settings["port_logdir"] > > - self.env["PORT_LOGDIR"]="/var/log/portage" > > + self.mounts.append("port_logdir") > > + self.mountmap["port_logdir"]=self.settings["port_logdir"] > > + self.env["PORT_LOGDIR"]=self.target_mounts["port_logdir"] > > Looks good. The mounts/mountmap changes are orthogonal to the > target_mounts addition, but it's probably not worth splitting them out > into a separate fixup. Yeah, I missed separating some of that. Looks like I have to rebase the hell out of these again anyway, so, maybe I will... > Cheers, > Trevor