From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id C1F50138247 for ; Sun, 29 Dec 2013 05:02:54 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 60C8EE0B15; Sun, 29 Dec 2013 05:02:53 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id E7E50E0B15 for ; Sun, 29 Dec 2013 05:02:52 +0000 (UTC) Received: from [192.168.1.210] (S010600222de111ff.vc.shawcable.net [96.49.5.156]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: dolsen) by smtp.gentoo.org (Postfix) with ESMTPSA id 0927833F498 for ; Sun, 29 Dec 2013 05:02:51 +0000 (UTC) Message-ID: <1388293349.24088.29.camel@big_daddy.dol-sen.ca> Subject: Re: [gentoo-catalyst] [PATCH 5/6] modules/generic_stage_target.py, modules/stage1_target.py: Add a target_mounts dictionary From: Brian Dolbec To: gentoo-catalyst@lists.gentoo.org Date: Sat, 28 Dec 2013 21:02:29 -0800 In-Reply-To: <20131229024911.GH29195@odin.tremily.us> References: <1388282230-3563-1-git-send-email-dolsen@gentoo.org> <1388282230-3563-6-git-send-email-dolsen@gentoo.org> <20131229024911.GH29195@odin.tremily.us> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-8boAUcjmgaPMLmk2+6yX" X-Mailer: Evolution 3.6.4 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org Mime-Version: 1.0 X-Archives-Salt: 06d5818c-ab83-4185-af69-db6e12bf5548 X-Archives-Hash: de15661ec4032f8769c2c57194d43293 --=-8boAUcjmgaPMLmk2+6yX Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, 2013-12-28 at 18:49 -0800, W. Trevor King wrote: > On Sat, Dec 28, 2013 at 05:57:09PM -0800, Brian Dolbec wrote: > > +# temporary location. It will be moved to a > > +# new defaults file in a later comit >=20 > Hopefully those later commits will land, but maybe they won't. I'd > rather comment on future goals in the Git commit instead of in the > source code. Fair enough... >=20 > > + # initialize our target mounts. > > + # later I plan to make these configurable so the > > + # defaults can be easily overridden if desired. > > + self.target_mounts =3D TARGET_MOUNTS_DEFAULTS.copy() >=20 > See above about future goals in the Git commit. >=20 > > - self.mounts.append("/var/log/portage") > > - self.mountmap["/var/log/portage"]=3Dself.settings["port_logdir"] > > - self.env["PORT_LOGDIR"]=3D"/var/log/portage" > > + self.mounts.append("port_logdir") > > + self.mountmap["port_logdir"]=3Dself.settings["port_logdir"] > > + self.env["PORT_LOGDIR"]=3Dself.target_mounts["port_logdir"] >=20 > Looks good. The mounts/mountmap changes are orthogonal to the > target_mounts addition, but it's probably not worth splitting them out > into a separate fixup. Yeah, I missed separating some of that. Looks like I have to rebase the hell out of these again anyway, so, maybe I will... > Cheers, > Trevor --=-8boAUcjmgaPMLmk2+6yX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQF8BAABCgBmBQJSv6zlXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ4Njg4RkQxQ0M3MUMxQzA0RUFFQTQyMzcy MjE0RDkwQTAxNEYxN0NCAAoJECIU2QoBTxfL5wQH+wdJd5xEcx6snHlC7U+3LFTc p1jvyGEq/0F/Ljyu8KHBzoOou+qLWnlQScO20UmGMcDKWIKL5t/a2KnvUHnRaIhC iy6HCuCX4HQBKFImP2jCEAGs3pD2bIYZSbcxneK+nuAlTglw2WJg2W7IhpxYPlg6 rr9MjhUoAk5sxOrSIf2A+hVh576uzt/FcBZvJy2fLIkYVr6/wmJuvwABMQf+yDHk Yi+ZVDSV58WhO6oPaXTXT+eLPHd87701OD0+Q81YN9hbK3eP8E7ScO2BiKK0c4xb YuJmLZVris1InIVPMKyz9Te+BSqC4un9lIfd5En8gAT0Xhcf2LEpjrBI9jPsNtg= =Ci4j -----END PGP SIGNATURE----- --=-8boAUcjmgaPMLmk2+6yX--