From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id A0DB8138247 for ; Sun, 29 Dec 2013 05:08:27 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 795BEE0B15; Sun, 29 Dec 2013 05:08:26 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 00435E0B15 for ; Sun, 29 Dec 2013 05:08:25 +0000 (UTC) Received: from [192.168.1.210] (S010600222de111ff.vc.shawcable.net [96.49.5.156]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: dolsen) by smtp.gentoo.org (Postfix) with ESMTPSA id DEE6E33F68C for ; Sun, 29 Dec 2013 05:08:24 +0000 (UTC) Message-ID: <1388293682.24088.33.camel@big_daddy.dol-sen.ca> Subject: Re: [gentoo-catalyst] [PATCH 2/6] Fix a missed self.settings["repo_name"] migration From: Brian Dolbec To: gentoo-catalyst@lists.gentoo.org Date: Sat, 28 Dec 2013 21:08:02 -0800 In-Reply-To: <20131229021926.GE29195@odin.tremily.us> References: <1388282230-3563-1-git-send-email-dolsen@gentoo.org> <1388282230-3563-3-git-send-email-dolsen@gentoo.org> <20131229021926.GE29195@odin.tremily.us> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-vYXxSwpBFnRAjeXkPmlM" X-Mailer: Evolution 3.6.4 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org Mime-Version: 1.0 X-Archives-Salt: 9c64f249-5a35-4cf4-add1-a6d1c51498da X-Archives-Hash: 5d6b858415a66b53452e2dbb7c215117 --=-vYXxSwpBFnRAjeXkPmlM Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, 2013-12-28 at 18:19 -0800, W. Trevor King wrote: > On Sat, Dec 28, 2013 at 05:57:06PM -0800, Brian Dolbec wrote: > > - "portdir":self.settings["snapshot_cache_path"]+"/portage",\ > > + "portdir": normpath(self.settings["snapshot_cache_path"] + "/" + > > + self.settings["repo_name"]), > > "distdir":self.settings["distdir"],"port_tmpdir":"tmpfs"} >=20 > Ah, this is getting rid of that trailing backslash, so I'm fine if it > stays in the previous commit. We're still missing the space before > =E2=80=9C"port_tmpdir"=E2=80=9D. The use of normpath and the repo_name s= etting look > good. >=20 > Cheers, > Trevor >=20 That too is not part of what this commit is changing. That line is a context line. This commit is touching the previous line. This commit is also not a whitespace cleanup. --=-vYXxSwpBFnRAjeXkPmlM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQF8BAABCgBmBQJSv64yXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ4Njg4RkQxQ0M3MUMxQzA0RUFFQTQyMzcy MjE0RDkwQTAxNEYxN0NCAAoJECIU2QoBTxfLCKcIALRQWI2/Wt58q4si/Rx/PZU7 lFCo7xUousXPaImKuJ5jT8+OP9StOzmDitDbmE9ONWm59VQKbaAmSe7TK0tm6G22 3ml/ELASbSMTD1ncy4+FxqDHF8Zmwi7D9syMHj5wsxyPPYinKmVsvYccTk+xjakK c4dLHhEeSA5F3tGz1MANo23kDTHk/6TbbBaMNeabCTULrX2RqzuTGsBJpVWro+08 AWnHsrkAIMGi+v037kgHSZ37NLfvzhQLX23jc6/hghQx7tDJZZFITPRAaw4dCB26 Dm2QNDpBLkA4EKqXJmM+9JUTf/PlZPqmszVEjUlgi065+vRdWPM7nPbogkT6bl4= =+vgl -----END PGP SIGNATURE----- --=-vYXxSwpBFnRAjeXkPmlM--