From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 7EB351387B1 for ; Mon, 30 Dec 2013 05:33:02 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 5760CE0B1F; Mon, 30 Dec 2013 05:33:00 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id DBF77E0B1F for ; Mon, 30 Dec 2013 05:32:59 +0000 (UTC) Received: from [192.168.1.210] (S010600222de111ff.vc.shawcable.net [96.49.5.156]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: dolsen) by smtp.gentoo.org (Postfix) with ESMTPSA id 9C9FF33F217 for ; Mon, 30 Dec 2013 05:32:58 +0000 (UTC) Message-ID: <1388381555.24088.63.camel@big_daddy.dol-sen.ca> Subject: Re: [gentoo-catalyst] [PATCH 3/6] Fixes commit 463d98f (modules/generic_stage_target.py: Use a 'local_overlay' setting instead of hard-coding '/usr/local/portage', 2012-12-19).Add "local_overlay" to configdefaults. From: Brian Dolbec To: gentoo-catalyst@lists.gentoo.org Date: Sun, 29 Dec 2013 21:32:35 -0800 In-Reply-To: <20131230040215.GP29195@odin.tremily.us> References: <1388282230-3563-1-git-send-email-dolsen@gentoo.org> <1388368253-22018-1-git-send-email-dolsen@gentoo.org> <1388368253-22018-4-git-send-email-dolsen@gentoo.org> <20131230040215.GP29195@odin.tremily.us> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-n+wGDQXUba2WQ27h6QQi" X-Mailer: Evolution 3.6.4 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org Mime-Version: 1.0 X-Archives-Salt: 713da70b-d140-4900-97b6-a9cf97802b96 X-Archives-Hash: 9d2d75489afdce2944074ee5c9610e47 --=-n+wGDQXUba2WQ27h6QQi Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, 2013-12-29 at 20:02 -0800, W. Trevor King wrote: > That's a long subject ;). How about: >=20 > Add "local_overlay" to configdefaults >=20 > Fixes commit 463d98f (modules/generic_stage_target.py: Use a > 'local_overlay' setting instead of hard-coding '/usr/local/portage', > 2012-12-19). >=20 > That gives you both a concise summary and a more detailed body without > making wrapping in `git log --oneline`. >=20 > Cheers, > Trevor >=20 First: I'm not feeling well, so please don't take this too personally. I committed exactly what you had in the previous review (copy/paste). I knew it was too long, but when I tried breaking it up, git puked on it. so I thought what the hell and left it. I wasn't going to "waste" more time on it. --=-n+wGDQXUba2WQ27h6QQi Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQF8BAABCgBmBQJSwQVzXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ4Njg4RkQxQ0M3MUMxQzA0RUFFQTQyMzcy MjE0RDkwQTAxNEYxN0NCAAoJECIU2QoBTxfLn2QH/2HXmxODQ4WbwsPCk/tXXQHP haI+42gYtwQXSyO5S89Mg4J1fToLAOYHYcUMyosnElp2yaKNdzG8GVrEnkqG++vV 5yMa4FKM3VocK9OVyWZj4+EaUGcdbcFQKVcATi+/1iTlApUjRgUG4PopMoiqL5xc ZZfyqTodkFgGBAYp98EaTjhm9gu++fjQUd3Wxx6jDy3iBK5Ra7EgS8b2rD7WLHYi OzyYEsXKpBKu1B1SmNIw/PRMg/D9zAZ9k6GVRn9NkFmEijX5Cf/vK/drvxwH3VdB 2cU7jaMEvC4IvE72+Jo9jxr7FiXjfzXeXWvNWTMPBrDyQ8aLt8iQVlbzNr3kCiU= =/IbB -----END PGP SIGNATURE----- --=-n+wGDQXUba2WQ27h6QQi--