From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id F0E3C138247 for ; Mon, 30 Dec 2013 05:46:34 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 6703AE0B23; Mon, 30 Dec 2013 05:46:34 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id E5B52E0B23 for ; Mon, 30 Dec 2013 05:46:33 +0000 (UTC) Received: from [192.168.1.210] (S010600222de111ff.vc.shawcable.net [96.49.5.156]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: dolsen) by smtp.gentoo.org (Postfix) with ESMTPSA id C4CE733F5DF for ; Mon, 30 Dec 2013 05:46:32 +0000 (UTC) Message-ID: <1388382369.24088.76.camel@big_daddy.dol-sen.ca> Subject: Re: [gentoo-catalyst] [PATCH 4/6] Fix mounts and mountmap port_logdir code block. From: Brian Dolbec To: gentoo-catalyst@lists.gentoo.org Date: Sun, 29 Dec 2013 21:46:09 -0800 In-Reply-To: <20131230040933.GQ29195@odin.tremily.us> References: <1388282230-3563-1-git-send-email-dolsen@gentoo.org> <1388368253-22018-1-git-send-email-dolsen@gentoo.org> <1388368253-22018-5-git-send-email-dolsen@gentoo.org> <20131230040933.GQ29195@odin.tremily.us> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-ykCugssOC140ySYenmtu" X-Mailer: Evolution 3.6.4 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org Mime-Version: 1.0 X-Archives-Salt: 53762732-abee-40c0-a0ea-60dc0d31ca77 X-Archives-Hash: d3cf72288c816179c2a707002632a999 --=-ykCugssOC140ySYenmtu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, 2013-12-29 at 20:09 -0800, W. Trevor King wrote: > On Sun, Dec 29, 2013 at 05:50:51PM -0800, Brian Dolbec wrote: > > +PORT_LOGDIR_CLEAN =3D \ > > + 'find "${PORT_LOGDIR}" -type f ! -name "summary.log*" -mtime +30 -del= ete' >=20 > Pulling out this global variable is new for v2. I don't think I'm a > fan. I think it should either be hard-coded where we setup > env["PORT_LOGDIR_CLEAN"] (as it was before) or pulled out of > self.settings (like PORT_LOGDIR). >=20 > > - self.mounts.append("/var/log/portage") > > - self.mountmap["/var/log/portage"]=3Dself.settings["port_logdir"] > > - self.env["PORT_LOGDIR"]=3D"/var/log/portage" > > - self.env["PORT_LOGDIR_CLEAN"]=3D'find "${PORT_LOGDIR}" -type f ! -n= ame "summary.log*" -mtime +30 -delete' > > + self.mounts.append("port_logdir") > > + self.mountmap["port_logdir"] =3D self.settings["port_logdir"] > > + self.env["PORT_LOGDIR"] =3D self.settings["port_logdir"] > > + self.env["PORT_LOGDIR_CLEAN"] =3D PORT_LOGDIR_CLEAN >=20 > Other than the newly-global PORT_LOGDIR_CLEAN, this looks good to me. >=20 > Cheers, > Trevor >=20 PORT_LOGDIR_CLEAN is a copy of the setting directly from portage. I fully intend on importing it later when it makes more sense to actually make use of some of portage's api. In the meantime this moves it out of a long line situation in the code block that would have meant cutting and splicing it back together. When the commit that makes the new defaults.py file is merged. It will be moved there. Later when we import some info/code from portage. We can assign it accordingly. --=-ykCugssOC140ySYenmtu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQF8BAABCgBmBQJSwQihXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ4Njg4RkQxQ0M3MUMxQzA0RUFFQTQyMzcy MjE0RDkwQTAxNEYxN0NCAAoJECIU2QoBTxfLPdQIALODyA5QoU1NxIuw4c6tKKk1 QzmHT0+6A0XWJMN5ABJUYZJLaD5f4euvXWNpT/BLXvX/Kc8sUBKHFT/k680MLWnf yTTRXEpS5s76zL3CNpf4KuvHphmi1X5p54Gi+tIOEAw77xtREtaFO8TfQZDeJGHU lbINpmLP1C2bCKRY+OPv82JMl/x49Ajxm0rr2N+II+Yf5fgWv4uh3RG2ln/jPS6Y 44oJgRUYQEhZTQcxPS8ZIaUCc1pIh4hwcZGW1nD5p0JC0utQ/4498HxbVcR6rnwz 38eiogkAXo3aIJju7jkbdDvFEo36YnsX/Skfi98VlKh1xvyq0C5b7vprm+L6k+M= =7jSr -----END PGP SIGNATURE----- --=-ykCugssOC140ySYenmtu--