public inbox for gentoo-catalyst@lists.gentoo.org
 help / color / mirror / Atom feed
From: Dylan Baker <baker.dylan.c@gmail.com>
To: gentoo-catalyst@lists.gentoo.org
Cc: Brian Dolbec <dolsen@gentoo.org>, mattst88@gentoo.org
Subject: Re: [gentoo-catalyst] [PATCH 1/4] catalyst: Specify python2 rather than the generic python
Date: Sun, 13 Oct 2013 13:52:17 -0700	[thread overview]
Message-ID: <1683754.lvnGzHNCps@moiraine> (raw)
In-Reply-To: <1381682033.24205.117.camel@big_daddy.dol-sen.ca>

[-- Attachment #1: Type: text/plain, Size: 1505 bytes --]

On Sunday, October 13, 2013 09:33:53 AM Brian Dolbec wrote:
> On Fri, 2013-10-11 at 14:58 -0700, Matt Turner wrote:
> > On Fri, Oct 11, 2013 at 2:11 PM, Brian Dolbec <dolsen@gentoo.org> wrote:
> > > The default tree location move is waiting on the catalyst rewrite code
> > > to go live producing stages, etc..
> > 
> > I'm exactly sure what this means, but I think you might mean something
> > like renaming master to old-master and your branch to master. That's
> > not the right way to do it, and that's not how git works.
> 
> No, completely wrong.  The default tree location is going to be moved
> from /usr/portage to somewhere in /var (they never could agree where)
> and distfiles and packages directories are being moved out of the
> PORTDIR tree directory.
> 
> Current catalyst master code has tree paths hardcoded everywhere.  Not
> only that, but the paths are often used as both a path and a variable
> name in many places.
> 
> That makes it impossible for the tree move to happen and have catalyst
> work correctly to produce stages, etc. with the new default locations.
> 
> That is why I started to work on catalyst in the first place.  But the
> code is such a mess, I couldn't stop there with the encouragement of
> many from the releng team.

I think what Matt is suggesting is that you split your rebase-on-master branch 
into logical series and send them to the list for review and merger into 
master. A Git workflow is one of incremental, reviewed changes being merged 
over time.

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

      reply	other threads:[~2013-10-13 20:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-11 17:38 [gentoo-catalyst] [PATCH 1/4] catalyst: Specify python2 rather than the generic python Dylan Baker
2013-10-11 17:38 ` [gentoo-catalyst] [PATCH 2/4] Catalyst: use a more pythonic method to import modules Dylan Baker
2013-10-11 18:00   ` [gentoo-catalyst] " Dylan Baker
2013-10-11 17:38 ` [gentoo-catalyst] [PATCH 3/4] catalyst: split combined import Dylan Baker
2013-10-11 17:38 ` [gentoo-catalyst] [PATCH 4/4] catalyst: Remove commented sections of code Dylan Baker
2013-10-11 18:15 ` [gentoo-catalyst] [PATCH 1/4] catalyst: Specify python2 rather than the generic python Brian Dolbec
2013-10-11 19:28   ` Matt Turner
2013-10-11 21:11     ` Brian Dolbec
2013-10-11 21:58       ` Matt Turner
2013-10-13  9:19         ` Dylan Baker
2013-10-13 16:33         ` Brian Dolbec
2013-10-13 20:52           ` Dylan Baker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1683754.lvnGzHNCps@moiraine \
    --to=baker.dylan.c@gmail.com \
    --cc=dolsen@gentoo.org \
    --cc=gentoo-catalyst@lists.gentoo.org \
    --cc=mattst88@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox