From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id F18BA138247 for ; Sat, 14 Dec 2013 16:31:39 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 7DF71E0B4D; Sat, 14 Dec 2013 16:31:39 +0000 (UTC) Received: from qmta07.westchester.pa.mail.comcast.net (qmta07.westchester.pa.mail.comcast.net [76.96.62.64]) by pigeon.gentoo.org (Postfix) with ESMTP id F123AE0B4D for ; Sat, 14 Dec 2013 16:31:38 +0000 (UTC) Received: from omta01.westchester.pa.mail.comcast.net ([76.96.62.11]) by qmta07.westchester.pa.mail.comcast.net with comcast id 1UK01n0060EZKEL57UXehb; Sat, 14 Dec 2013 16:31:38 +0000 Received: from odin.tremily.us ([24.18.63.50]) by omta01.westchester.pa.mail.comcast.net with comcast id 1UXc1n00p152l3L3MUXdwW; Sat, 14 Dec 2013 16:31:38 +0000 Received: by odin.tremily.us (Postfix, from userid 1000) id 0ECDAD67EDD; Sat, 14 Dec 2013 08:31:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tremily.us; s=odin; t=1387038696; bh=cstIjHXema9irAMtCiuqMES9hEVPO+OUGEL2nyatyMg=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=Sy+2lw6mIk2kBQj3qqYYDeW/JuYC83gUUpDFCZvlFtn9/PpSqoMiGI85eF9tgHk/z yuDDglBZHlETyP4WqCU+r0PbtQgBZp1CnqGocIypfmmmXAkh5FsMidPK5HwmsvSvEH YNNDNd3p6X0oMqSV9wAt75R/AxLVah9w7Kpu+SQk= Date: Sat, 14 Dec 2013 08:31:35 -0800 From: "W. Trevor King" To: gentoo-catalyst@lists.gentoo.org Cc: Brian Dolbec Subject: Re: [gentoo-catalyst] [PATCH 1/4] Add more configured defaults Message-ID: <20131214163135.GX25409@odin.tremily.us> References: <1386990436-9198-1-git-send-email-dolsen@gentoo.org> <1386990436-9198-2-git-send-email-dolsen@gentoo.org> <1535770.iBKyIEEe9T@moiraine> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="p11K2BJEgMZL61bg" Content-Disposition: inline In-Reply-To: <1535770.iBKyIEEe9T@moiraine> OpenPGP: id=39A2F3FA2AB17E5D8764F388FC29BDCDF15F5BE8; url=http://tremily.us/pubkey.txt User-Agent: Mutt/1.5.22 (2013-10-16) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20121106; t=1387038698; bh=bgF3WKgrs/QZ0KwwUuosSljvRYFIhh6vIT2+D+qgVxg=; h=Received:Received:Received:Date:From:To:Subject:Message-ID: MIME-Version:Content-Type; b=YtSEzJNIDzgJn1iI+420uSP0x4L1IouzlSbvtQ46011Cr0TTU5ilHnaqzt0ksR13A 1RadYUd/QgYlsXF0FhAMalJgMzsRkywjlmQi+ml7UB++u4tiGIdZYGJc9R8lEwQpEA VwNnirJwCE+1BgUKy1Wh7hfvSYwlSS6czPG+/T4eMap5aOhXZcMEvD89X6IeRwxnv8 kMhvnHR9dUzqduXohL0MFoN4LWVVKtTzYFl3LhD+nPBfDXiy5201CrIPldNgFidzkF goxXHKcFi+1Qn51lkQ4VtRwMv/suV2Vb+gmrGWrCtce9sBelrsU5Xro2510XMj1p7d ILM1Ig3a/Kb+A== X-Archives-Salt: 24b029bb-8fdb-47aa-8e6e-a42dd2a08d2b X-Archives-Hash: 8b021337305e3f7bc3f2c94e59e38c7c --p11K2BJEgMZL61bg Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Dec 14, 2013 at 06:33:43AM -0800, Dylan Baker wrote: > On Friday, December 13, 2013 07:07:13 PM Brian Dolbec wrote: > > - confdefaults=3D{ "storedir":"/var/tmp/catalyst",\ > > - "sharedir":"/usr/share/catalyst","distdir":"/usr/portage/distfiles",\ > > - "portdir":"/usr/portage","options":"",\ > > - "snapshot_cache":"/var/tmp/catalyst/snapshot_cache",\ > > - "hash_function":"crc32"} > > + confdefaults=3D{ > > + "hash_function": "crc32", > > + "portdir": "/usr/portage", > > + "repo_name": "portage", > > + "sharedir": "/usr/lib/catalyst", > > + "snapshot_name": "portage-", > > + "snapshot_cache": "/var/tmp/catalyst/snapshot_cache", > > + "storedir": "/var/tmp/catalyst", > > + } >=20 > pleas keep the formatting style; no comma on the last element and > closing brace on the same line The =E2=80=9Cone entry per line, comma after last element, separate brace lines=E2=80=9D format is both easier to read and easier to diff. All the k= eys are lined up in an alphabetized column for you, and if you add something after storedir entry, you don't have to touch the storedir line to remove a closing brace and add a comma. Cheers, Trevor --=20 This email may be signed or encrypted with GnuPG (http://www.gnupg.org). For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy --p11K2BJEgMZL61bg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJSrIflAAoJEKKfehoaNkbtNJcQAIVXIlhOBCA2Gi+jXW3pzWGm 9ibBKoxIysIIgywrNkRTaoJyt3uMcVcLW5O7nhA8Nsuj1RvBF83/OawDZacumjRu ZtAZc01A0NZq12FLwXSxlrxfYzs5/blri06f4XrUTglNa56fnq8dTCv3REMlxm0s hlEeASj5ZP/ESVybs+b2wN73Jlx9bjkbl3Aa6hVet3I4aL8/ksC5b8NaFjKGIEVB nW5QJ/CD76x+sD6KRD5xlckuqk9QtYPON5Ve7SKhXkMLnmNlEBO1x81X6gTfjFG1 47mWTTagbhdc3fpK3mrja2cPDtR2bopNsdLrrdA+SulxN//QzAEcIPnFoMjfLsdz 7tx8+zamfbrF/zpABZOz4BgcQYCx3DVdgEQRCZSYtn3X+Pc517nu+y5RdJzZh4jM P8ycB2svn7ry7ty22w2V5RpcJBY/DDblpukmB1EOsuxOzab9T3xkHY/JfC8HxJfc ObjwutA5/wgrUGnfzyhk65rDjRXHco1u4dPNTKozJ9mFqv4SMjHVTmKtRI3HqwI6 W6pbORCc1Nc9j9veZmLyNDH7H+G8Qo3z48YFEThPK5SmwyHQU1F3XyNHnpqbPqtM iIIR+b1zk8pyvnB0v9WTUM16rxuch/vEfmBDj/T66E5OPeL808LENx3jngTpmdoh dyIQFdsfEjCh+pTWED3m =ezMR -----END PGP SIGNATURE----- --p11K2BJEgMZL61bg--