From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id B9CB9138247 for ; Sat, 14 Dec 2013 16:37:17 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 1A7BAE0B7B; Sat, 14 Dec 2013 16:37:17 +0000 (UTC) Received: from qmta03.westchester.pa.mail.comcast.net (qmta03.westchester.pa.mail.comcast.net [76.96.62.32]) by pigeon.gentoo.org (Postfix) with ESMTP id 8965DE0B7B for ; Sat, 14 Dec 2013 16:37:16 +0000 (UTC) Received: from omta01.westchester.pa.mail.comcast.net ([76.96.62.11]) by qmta03.westchester.pa.mail.comcast.net with comcast id 1TWd1n0030EZKEL53UdGjz; Sat, 14 Dec 2013 16:37:16 +0000 Received: from odin.tremily.us ([24.18.63.50]) by omta01.westchester.pa.mail.comcast.net with comcast id 1UdF1n00B152l3L3MUdFs2; Sat, 14 Dec 2013 16:37:16 +0000 Received: by odin.tremily.us (Postfix, from userid 1000) id BB927D67F3B; Sat, 14 Dec 2013 08:37:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tremily.us; s=odin; t=1387039034; bh=tSa7U3jt1O8UFS/LI3ka91BSrCBECAQLppk18L5YiDY=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=noIUGoTOWDIg5YCtwf61IIQN+wHhfgrtuiMBwTjIEej4VNbSY+E8Ytj62ZBA4hiS5 pC2k95iDA0zlKUaj4xOtwH8tMH3/F5IebF2MMvjuUS2n/g8g303mx+q0owY6QmUUhE VWO5nVyDAe9hM+CfuIkSsT8kszMpULCCcf18HRJA= Date: Sat, 14 Dec 2013 08:37:14 -0800 From: "W. Trevor King" To: gentoo-catalyst@lists.gentoo.org Cc: Matt Turner Subject: Re: [gentoo-catalyst] [PATCH 2/4] Remove self.mounts and self.mountmap's use of paths for keys and paths. Message-ID: <20131214163714.GY25409@odin.tremily.us> References: <1386990436-9198-1-git-send-email-dolsen@gentoo.org> <1386990436-9198-3-git-send-email-dolsen@gentoo.org> <1387019742.3897.121.camel@big_daddy.dol-sen.ca> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="USQ0BwiCE5W4XvtQ" Content-Disposition: inline In-Reply-To: <1387019742.3897.121.camel@big_daddy.dol-sen.ca> OpenPGP: id=39A2F3FA2AB17E5D8764F388FC29BDCDF15F5BE8; url=http://tremily.us/pubkey.txt User-Agent: Mutt/1.5.22 (2013-10-16) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20121106; t=1387039036; bh=Cw49XJR1dLE2SGCjfsvKz41b+eDooUaam/fNxf7WoAU=; h=Received:Received:Received:Date:From:To:Subject:Message-ID: MIME-Version:Content-Type; b=CY24uE7kkAss1fGBPhz+FKz082LSQ+uniGNoAq8dSBOn+oeDolclTJH7cXACZkJYz eefVwQ68ODDDoFlBmaZKKPCDRjyb67Z+KFAkdLt6NsIrWo/bO0MCXCgx2/XiWbLRnt dQwYoNy67Y70eNe+5aE9aJwVUFLQ69ypIhdAbz0/c2g8SgymekY2AtEtQjpRs7w9Ba SdlmiV12ZBFYez6AF11SmR80ZWCyAwc8HlnrHVBPzceGX0vmBjm4Wxo27XW3s+bHNx KOIWNqw/YAJFxKKbwY7vTYviJmEemU2K8ROjCn/1tbSCTm9dRd2l3kBNPh5j/vLw9t oyz68bxMGqt4A== X-Archives-Salt: a70bc00e-3d36-4fb1-b1f5-624523dd5b3f X-Archives-Hash: a798f57d809607473e1e3bba2bbffa8a --USQ0BwiCE5W4XvtQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Dec 14, 2013 at 03:15:42AM -0800, Brian Dolbec wrote: > On Fri, 2013-12-13 at 21:08 -0800, Matt Turner wrote: > > On Fri, Dec 13, 2013 at 7:07 PM, Brian Dolbec wrote: > > > Migrate more hardcoded paths to use settings variables instead. > >=20 > > I can't really make any sense of the commit title,=20 >=20 > This is the full commit message in git: >=20 > Remove self.mounts and self.mountmap's use of paths for keys and paths. >=20 > Migrate more hardcoded paths to use settings variables instead. > --------------- >=20 > git send-email broke it up, using the first line as the subject, the > other lines are included in the main text body. `git log --oneline` will also only use the first line of the commit message, so it's nice to have it make sense. I don't think the current version reads too badly, but perhaps: Don't use paths as mountmap keys would cover it more succinctly? > > and it'd be preferable to do one path per patch. >=20 > Re-coding that mounts and mountmap mess was hard enough and required > lots of testing, fixing to get it correct and working. Splitting it > up even more is an exercise in futility. I'm playing around with this now ;). We'll see if I can get the commits reshuffled and preserve the same tree hash as Brian's a1f054e [1]. Cheers, Trevor [1]: http://git.overlays.gentoo.org/gitweb/?p=3Dproj/catalyst.git;a=3Dcommi= t;h=3Da1f054e5efaec3877a964e6a72410b5bbee9c03b --=20 This email may be signed or encrypted with GnuPG (http://www.gnupg.org). For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy --USQ0BwiCE5W4XvtQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJSrIk5AAoJEKKfehoaNkbtul4QAJ3TY1yWweDjn29iq3wkAs+z wI9MbxmpqU2Q2jMhl6lD6eWHRnHEpdi9zApb6OZ5VrEuuWhO70HWYJQF0WNEQ5cJ 2iqJt0qLBqb8tGfdmUBn7GN//KCdzcIr4Za5BMlzNu9AMlCBNN8QjWEFWuPFlDqd wnk4zyRHh914gBOcyHyFsLKu2HOLRgnxEp4TcourPCzZV5XYQtwM4dOf4RhfYRyS pH4tPvWoyGvi/gG+s0g4XoM1Vh16pgZ37XQahNK/3BNaKdfcTDNCDPlvaxenipHI 3P6ZIhH1Y7cvO4DGUKxTJjQDtKjHYf/9uHvq+2C5U8NfXvUUzJmqjfD7t+PIBIv9 INjljPwlxBoM8QKcmOZES7vCCkDyU+vENNUrSz3PFmlMtlniD3hxfmN+AA1XsAKN k2iYDs4c328T/WCsRndfw6AfriBEpYF8QdoAVorRDhxfv6qO8o06eEmotzC+tGjv Fq/K1OxmtBPhiQFrnoJYXHxGTTGdFu3U/Sqzgime8bD/m91kBepnzkN3B7H70rRC EVMTI6aYZV44Wulj3qJz23vJTyciFbQW98J4I05DZ9C5vHocqibENwGoSFk0x1r+ lmRIksJkaHxdjAklAxzPQXPZDprgA/Za84tbp38rz8zJrukYJGGiH/G3WN01hGcg YsAeRctAEqIxVeq81xke =BzW+ -----END PGP SIGNATURE----- --USQ0BwiCE5W4XvtQ--