On Sat, Dec 14, 2013 at 06:51:45AM -0800, Dylan Baker wrote:
> This is work for a seperate patch, but let's kill the self.mounts
> and replace it's use with self.mountmap.iterkeys()

So fill in mountmap with everything possible, and then pull keys out
of it if you don't need them?  Currently mountmap is “where would you
like ‘x’ mounted?” and mounts is “would you like ‘x’ mounted?”.  Those
seem separate enough that two attributes isn't crazy ;).

> > -			destdir=normpath(self.settings["chroot_path"]+"/usr/portage")
> > +			destdir=normpath(self.settings["chroot_path"] +
> 
> add a space after the '=' operator
> 
> There's more of this. please look through and add spaces beteen all
> of the operators, at least on the lines you've touched. This is
> standard python coding style and adhering to it makes all of our
> lives easier :)

The current code base is so far from PEP 8 that changing touched
sections to match PEP 8 looks really out of place.  In this instance
it's probably fine, but I'd ok with putting off all/most PEP 8
cleanups to their own pure-reformatting commits.

Cheers,
Trevor

-- 
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy