From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id F314D138247 for ; Sat, 14 Dec 2013 16:42:17 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 77177E0AE4; Sat, 14 Dec 2013 16:42:17 +0000 (UTC) Received: from qmta02.westchester.pa.mail.comcast.net (qmta02.westchester.pa.mail.comcast.net [76.96.62.24]) by pigeon.gentoo.org (Postfix) with ESMTP id E0D2BE0AE4 for ; Sat, 14 Dec 2013 16:42:16 +0000 (UTC) Received: from omta16.westchester.pa.mail.comcast.net ([76.96.62.88]) by qmta02.westchester.pa.mail.comcast.net with comcast id 1Szk1n0011uE5Es51UiGgn; Sat, 14 Dec 2013 16:42:16 +0000 Received: from odin.tremily.us ([24.18.63.50]) by omta16.westchester.pa.mail.comcast.net with comcast id 1UiF1n003152l3L3cUiFU6; Sat, 14 Dec 2013 16:42:16 +0000 Received: by odin.tremily.us (Postfix, from userid 1000) id AB887D67F8C; Sat, 14 Dec 2013 08:42:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tremily.us; s=odin; t=1387039334; bh=/dsucbF5Lp1rjdpleLJVUxHRgLv7xhE4b5LM8l3KNEw=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=KBg4nYrkNxmdFkrbJhKB4GFgs4PIbCRumWODMdATyCt8vM//lAT+WC6ozL6Y5Z/YS oREsS04fy+710BGppN8xa0Mwf5z7tspba1Ir9w3dmb8Ris7qw7d+bEYMZ55/Gvbbnz 2zVEUxCmlHb2/RTziS0mDaUuQ0VFPv80miqDGrMU= Date: Sat, 14 Dec 2013 08:42:14 -0800 From: "W. Trevor King" To: gentoo-catalyst@lists.gentoo.org Cc: Brian Dolbec Subject: Re: [gentoo-catalyst] [PATCH 2/4] Remove self.mounts and self.mountmap's use of paths for keys and paths. Message-ID: <20131214164214.GZ25409@odin.tremily.us> References: <1386990436-9198-1-git-send-email-dolsen@gentoo.org> <1386990436-9198-3-git-send-email-dolsen@gentoo.org> <3834721.6I8o79ffCh@moiraine> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="XUd+PsnCfaVdInSg" Content-Disposition: inline In-Reply-To: <3834721.6I8o79ffCh@moiraine> OpenPGP: id=39A2F3FA2AB17E5D8764F388FC29BDCDF15F5BE8; url=http://tremily.us/pubkey.txt User-Agent: Mutt/1.5.22 (2013-10-16) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20121106; t=1387039336; bh=PgVaFjYCqAJXzpzZbBK8q/YSyMPji7VkmWKEfxmms1w=; h=Received:Received:Received:Date:From:To:Subject:Message-ID: MIME-Version:Content-Type; b=PPzBTbRixhB0R+dgDHn0iOScHk4qGDcnPilAantFeDWjU/PwvlRAF8wf5vfE+5Kn1 bRkIxh5CeTx2qyvSp4NHVZccX98AGOOZx8Qmp5FhYogCoa57jABhWZFy3topP3zk+Z 6uTzLU6Vf//jyXTppVjZ7eFJzyFMg+FdZ+u66mncEQNDpp8zuximPTMYqMN7iCyM4J tlocylvK5Ho429P/VfIOH0rbMXGiM12NReKQPfpKBjeiGP/4GonZ2XPPOobp3OIN5v XaSLpYQJ9JkCp9gipHK8Fr0A2Pw7EXwtxdOCT+rXTDune0/UwyfRVZuKEg1gcZCF9r xsQJWSp+4xACg== X-Archives-Salt: 568180f2-7da0-41b1-8e44-3bd2afa70fc1 X-Archives-Hash: 361835dd9ed7ae6d7c63b47515e8012e --XUd+PsnCfaVdInSg Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Dec 14, 2013 at 06:51:45AM -0800, Dylan Baker wrote: > This is work for a seperate patch, but let's kill the self.mounts > and replace it's use with self.mountmap.iterkeys() So fill in mountmap with everything possible, and then pull keys out of it if you don't need them? Currently mountmap is =E2=80=9Cwhere would y= ou like =E2=80=98x=E2=80=99 mounted?=E2=80=9D and mounts is =E2=80=9Cwould you= like =E2=80=98x=E2=80=99 mounted?=E2=80=9D. Those seem separate enough that two attributes isn't crazy ;). > > - destdir=3Dnormpath(self.settings["chroot_path"]+"/usr/portage") > > + destdir=3Dnormpath(self.settings["chroot_path"] + >=20 > add a space after the '=3D' operator >=20 > There's more of this. please look through and add spaces beteen all > of the operators, at least on the lines you've touched. This is > standard python coding style and adhering to it makes all of our > lives easier :) The current code base is so far from PEP 8 that changing touched sections to match PEP 8 looks really out of place. In this instance it's probably fine, but I'd ok with putting off all/most PEP 8 cleanups to their own pure-reformatting commits. Cheers, Trevor --=20 This email may be signed or encrypted with GnuPG (http://www.gnupg.org). For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy --XUd+PsnCfaVdInSg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJSrIplAAoJEKKfehoaNkbtQGkP/1/t7XcOv1aXXPFwfOAVGAC2 TFvTywfOpfb0DzTG2vklgu1JA/Z/fp+MNeu5Ko4VjziWvvMuwmW5caLwGma7rYPS cJjS9xab55d10/1CrEvmsULEtbV5ML55dSf4zoHKS1DM5kcx8dVOZ4g7/jIembMV f5WdFrtK2CYj2vdzHdN4GlSYJMaIM2xF7sPQf/rcN9axGcn7UabqER7cI/1O0Pjw wBYuPmhOzfUCY2VkRlSVMXsIdEhynoycr0m1N2HQwz6GsAfIKWDOYiOmlZ2rxhJO A1PDqJPp8T7pReJLfjzkDHZWbztlBWoWYzNlHGUT8SQrHfXTP4F8IeLDnoyAv3du BpTpyvtmBFQRDKqqKsIpFROjBer1goag2H0TL14UrrrYViGm4qt7w0VbyimUPW8z sR2UxVeaoQTLljy4YP9TiJFKd3ozwMBeoNmjKQtNQ4LOhRLsgxljDwwzJL0Vmb1b Rcig8NgC2pfqoIt4b7NpWVx8IMWHuu5WwwdkXKrSwmMMmzHu8ygWoMlLalU9f8Qm n4ZiluC4PlbLxWz5fqRFNINv9ocBzhv770mCh2Bt753RqzryWUrLKoY5yXu801y2 2LfUNfebLRwXfmDdnfW47qtXXp9ZTK8HyAUj3GVSGA2fAE7npkDqsTgsmEqyc2tB SgRv+7AHt9S6YT1oBkbl =p53y -----END PGP SIGNATURE----- --XUd+PsnCfaVdInSg--