Re: [gentoo-catalyst] [PATCH 3/3] Fix a relative path bug

["W. Trevor King" <wking@tremily.us>]

[-- Attachment #1: Type: text/plain, Size: 995 bytes --]

What's the bug?  More details in the commit message would be good.

On Tue, Dec 17, 2013 at 05:12:11PM -0800, Brian Dolbec wrote:
> -	local destdir=".${subdir}/tmp"
> +	local destdir="${subdir}/tmp"
> …
>  	copy_to_chroot ${1} ${destdir}
> @@ -33,7 +33,7 @@ exec_in_chroot(){
>  	chmod +x ${chroot_path}/${destdir}/${file_name}

If we're requiring ${subdir} (and thus ${destdit}) to be an absolute
chroot path, you may want to fix this too.

>  	echo "Running ${file_name} in chroot ${chroot_path}"
> -	${clst_CHROOT} ${chroot_path} ${destdir}/${file_name} || exit 1
> +	${clst_CHROOT} ${chroot_path} .${destdir}/${file_name} || exit 1

Do we need the leading dot here?  Can we store:

  file_path="${chroot_path}/${destdir}/${file_name}"

and use that for both the chmod and clst_CHROOT calls?

Cheers,
Trevor

-- 
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]