From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 7B333138247 for ; Wed, 18 Dec 2013 03:48:06 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 12149E0B0C; Wed, 18 Dec 2013 03:48:05 +0000 (UTC) Received: from qmta13.westchester.pa.mail.comcast.net (qmta13.westchester.pa.mail.comcast.net [76.96.59.243]) by pigeon.gentoo.org (Postfix) with ESMTP id 7F05FE0B0C for ; Wed, 18 Dec 2013 03:48:04 +0000 (UTC) Received: from omta20.westchester.pa.mail.comcast.net ([76.96.62.71]) by qmta13.westchester.pa.mail.comcast.net with comcast id 2qba1n0061YDfWL5Dro4yd; Wed, 18 Dec 2013 03:48:04 +0000 Received: from odin.tremily.us ([24.18.63.50]) by omta20.westchester.pa.mail.comcast.net with comcast id 2ro21n015152l3L3gro3hU; Wed, 18 Dec 2013 03:48:04 +0000 Received: by odin.tremily.us (Postfix, from userid 1000) id 89C45D8BC4D; Tue, 17 Dec 2013 19:48:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tremily.us; s=odin; t=1387338482; bh=g5UoWHv0171Qbp8YwacAq+4+OmRUCnSm9ZVMgE9nBVE=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=NK60D0fXIXJYk0NjPRuMA9iss3tCV13xxK/PpH+dUFJI+liAWHW09S2I+6SQHbSGS AZ5CSHeYQL9ls3snxOJ0M/LRAaTT0x/C+Xw273K7UVeJ79/k9RmA/R4KG34WSBn31S eb9LlPT0mwzQAHFfvmVRXozJLVVJkIp7OKjV9Kco= Date: Tue, 17 Dec 2013 19:48:02 -0800 From: "W. Trevor King" To: gentoo-catalyst@lists.gentoo.org Cc: Brian Dolbec Subject: Re: [gentoo-catalyst] [PATCH 3/3] Fix a relative path bug Message-ID: <20131218034802.GH25409@odin.tremily.us> References: <1387329131-25890-1-git-send-email-dolsen@gentoo.org> <1387329131-25890-4-git-send-email-dolsen@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="vtXhP2uWJgN5CSw0" Content-Disposition: inline In-Reply-To: <1387329131-25890-4-git-send-email-dolsen@gentoo.org> OpenPGP: id=39A2F3FA2AB17E5D8764F388FC29BDCDF15F5BE8; url=http://tremily.us/pubkey.txt User-Agent: Mutt/1.5.22 (2013-10-16) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20121106; t=1387338484; bh=X+sPYwaJtscH5YG+cVA7uh9KfFwukUELromzmjz6bZo=; h=Received:Received:Received:Date:From:To:Subject:Message-ID: MIME-Version:Content-Type; b=O3B+9TbzqoJLJ6+Q9nKnRtUt2Pgthfy4fb8ydVYnNyd3xPSP1RIklL2kEM+lOQsLm wTjcqgUYrpy8WdVttE07y7ulYRz1zifBxJ6X89/I0qgSekgKRbjpP9ly7vgA4je3rF A/5SZblzNVLD2kDOCD6qfW/MwX+iB8qS9YrUOL/gFfq3/jZOD6un1C2duvidjpAEaS flxaIyy8bMANjUBD2GdEn9JBh8tPmI+sq/wvNtvkDc1/bHFvrJnScylq5PbYkwfE+T Lz5X948BLOlrLCG6igc2KXhUodip8Mio4zDhkkkZjwLHMP+y4Aw1f1QERs9TTfVSLZ wvd7cYgWjzNLA== X-Archives-Salt: 61c5eeed-abbd-40e1-81c9-216c7e7a4efb X-Archives-Hash: cc9fbc1e9acecefed43de4df2dafd2ae --vtXhP2uWJgN5CSw0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable What's the bug? More details in the commit message would be good. On Tue, Dec 17, 2013 at 05:12:11PM -0800, Brian Dolbec wrote: > - local destdir=3D".${subdir}/tmp" > + local destdir=3D"${subdir}/tmp" > =E2=80=A6 > copy_to_chroot ${1} ${destdir} > @@ -33,7 +33,7 @@ exec_in_chroot(){ > chmod +x ${chroot_path}/${destdir}/${file_name} If we're requiring ${subdir} (and thus ${destdit}) to be an absolute chroot path, you may want to fix this too. > echo "Running ${file_name} in chroot ${chroot_path}" > - ${clst_CHROOT} ${chroot_path} ${destdir}/${file_name} || exit 1 > + ${clst_CHROOT} ${chroot_path} .${destdir}/${file_name} || exit 1 Do we need the leading dot here? Can we store: file_path=3D"${chroot_path}/${destdir}/${file_name}" and use that for both the chmod and clst_CHROOT calls? Cheers, Trevor --=20 This email may be signed or encrypted with GnuPG (http://www.gnupg.org). For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy --vtXhP2uWJgN5CSw0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJSsRrxAAoJEKKfehoaNkbtGicP+wRXMOP/CCivc5TOdpknxDSD l7XEPU84vIVVG7iUAZad9Yb7eHf4us5ni01nWZa4hDRAdDplSsLi4iT0bFcbuRyY BuqqGI16tJET6wjjojFJbLXmH3v4mBwVOKJ771R6eGSJcc6Zrot13xedqTLBfx5s w0HU5tUM9Z4wH5fyU4DuQFAknD5O4FC1k94WnwI8i7QNik7jTOSvTc64FhFk5Xn4 RZtOFkb8+gVwGULOdgQLT2LPHbzl10iHfRbKyU2nlwBDrjKjvVarYjA1ww8RwsZS vzw8NWPzAdU9/yE0V53rQyCySnQrfYz5tCB7YN6W9rNzpCkFko6bUi3036EhKBzm Ch1WpKorKbMN4LVpZ9co+wF0mINq5OcVVAwEH1EP9usD+9hzQzJTLPYOdxobJyMo y2bQxLlK8si0LbIRypIKS2bZ3OYwv+14d581fOmOX9m1p4oSmLrG0BGwp6Yz/njw BmV3h+kwCxgssBstBW3C/VDRL6SWDfso88CyCtiAlEiMElU9JYQTiA62Me4VzRg4 tCnAJgbpMcdqsl+UGw03ThtoPmTJV2Dpt+thYMHFzPFtQrbiBrJ79Mrkak5h//l8 YAd9WxuY+VVK27Q7wSlscj0BmmacbwBFEbuhQD5Bv9RKWF0ywKmSe/cSPeF7fkUN 7lVx4QUT7O3h5OYcKZk3 =lMPf -----END PGP SIGNATURE----- --vtXhP2uWJgN5CSw0--