Re: [gentoo-catalyst] [PATCH] The string module is deprecated, stop using it.

["W. Trevor King" <wking@tremily.us>]

[-- Attachment #1: Type: text/plain, Size: 1206 bytes --]

On Wed, Dec 18, 2013 at 09:18:06PM -0800, antarus@gentoo.org wrote:
> @@ -116,12 +115,13 @@ def parse_config(myconfig):
>  			print "Setting",x,"to default value \""+confdefaults[x]+"\""
>  			conf_values[x]=confdefaults[x]
>  
> +	options = conf_values["options"].split()
>  	# parse out the rest of the options from the config file
> -	if "autoresume" in string.split(conf_values["options"]):
> +	if "autoresume" in options:
>  		print "Autoresuming support enabled."
>  		conf_values["AUTORESUME"]="1"
>  
> -	if "bindist" in string.split(conf_values["options"]):
> +	if "bindist" in options:
>  		print "Binary redistribution enabled"
>  		conf_values["BINDIST"]="1"
>  	else:

These changes look fine to me, but I'd rather just convert to the
stdlib's ConfigParser.  That's going to blow away this whole function,
so I don't see the point in fixing it up now.  Of course, if the
powers that be think a ConfigParser conversion is in the far-distant
future, then I'm ok with this as a temporary cleanup.

Cheers,
Trevor

-- 
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]