From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id CC4B3138247 for ; Thu, 19 Dec 2013 06:39:28 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 53D83E09EA; Thu, 19 Dec 2013 06:39:28 +0000 (UTC) Received: from qmta06.westchester.pa.mail.comcast.net (qmta06.westchester.pa.mail.comcast.net [76.96.62.56]) by pigeon.gentoo.org (Postfix) with ESMTP id BEF3AE09EA for ; Thu, 19 Dec 2013 06:39:27 +0000 (UTC) Received: from omta19.westchester.pa.mail.comcast.net ([76.96.62.98]) by qmta06.westchester.pa.mail.comcast.net with comcast id 3Je01n00227AodY56JfTka; Thu, 19 Dec 2013 06:39:27 +0000 Received: from odin.tremily.us ([24.18.63.50]) by omta19.westchester.pa.mail.comcast.net with comcast id 3JfR1n00J152l3L3fJfSs7; Thu, 19 Dec 2013 06:39:27 +0000 Received: by odin.tremily.us (Postfix, from userid 1000) id BEB10D9503E; Wed, 18 Dec 2013 22:39:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tremily.us; s=odin; t=1387435164; bh=y0YG5yF5T1lCV1r68a1VwXmKr7rg9KiIESxCJqQNjhU=; h=Date:From:To:Subject:References:In-Reply-To; b=PKkk47gsYWWAUcciOhm+s1jH8SM322+Bx/XedjyIby+6uVEHt82fjYeKgeHtRDI0q lZ/Taai70Es9VKxGydKOjEC+MG9Vu68iktt55bcYVuSafhFD33a6puIXms+JYdnOO3 ci03ljYCAff8aHF1nGUetW+IM8TZl6kEZOawD6Jw= Date: Wed, 18 Dec 2013 22:39:24 -0800 From: "W. Trevor King" To: gentoo-catalyst@lists.gentoo.org Subject: Re: [gentoo-catalyst] [PATCH] The string module is deprecated, stop using it. Message-ID: <20131219063924.GR25409@odin.tremily.us> References: <1387430286-30467-1-git-send-email-antarus@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="vHHkwDyz6KT2TQtt" Content-Disposition: inline In-Reply-To: <1387430286-30467-1-git-send-email-antarus@gentoo.org> OpenPGP: id=39A2F3FA2AB17E5D8764F388FC29BDCDF15F5BE8; url=http://tremily.us/pubkey.txt User-Agent: Mutt/1.5.22 (2013-10-16) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20121106; t=1387435167; bh=oqCr/55EMjBt4QsWWtxivWLXuiCtnBgLuAyQHTRZuv4=; h=Received:Received:Received:Date:From:To:Subject:Message-ID: MIME-Version:Content-Type; b=nqVwL3330v5VyjYArCzawl/u2rm5JvFmH8EWVtX2FLoXTFRvJoHmcN+1JO0bHedSE yYf/u4tHOjuH5LfIF30UGfq6i0GJt0tRTrefYsf0guWIPa5fCebTaAXRyZYmY4vXxF 8DG1rhgcA5EU+Pv/EO5Gmbsl6GvJ3DtoQrneZ2IfKoy9URTflldGVCElh/v07LY11X MLhFHPbgD7XypATRvtTKZF7jbLJKSL2l9G9k1ZM5OSmrFAJo1F/lPwV0pM/e64a6XA Gw4Qhuwc6/9iOj8LCDdHppwcrKJVg4VNfTYhVSsrhG/uxD1GcG7idD6O6mVOTlc316 Tc9Z+Uvy9PNrw== X-Archives-Salt: b39f0279-c95a-4d0c-8c0d-7af482a108fd X-Archives-Hash: 78c507e5b6c405f32e62893f1521da61 --vHHkwDyz6KT2TQtt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 18, 2013 at 09:18:06PM -0800, antarus@gentoo.org wrote: > @@ -116,12 +115,13 @@ def parse_config(myconfig): > print "Setting",x,"to default value \""+confdefaults[x]+"\"" > conf_values[x]=3Dconfdefaults[x] > =20 > + options =3D conf_values["options"].split() > # parse out the rest of the options from the config file > - if "autoresume" in string.split(conf_values["options"]): > + if "autoresume" in options: > print "Autoresuming support enabled." > conf_values["AUTORESUME"]=3D"1" > =20 > - if "bindist" in string.split(conf_values["options"]): > + if "bindist" in options: > print "Binary redistribution enabled" > conf_values["BINDIST"]=3D"1" > else: These changes look fine to me, but I'd rather just convert to the stdlib's ConfigParser. That's going to blow away this whole function, so I don't see the point in fixing it up now. Of course, if the powers that be think a ConfigParser conversion is in the far-distant future, then I'm ok with this as a temporary cleanup. Cheers, Trevor --=20 This email may be signed or encrypted with GnuPG (http://www.gnupg.org). For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy --vHHkwDyz6KT2TQtt Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJSspSaAAoJEKKfehoaNkbtZq8P/i5DePBMJ3/R8Df46fl0cwD8 itRkIbwN3nSW1y354Rc1TcNze9HuyeCHlWrc0j/l4JtLDATnXRU4YYhN/mgQ9OT/ YZWh2VBD0qxjLGG2103lOjgCbDZmWNFRUF3pmIFoR+l7gHxRtqcTH/QrF/pg1rEr AXOQTNSE53zGt6Uhi63YytdKCdLBYf2QGL1BMxFGg+NaUgMox/PNOddHiu/oeq+f e7pCKuv7ffJtoJ06gjljN3//EzV1Nmp21WpoQr9vvQSOvlnAhy7KCcLlnzmY7Xp/ d8ZRZlaMmIfXyR+mCTGYlIYkoHcojoQcu507gHrb7zXvvzClD3L5TNVjOOTNxTxr 92aal4ljIK/mSIUOPXprgwV2assPf01S2oOo3Of7uQC/ovMop3gVaCda6xgHEEFC U8olxguI4AL2ucUKutHUJJGY2hB7IKB10f/3oCiVC+VjtRC06jJCEkRm8THSg86N r0r35aMaX7usV/3KbAXyyv8BfTcFhWrY4az4PbLmb2AqFLyZAjWSh69lL/1OCVnm vNxCOaWqBYJEmDbFzEcFgU17ryfpiQdq//Jp3ofPdQRnlL3sqEUIxjNf62AFxFLj B4+XIgoCplZ5niKpxvZVYNYbrbDCoBNMj7nXl+xJIhc6Enm0TEyPjlKEJoze8AHd uVsEZjIGFC50jK8P/MPj =JApm -----END PGP SIGNATURE----- --vHHkwDyz6KT2TQtt--