From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 72DE3138247 for ; Sun, 29 Dec 2013 02:16:15 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 46C8CE0AF6; Sun, 29 Dec 2013 02:16:13 +0000 (UTC) Received: from qmta15.westchester.pa.mail.comcast.net (qmta15.westchester.pa.mail.comcast.net [76.96.59.228]) by pigeon.gentoo.org (Postfix) with ESMTP id B7245E0AF6 for ; Sun, 29 Dec 2013 02:16:12 +0000 (UTC) Received: from omta04.westchester.pa.mail.comcast.net ([76.96.62.35]) by qmta15.westchester.pa.mail.comcast.net with comcast id 7ECc1n0010ldTLk5FEGClF; Sun, 29 Dec 2013 02:16:12 +0000 Received: from odin.tremily.us ([24.18.63.50]) by omta04.westchester.pa.mail.comcast.net with comcast id 7EGA1n00c152l3L01EGB9l; Sun, 29 Dec 2013 02:16:12 +0000 Received: by odin.tremily.us (Postfix, from userid 1000) id A56AFE253F4; Sat, 28 Dec 2013 18:16:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tremily.us; s=odin; t=1388283369; bh=sYZY7L1JoDNS7ZGIxySBfr8oTY7rwjIYo/gxFQPEXDQ=; h=Date:From:To:Subject:References:In-Reply-To; b=Kkhu80CD2tShIVtIbBX0v/SAHUax96bWF8MQwwjxJUSz0jFu5INyjkxGO7SGRCKwm PqRfl71qZNOZr09SVBJWDr8ifgMrgrRyEVQ4SO5hjIZC15m8Cph9CT+pZzeWo/oweX oyF5gnCwRiEDNvjxCepFA3qquoQinfl7zEPbGF2o= Date: Sat, 28 Dec 2013 18:16:09 -0800 From: "W. Trevor King" To: gentoo-catalyst@lists.gentoo.org Subject: Re: [gentoo-catalyst] [PATCH 1/6] modules/generic_stage_target.py: USE portdir, distdir,... instead of paths for keys Message-ID: <20131229021609.GD29195@odin.tremily.us> References: <1388282230-3563-1-git-send-email-dolsen@gentoo.org> <1388282230-3563-2-git-send-email-dolsen@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="C1iGAkRnbeBonpVg" Content-Disposition: inline In-Reply-To: <1388282230-3563-2-git-send-email-dolsen@gentoo.org> OpenPGP: id=39A2F3FA2AB17E5D8764F388FC29BDCDF15F5BE8; url=http://tremily.us/pubkey.txt User-Agent: Mutt/1.5.22 (2013-10-16) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20121106; t=1388283372; bh=lyf3IfLNn7n80yaW7OKXYC8H7IvADffmdvlX4F3UKqE=; h=Received:Received:Received:Date:From:To:Subject:Message-ID: MIME-Version:Content-Type; b=cgMe8EZMCHQJ9MpA29NcWrErjvpIwLp1t55UiHdP0bvEUyqwFoISxvo8AtKjTtSAb F+KC2CJohNeORGYRBkGP/xOGK3LrA5Wwvuu0smO7BYo0HHfx36itUckKFZY2oHukfz ZIXsHCacj4FOQG6+HxGXUTuDlogwnXrKpSc/TJU/2ObBsngLQcSfb4NlqQo5M1JDN+ poRvrOBwElNHfyUzDwBeHD6XHu6bfnK2sysm6dDqgz3E20DN8U8GUwraOaEotjfo9x oJuCxfbfMBGyMnq/m1W/YXV+x9bChgBS1w45I8xGqcHWcsDGDz3hRiZbConuuDh3Fw Q6gqpYa2wpUng== X-Archives-Salt: 0feb289e-02b2-4972-a6ce-1b161d6e16b7 X-Archives-Hash: 6a9b4f1cd7cbc4432b789564e87c8b36 --C1iGAkRnbeBonpVg Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Dec 28, 2013 at 05:57:05PM -0800, Brian Dolbec wrote: > Subject: Re: [gentoo-catalyst] [PATCH 1/6] modules/generic_stage_target.p= y: > USE portdir, distdir,... instead of paths for keys I'd prefer =E2=80=9C: Use=E2=80=9D instead of =E2=80=9C: USE=E2=80=9D. > - self.mounts=3D["/proc","/dev","/usr/portage","/usr/portage/distfiles"= ,"/var/tmp/portage"] > - self.mountmap=3D{"/proc":"/proc","/dev":"/dev","devpts":"/dev/pts", > - "/usr/portage":self.settings["snapshot_cache_path"]+"/portage",\ > - "/usr/portage/distfiles":self.settings["distdir"],"/var/tmp/portage"= :"tmpfs"} > + self.mounts=3D["proc", "dev", "portdir", "distdir", "port_tmpdir"] > + self.mountmap=3D{"proc":"/proc", "dev":"/dev", "devpts":"/dev/pts", > + "portdir":self.settings["snapshot_cache_path"]+"/portage",\ > + "distdir":self.settings["distdir"],"port_tmpdir":"tmpfs"} No need for the backslash after =E2=80=9C"/portage",=E2=80=9D. There shoul= d also probably be a space before =E2=80=9C"port_tmpdir"=E2=80=9D. Style issues a= sside, the content looks good to me. Cheers, Trevor --=20 This email may be signed or encrypted with GnuPG (http://www.gnupg.org). For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy --C1iGAkRnbeBonpVg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJSv4XmAAoJEKKfehoaNkbtiR0QAKLeAMCx/Moc685+76Hm4Hau skXFdjoCTAqGwSzfNh9vhRr9HiRyt5asgUb9J/ENt+23B0Hb/uo3Xpc3TNBjPWse 0h2GX8I6anJIPqs5hsnuTz5gQOiNP6GiJhk061Th9zzNDC2PtLVpHM8Ihfw+oYDP d6y5AQnaZgy7D6UiNnHO61G0K+MgmYno0AqtFzrUN12611HtqNNjcOXicuOiubZI gEplE4K5fr4dqchcs8jQz4f9rGskld903SwnHKCLEN7MarUn5tJubMx+Gk2T2CnX hYz1WYRqZYX3GHz8HpyYIMZF42Cbe60VoavYFXYRuYKmozRrt73nFyfyg42FdxJn cORzWkYD+FGWcSapzbu/v6uRvNtHPWQS0Plqbr371qdqYvbt7AuVu3ahYh2+yxYx ZSx9Onqzchi4NdhUla8n37qzpUF7FhuZ5bbxYARcobokE5JA/yQmIRbEorvGiqAd S9tSoAmSfwEMkeqZs3R7P2M5G0eVNfrBPOSlJhnY44MOhVlQpbLd2Fy76bNaEs1j RaRiJKUVJA/YGrd1AwL+M3XPHtmp9qO9fwUw6mhGlQjf1xrcrD2ej0VnpLOx4uOn tZxCbeWLGc3Mb9JxLcgtP8WDMooHMWjUuL0rjMRAWRRzwUZVrUcELlw6OaX6aAHi T25lCVyZVNw1mN3mH2Jr =hFlo -----END PGP SIGNATURE----- --C1iGAkRnbeBonpVg--