From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 2ABA8138247 for ; Sun, 29 Dec 2013 02:19:30 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id AFF1FE0AF6; Sun, 29 Dec 2013 02:19:29 +0000 (UTC) Received: from QMTA11.westchester.pa.mail.comcast.net (qmta11.westchester.pa.mail.comcast.net [76.96.59.211]) by pigeon.gentoo.org (Postfix) with ESMTP id 35B97E0AF6 for ; Sun, 29 Dec 2013 02:19:29 +0000 (UTC) Received: from omta20.westchester.pa.mail.comcast.net ([76.96.62.71]) by QMTA11.westchester.pa.mail.comcast.net with comcast id 7Drp1n0041YDfWL5BEKU18; Sun, 29 Dec 2013 02:19:28 +0000 Received: from odin.tremily.us ([24.18.63.50]) by omta20.westchester.pa.mail.comcast.net with comcast id 7EKT1n00D152l3L3gEKUL3; Sun, 29 Dec 2013 02:19:28 +0000 Received: by odin.tremily.us (Postfix, from userid 1000) id 16CAEE2545D; Sat, 28 Dec 2013 18:19:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tremily.us; s=odin; t=1388283567; bh=HFD+tFroGSe+xiL4ra618U2aJggNqaoitGTYk3ZLcig=; h=Date:From:To:Subject:References:In-Reply-To; b=SKh1Ku6Su6WoDNfvXMupz7wn6kbYqPQn/stAGnyXJRSrK35cYGWUjn7IsvbjL+z2a GNnMyrhiZYfyiOCJJ0wCfgSz9np7cbVGnjxY7WHsiDs6aqv5r7tZC90g9ChKSeqGtc ABhWJGiULGws2sGTcULNdqC4yBgqO0ndY43EzllU= Date: Sat, 28 Dec 2013 18:19:26 -0800 From: "W. Trevor King" To: gentoo-catalyst@lists.gentoo.org Subject: Re: [gentoo-catalyst] [PATCH 2/6] Fix a missed self.settings["repo_name"] migration Message-ID: <20131229021926.GE29195@odin.tremily.us> References: <1388282230-3563-1-git-send-email-dolsen@gentoo.org> <1388282230-3563-3-git-send-email-dolsen@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Rgf3q3z9SdmXC6oT" Content-Disposition: inline In-Reply-To: <1388282230-3563-3-git-send-email-dolsen@gentoo.org> OpenPGP: id=39A2F3FA2AB17E5D8764F388FC29BDCDF15F5BE8; url=http://tremily.us/pubkey.txt User-Agent: Mutt/1.5.22 (2013-10-16) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20121106; t=1388283568; bh=KKEEIPdBIWKZ7CPx1OtGeAx3oVGb6VfSTj+TsYddiz0=; h=Received:Received:Received:Date:From:To:Subject:Message-ID: MIME-Version:Content-Type; b=J338EQpCvg7T58rfnyPrxtBl89qqEyhGCs85Ud4GdXE1fzJKlT6S9EOb4LxU4Zqe/ VEycXAXJ7evp6HhusYwy5d0KWX3hThuuVdkawQlnw1gQk8iwF8w7BGLxcopyT0gHSn n8qDsb9jNLzwbpgUyKI1XPUlH1cwal/Keb21jitnMaHmP+PjnLn+SAXG68EEBKPiMV /GHHQEVXkKHah070r6BLKuVjQjiGMv0Qn4NOERbExFfioIHKHh7CVc7Fjip+PL7Xjf pwk9jVr8T8+IuMIfBNhpv9PFbg/mlMuTmQhB9G0IiTsO/o5Bvb2fU3jK6AD9LwKMUW f4727Qme+9X2g== X-Archives-Salt: 533f53ad-4ede-42b1-ae1f-658474a7e40e X-Archives-Hash: 206d5bcd7aa856e0dc236172aa58b726 --Rgf3q3z9SdmXC6oT Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Dec 28, 2013 at 05:57:06PM -0800, Brian Dolbec wrote: > - "portdir":self.settings["snapshot_cache_path"]+"/portage",\ > + "portdir": normpath(self.settings["snapshot_cache_path"] + "/" + > + self.settings["repo_name"]), > "distdir":self.settings["distdir"],"port_tmpdir":"tmpfs"} Ah, this is getting rid of that trailing backslash, so I'm fine if it stays in the previous commit. We're still missing the space before =E2=80=9C"port_tmpdir"=E2=80=9D. The use of normpath and the repo_name set= ting look good. Cheers, Trevor --=20 This email may be signed or encrypted with GnuPG (http://www.gnupg.org). For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy --Rgf3q3z9SdmXC6oT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJSv4auAAoJEKKfehoaNkbtKgwP/0yKK28ihzLiBNLKUsoHKTyx k43FZW3nmzLy4uxAVfRCumJXaZ1KJyMscp8iGJ4Zzr0Ao7KkUdWfpImuAlG4RxHd 99hgX7aCwjZEqGehzzrgmaH57uHB7xuiczGtmXAUS5W9XE8Rtp0cqBbNn4ZQKiRp 6kdLMiD2WIvkPOfjaZULtSbvx10m2mH7jNoO1EqCKnVysrE880DvoXUyIDKwXwOi KpFXpxQJGfelWY6M4/XsgaS2A0iBQzI97Nt42u+6qzK8RTqLdCqUNoUGlSKLcxaK Q+i8Ao329oidk6hk67DE1rP2aNRjUwDGYZo/e7Zpr6X/7BMCmn/qZxmQxW8MObwb TmZxYPS9FqTk9jpgtsH8Nk74WekksSaWWXPLVSL1IuZ4wNAMwo35dK8i5c4er7pN KglggEUcgKaWsMaVgw7tqusY2hMMpihulA0lG+JP3qtvg7EYp6mlbPkXd2t766aA kQXVfl/c5tvZZvR2NzKHpSMezoy1R1kRxad7T0Vg0iQfjo/EpqPanIcyCeRaVEVR ztghxf0sbBIRLgxUF/o1sl9NUJwsrlp2DVkqC6EoYXskKqO+YcJJ4J8BNs6rZsBC aGeYCfad4azyv+wlKdIAdxj9BY7kBuU5YD5qijEH87A9/MWZY3WSnGAJDhbp+l8G W0NHjT0W3vmfrw9kms9H =NqHr -----END PGP SIGNATURE----- --Rgf3q3z9SdmXC6oT--