From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id C2434138247 for ; Sun, 29 Dec 2013 02:30:19 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 4CD44E0AFE; Sun, 29 Dec 2013 02:30:18 +0000 (UTC) Received: from qmta13.westchester.pa.mail.comcast.net (qmta13.westchester.pa.mail.comcast.net [76.96.59.243]) by pigeon.gentoo.org (Postfix) with ESMTP id C6074E0AFE for ; Sun, 29 Dec 2013 02:30:17 +0000 (UTC) Received: from omta09.westchester.pa.mail.comcast.net ([76.96.62.20]) by qmta13.westchester.pa.mail.comcast.net with comcast id 7EPz1n0040SCNGk5DEWHDn; Sun, 29 Dec 2013 02:30:17 +0000 Received: from odin.tremily.us ([24.18.63.50]) by omta09.westchester.pa.mail.comcast.net with comcast id 7EWG1n005152l3L3VEWGcv; Sun, 29 Dec 2013 02:30:17 +0000 Received: by odin.tremily.us (Postfix, from userid 1000) id D533CE2558D; Sat, 28 Dec 2013 18:30:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tremily.us; s=odin; t=1388284215; bh=r4FCvNaa6xo/HjX6grwaDzJPrV6v4eW/j2N25SGG/tI=; h=Date:From:To:Subject:References:In-Reply-To; b=Yz7tmtfcTlJQdBGhke59Scj3Qhvwjzb6/pvHXZWWCcdFBDBUKrCgzow6DMszq/SYz 26TCmzrwhKahtP/J2JbMMENxwXDSYVBzZOOmmwyNb+Gx+YVRPkMwCPcaqGWSEMUQde NkpskbsAbMEOEbnvmm1RP0vh/nVzpz8LlO/0rqd0= Date: Sat, 28 Dec 2013 18:30:15 -0800 From: "W. Trevor King" To: gentoo-catalyst@lists.gentoo.org Subject: Re: [gentoo-catalyst] [PATCH 4/6] Fix a missed self.mounts key change from a path as key. Message-ID: <20131229023015.GG29195@odin.tremily.us> References: <1388282230-3563-1-git-send-email-dolsen@gentoo.org> <1388282230-3563-5-git-send-email-dolsen@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="VACxsDaSTfeluoxK" Content-Disposition: inline In-Reply-To: <1388282230-3563-5-git-send-email-dolsen@gentoo.org> OpenPGP: id=39A2F3FA2AB17E5D8764F388FC29BDCDF15F5BE8; url=http://tremily.us/pubkey.txt User-Agent: Mutt/1.5.22 (2013-10-16) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20121106; t=1388284217; bh=TYOr2Xy6IxBrcLuCuMf57m2+J3ue4Pn7WQ0TnGzsDNc=; h=Received:Received:Received:Date:From:To:Subject:Message-ID: MIME-Version:Content-Type; b=pPLowonl8TNuZROMHOmjxGGZ9jGCszv9VZqSmcyoebfq7mNuac6vuho/9Zj0HhBFo C6r3qxvSphiQ807imXAWba7SEH8vP0l24W7qw2Ksk32rHtVOgSPIVlyu4/D2zV2BHB HMjPVvkqRedD7br3dkcRGyLtXd6r6A9m7XQR6ZvaEE8euEVHtdhMwgTpVQLZ0+BZ+O wfMiTmUGTSM4iZYZPYYTmtYz5hqzh0AaAuH5u6ZZOuvY4kyxZp3dQz3sGlW9Sxvlwk yg45g8MkSPS76VfD4DXj4i1RnxqpXfsvL9pxctJt2Ef9zIfcXOKUADjBtfGnTB/w+b +qcPkC4gPobkA== X-Archives-Salt: 10cfbab6-1272-4508-b438-823d91c115dd X-Archives-Hash: 84d56363fe958a07505d5059c410afa0 --VACxsDaSTfeluoxK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Dec 28, 2013 at 05:57:08PM -0800, Brian Dolbec wrote: > original patch: 27b751ffd9594e0128a3d70f83c7af18dab03838 Actually, I don't think this is related to 27b751f (modules/generic_stage_target.py: Use 'portdir' instead of hard-coding '/usr/portage', 2012-12-19), which was only about self.settings["portdir"]. > --- > src=3Dself.mountmap[x] > - if "SNAPCACHE" in self.settings and x =3D=3D "/usr/portage": > + #print "bind(); src =3D", src > + if "SNAPCACHE" in self.settings and x =3D=3D "portdir": > self.snapshot_lock_object.read_lock() Maybe squash this into patch #1 (modules/generic_stage_target.py: USE portdir, distdir,... instead of paths for keys, 2013-12-15), because it's fixing the currently-broken SNAPCACHE mountmap keys. Cheers, Trevor --=20 This email may be signed or encrypted with GnuPG (http://www.gnupg.org). For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy --VACxsDaSTfeluoxK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJSv4k2AAoJEKKfehoaNkbtxEAP/0WyYvFBAZKFNgQ8ZT/pbEY+ VAODxyye0B+nejCfpQKHe+SviTSTgVuUJU5R7tNWVz7fpEjVcKPmfYrZhmq0elzD UzczUMY8lOMhKwhcs7IZhoP5/CasOFWZr/Q7Vb1u2cqujZfNJ4YKRZ7b8Rt+Qa5w nTdyarKIzuqtpfwIq7pQ48+LbfyZwgE20forMuwTbv0fXvJgfJiIDFAIfTtqB1RQ I5Vn8yDcSwkIhXSWTRSG+ZM9eFxdVzxg2bUQsrgaD+fbVOCWRjv1+VTNr2iTPg5G gWZtuiZPz8dYee99VkHDKTHCNxOtrI8tV4s6KiQNWoci0Ohkng22K8TUD5VBZZ82 nwcYyuxxiexti7ecRquxkOVH+BQ/fd0qHrotoiEhPtaYn57Wx1OxbW7kCLPmtNH5 kr4xtaGSEf83ZfJC2eG6watr8u17WJfckwaz2OorfeBHmsD4f2f002ZOKnd1TwJq HCdpIx1LFg6uv+UGNwZmJ59PrnOW7qSQKfAA5y0TiEqtggqbaWfYWzxp3QDCMnL3 fQXILQ+Epd8C/91oxUje89FHsYM9pDNCkhW7OLr1o199o9RSdJa1YqjDr0vjy5cv H1t/+EOvHvzpHfUEVJKsNPSoKQ0LUQ0gIlJP5osv8sJQ4WjS1oMypvnAn/HIf+cD 18meAJlAqraaYZvuQLIv =DZlJ -----END PGP SIGNATURE----- --VACxsDaSTfeluoxK--