From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 45429138247 for ; Sun, 29 Dec 2013 02:49:16 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 476F3E098A; Sun, 29 Dec 2013 02:49:14 +0000 (UTC) Received: from qmta12.westchester.pa.mail.comcast.net (qmta12.westchester.pa.mail.comcast.net [76.96.59.227]) by pigeon.gentoo.org (Postfix) with ESMTP id CD62FE098A for ; Sun, 29 Dec 2013 02:49:13 +0000 (UTC) Received: from omta02.westchester.pa.mail.comcast.net ([76.96.62.19]) by qmta12.westchester.pa.mail.comcast.net with comcast id 7EhZ1n0030QuhwU5CEpDHd; Sun, 29 Dec 2013 02:49:13 +0000 Received: from odin.tremily.us ([24.18.63.50]) by omta02.westchester.pa.mail.comcast.net with comcast id 7EpC1n005152l3L3NEpCYg; Sun, 29 Dec 2013 02:49:13 +0000 Received: by odin.tremily.us (Postfix, from userid 1000) id C5C66E25749; Sat, 28 Dec 2013 18:49:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tremily.us; s=odin; t=1388285351; bh=R2W6jP922Y+ervLZHG8++wvS9eJZGNApe4UQQHZ9/kQ=; h=Date:From:To:Subject:References:In-Reply-To; b=cz4gyZKYzYC7i6m1Bx6PBas56CN+knQfnGe/AQXlmmDOtTWr0y1EMaDbSncSntL3A jTTBejhBgTr4TIeQ2mCkdTt4DjbFRCdzucmGW4FDyvp+jKE+emOhLyoO7U0lrCtxGs JABSvvR+9zXIOnL55+u80etZanllSONuPDBt5s0M= Date: Sat, 28 Dec 2013 18:49:11 -0800 From: "W. Trevor King" To: gentoo-catalyst@lists.gentoo.org Subject: Re: [gentoo-catalyst] [PATCH 5/6] modules/generic_stage_target.py, modules/stage1_target.py: Add a target_mounts dictionary Message-ID: <20131229024911.GH29195@odin.tremily.us> References: <1388282230-3563-1-git-send-email-dolsen@gentoo.org> <1388282230-3563-6-git-send-email-dolsen@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="3ecMC0kzqsE2ddMN" Content-Disposition: inline In-Reply-To: <1388282230-3563-6-git-send-email-dolsen@gentoo.org> OpenPGP: id=39A2F3FA2AB17E5D8764F388FC29BDCDF15F5BE8; url=http://tremily.us/pubkey.txt User-Agent: Mutt/1.5.22 (2013-10-16) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20121106; t=1388285353; bh=Uq3xoTm16eMRFlo8FXMzSM2GqmRkQibk7cWKbJsKuoM=; h=Received:Received:Received:Date:From:To:Subject:Message-ID: MIME-Version:Content-Type; b=NKmR+jr1iiyYPiUaOyNQgOvvllQc31ftCvg82Pj8HB3P7y9CbdyH83axXBFYA84hH vS1R6FFUfKzEB9TqGnf0b+lQDue30q3s95FpMwWD9TkcDjKA+BhzzxDsmem4Svt19v qgUXvhC5keT5iIAnhlu2ngq0iI9N0bAtltFjpWyzDDs+KQu2myT2Wy/TWqcq374N9i 9RQUeIYZ1bRLibdz4s0OYg3HVmeFZ/R72UOPWqL+0cRhvy9e3YDbG4gfN+boUDycOG T3E+WlbdseIQS93QTjAsb5jnoTAtjeIzWJ/9up+JsBo8RyuyPOj3ezLKu17tZz76L3 ZIbcsqlvCUMSg== X-Archives-Salt: 51eb6c78-735f-42ce-9ff8-5529577e2d2c X-Archives-Hash: eaceb6e20afc9e257e61c5cebeff4d7c --3ecMC0kzqsE2ddMN Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Dec 28, 2013 at 05:57:09PM -0800, Brian Dolbec wrote: > +# temporary location. It will be moved to a > +# new defaults file in a later comit Hopefully those later commits will land, but maybe they won't. I'd rather comment on future goals in the Git commit instead of in the source code. > + # initialize our target mounts. > + # later I plan to make these configurable so the > + # defaults can be easily overridden if desired. > + self.target_mounts =3D TARGET_MOUNTS_DEFAULTS.copy() See above about future goals in the Git commit. > - self.mounts.append("/var/log/portage") > - self.mountmap["/var/log/portage"]=3Dself.settings["port_logdir"] > - self.env["PORT_LOGDIR"]=3D"/var/log/portage" > + self.mounts.append("port_logdir") > + self.mountmap["port_logdir"]=3Dself.settings["port_logdir"] > + self.env["PORT_LOGDIR"]=3Dself.target_mounts["port_logdir"] Looks good. The mounts/mountmap changes are orthogonal to the target_mounts addition, but it's probably not worth splitting them out into a separate fixup. > def mount_safety_check(self): > =E2=80=A6 > def bind(self): > =E2=80=A6 > @@ -935,26 +962,25 @@ class generic_stage_target(generic_target): > myrevmounts.reverse() > """ Unmount in reverse order for nested bind-mounts """ > =E2=80=A6 Hooray, sanity :). > - self.mounts.append("/tmp/stage1root/proc") > - self.mountmap["/tmp/stage1root/proc"]=3D"/proc" > + self.mounts.append("stage1root/proc") > + self.target_mounts["stage1root/proc"] =3D "/tmp/stage1root/proc" > + self.mountmap["stage1root/proc"]=3D"/proc" Hmm. I'm not how this is handled at the moment, but don't we want: mount -t proc none /tmp/stage1root/proc instead of: mount --bind /proc /tmp/stage1root/proc The handbook is currently using --rbind as well [1]. Maybe food for a future series :p. Cheers, Trevor [1]: http://www.gentoo.org/doc/en/handbook/handbook-x86.xml?part=3D1&chap= =3D6#doc_chap1_sect3 --=20 This email may be signed or encrypted with GnuPG (http://www.gnupg.org). For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy --3ecMC0kzqsE2ddMN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJSv42hAAoJEKKfehoaNkbtkIEP/0JjOPYbbk6JxagkV4OHR0az Zhzbs6fM3pXjSh6w6tl1qX1njzkubQpcLLxD32MXOFl9VIxCkCV6gbuCcm+zJxMV SwuDQD+BjdL3NwAkXORa0HBvR9/UjfL+G4temk941v4yS0iZdhbck9DuC9UaFe+4 AUVav/ImHn3HvIJz+XcWUhaG8DbdrWHnsRz4gbc8Sp78e7wFZ5OKe1d5aqiLMT4M oDyLcEpq8S7kw2MfW1ueX3uK4Rw26DPRHlxcM7GhM7+1cV7sre5JmcWiHSAEAhJp o2RoUK6ydbd2Xii0uLDO+r0Aj1adL/PpP0JqNJt+D1FMmSMeOgPZPVJJMDubWws0 m6Fh1K/T+52xkSBfeop/gX8ZIotvQAgcFGV6QA3VUObFkflJ+46rXlZiWkf3OyrF wW2ze2EzNuZe9OAWbhlZdGLZvqnGn/vEwuSZmZUJgEljP1A3YWMe5wEsLimNjRhj pKHhu8GuqhqAc9m3UUvFXy8q98T/sEA7bKbCWr5+LIt0oUYg1YJQytD4ZDGZs0ei wdIjkQ90zdCGs0YFh84SD9wsxnDB9rbaRx+2fzkfwy/B0Rute8jMBPPdooMShURa PsQ9xpmJpI38/VTskiF1WAsTmN+LRjn4ufcZ18NLWEBHbpSI981sVcn2t/10paEy 1uPJlJI00kMK1yWoL1D9 =tppF -----END PGP SIGNATURE----- --3ecMC0kzqsE2ddMN--