There's still an extra space in the commit summary: “: Use” vs. “: Use” Not a big deal, but it's an easy fix ;). On Sun, Dec 29, 2013 at 05:50:48PM -0800, Brian Dolbec wrote: > Fix a missed self.mounts key change from a path as key. > original patch: 27b751ffd9594e0128a3d70f83c7af18dab03838 As I mentioned in my comments on v1#4: On Sat, Dec 28, 2013 at 06:30:15PM -0800, W. Trevor King wrote: > On Sat, Dec 28, 2013 at 05:57:08PM -0800, Brian Dolbec wrote: > > original patch: 27b751ffd9594e0128a3d70f83c7af18dab03838 > > Actually, I don't think this is related to 27b751f > (modules/generic_stage_target.py: Use 'portdir' instead of hard-coding > '/usr/portage', 2012-12-19), which was only about > self.settings["portdir"]. All of the stuff in here (from both v1#1 and v1#4) is just fixing the mountmap keys and matching mounts entries for the SNAPCACHE case. If you want to blame a commit, I'd blame the whole: Use '*' instead of '*' as the mountmap key series for skipping the SNAPCACHE cases. On Sun, Dec 29, 2013 at 05:50:48PM -0800, Brian Dolbec wrote: > - self.mounts=["/proc","/dev","/usr/portage","/usr/portage/distfiles","/var/tmp/portage"] > - self.mountmap={"/proc":"/proc","/dev":"/dev","devpts":"/dev/pts", > - "/usr/portage":self.settings["snapshot_cache_path"]+"/portage",\ > - "/usr/portage/distfiles":self.settings["distdir"],"/var/tmp/portage":"tmpfs"} > + self.mounts=["proc", "dev", "portdir", "distdir", "port_tmpdir"] > + self.mountmap={"proc": "/proc", "dev": "/dev", "devpts": "/dev/pts", > + "portdir": self.settings["snapshot_cache_path"] + "/portage", > + "distdir": self.settings["distdir"], "port_tmpdir": "tmpfs"} > … > - if "SNAPCACHE" in self.settings and x == "/usr/portage": > + #print "bind(); src =", src > + if "SNAPCACHE" in self.settings and x == "portdir": The code changes look great :). Cheers, Trevor -- This email may be signed or encrypted with GnuPG (http://www.gnupg.org). For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy