From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 321BF138247 for ; Mon, 30 Dec 2013 03:55:00 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 1ED8EE0AD1; Mon, 30 Dec 2013 03:54:59 +0000 (UTC) Received: from qmta02.westchester.pa.mail.comcast.net (qmta02.westchester.pa.mail.comcast.net [76.96.62.24]) by pigeon.gentoo.org (Postfix) with ESMTP id 887B6E0AD1 for ; Mon, 30 Dec 2013 03:54:58 +0000 (UTC) Received: from omta13.westchester.pa.mail.comcast.net ([76.96.62.52]) by qmta02.westchester.pa.mail.comcast.net with comcast id 7fit1n00417dt5G51fuy3n; Mon, 30 Dec 2013 03:54:58 +0000 Received: from odin.tremily.us ([24.18.63.50]) by omta13.westchester.pa.mail.comcast.net with comcast id 7fux1n002152l3L3Zfuxub; Mon, 30 Dec 2013 03:54:58 +0000 Received: by odin.tremily.us (Postfix, from userid 1000) id 9A350E366BC; Sun, 29 Dec 2013 19:54:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tremily.us; s=odin; t=1388375696; bh=Bs+E06qI7p7LSUCQNnCpzBZh74AiFN5x3bRMgvwhg0E=; h=Date:From:To:Subject:References:In-Reply-To; b=PweTRRvKsrcEJ7+Rc1LWs1Y9s7HiM+rF23vLfNndRr7VY6iPyzc9sbfXxl98kFXsE z2hHmGIHYwUtMrZAiPIR/cjU3LvrcBh1mLgsrRWE4PN2VsqzYlLs4bh/+B/voetO02 cKmTMreN5575A1i6Sg8XbYSRBCb1tmKsFoPwQOWk= Date: Sun, 29 Dec 2013 19:54:56 -0800 From: "W. Trevor King" To: gentoo-catalyst@lists.gentoo.org Subject: Re: [gentoo-catalyst] [PATCH 1/6] modules/generic_stage_target.py: Use portdir, distdir,... instead of paths for keys Message-ID: <20131230035456.GN29195@odin.tremily.us> References: <1388282230-3563-1-git-send-email-dolsen@gentoo.org> <1388368253-22018-1-git-send-email-dolsen@gentoo.org> <1388368253-22018-2-git-send-email-dolsen@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="fz0LNKsoEivY4NpG" Content-Disposition: inline In-Reply-To: <1388368253-22018-2-git-send-email-dolsen@gentoo.org> OpenPGP: id=39A2F3FA2AB17E5D8764F388FC29BDCDF15F5BE8; url=http://tremily.us/pubkey.txt User-Agent: Mutt/1.5.22 (2013-10-16) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20121106; t=1388375698; bh=5xPf9KOJUdr5KC6FRjDZ991H0O+V96vbfwUwb45xE9M=; h=Received:Received:Received:Date:From:To:Subject:Message-ID: MIME-Version:Content-Type; b=C/iIms2iQNlA+o4UIkhh67ESO+qUbmb9gfKzBf4C7qPp4hrtadKwDUYuROAph2Pe/ GJ9mEDSXhyslFx7PhVRVzYFhzRuCxjXQPC6ocA0gc/1nXcGgZs1pdRcNRxhGy7tqy0 z72cXAdxI1Nls/ZZznR/sXuMZOMXPg4HcRBZJbB2lC2SsGwS9D2tADsxYmVSsICtx5 5hsBd3C507ON9p9Bl3Q7+VI+mQcp/9ESqvHvQtUnzaXiKeeCEm+OzE4CPL17OxTqCn 2UkjcnqbwUz8vf0ePBChzqPIxOnzRe7s9E0aMgULPCnY7aBljqXC8kkSEAPqLQKJDl 2maR2aCctqsEQ== X-Archives-Salt: 521c2c9e-396e-43e4-a9f0-72c5119577a9 X-Archives-Hash: ab0a0eacedd473d8be93979354be1551 --fz0LNKsoEivY4NpG Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable There's still an extra space in the commit summary: =E2=80=9C: Use=E2=80=9D vs. =E2=80=9C: Use=E2=80=9D Not a big deal, but it's an easy fix ;). On Sun, Dec 29, 2013 at 05:50:48PM -0800, Brian Dolbec wrote: > Fix a missed self.mounts key change from a path as key. > original patch: 27b751ffd9594e0128a3d70f83c7af18dab03838 As I mentioned in my comments on v1#4: On Sat, Dec 28, 2013 at 06:30:15PM -0800, W. Trevor King wrote: > On Sat, Dec 28, 2013 at 05:57:08PM -0800, Brian Dolbec wrote: > > original patch: 27b751ffd9594e0128a3d70f83c7af18dab03838 > > Actually, I don't think this is related to 27b751f > (modules/generic_stage_target.py: Use 'portdir' instead of hard-coding > '/usr/portage', 2012-12-19), which was only about > self.settings["portdir"]. All of the stuff in here (from both v1#1 and v1#4) is just fixing the mountmap keys and matching mounts entries for the SNAPCACHE case. If you want to blame a commit, I'd blame the whole: Use '*' instead of '*' as the mountmap key series for skipping the SNAPCACHE cases. On Sun, Dec 29, 2013 at 05:50:48PM -0800, Brian Dolbec wrote: > - self.mounts=3D["/proc","/dev","/usr/portage","/usr/portage/distfiles"= ,"/var/tmp/portage"] > - self.mountmap=3D{"/proc":"/proc","/dev":"/dev","devpts":"/dev/pts", > - "/usr/portage":self.settings["snapshot_cache_path"]+"/portage",\ > - "/usr/portage/distfiles":self.settings["distdir"],"/var/tmp/portage"= :"tmpfs"} > + self.mounts=3D["proc", "dev", "portdir", "distdir", "port_tmpdir"] > + self.mountmap=3D{"proc": "/proc", "dev": "/dev", "devpts": "/dev/pts", > + "portdir": self.settings["snapshot_cache_path"] + "/portage", > + "distdir": self.settings["distdir"], "port_tmpdir": "tmpfs"} > =E2=80=A6 > - if "SNAPCACHE" in self.settings and x =3D=3D "/usr/portage": > + #print "bind(); src =3D", src > + if "SNAPCACHE" in self.settings and x =3D=3D "portdir": The code changes look great :). Cheers, Trevor --=20 This email may be signed or encrypted with GnuPG (http://www.gnupg.org). For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy --fz0LNKsoEivY4NpG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJSwO6OAAoJEKKfehoaNkbt8L0P/jGFJdfu/f4YZu7x9zzwMNY1 i+TR8Bm7Ljut9EPGPnGfKtgX3ocURdkXaFRWRpBia0y1zKvRKaUx867G9BPOVwtl oCDLJei1cjxAYkVTmeykvqZ17nfdOEKw6IyeVe/zybOHqo9arvv5YCKRcmhUXAcR t7PDX+9tWg/m+D7d4Hl+LHb7hCj15xX+2yiXCnb23I+nVw/4BhdYoKdB9r7Xea/6 J6sBcT1uCSH52RcguNxE2rGVtmCkhML6LNtNBT3JujsRZCU8vPPg2v8+zOxb0KYq FbPtUzmcjHbcLC7PI1LvTm+51ErM+hTjmsNuhVq528dtZyykjHUuPT+AdtEMPErj MoxPR/0zjr9vrHTE0KUyEtBc/uF5P/gFdOz1YUncN2SZmUNdhcYe2MHHzxuZ1Vka QhTUaVFUvAgxbvxYShFnQz+YS0djhGRII0VC3UsCZ19Ytk3VGfBwVs0mXFDmY0LW lMeoexBdOQPIn8ECzjzPo8/bGgykPh5c4IS9SmO8l/CAJsWa8Gr3a+y6ppBGMhNO J5TCf0WakG3hkAO2am618FbMr1X854nm/xeE9lpbpTZW/PE4rFv62XDhvM/kGEAQ G/FO0hIEnY9gPVAiAvQ6KvCtbE9k0KxH1mhbsXyG1wmeyQoeAMYzUDBSVyyGLJ99 YiGHGONGrWFoZjAwzPGY =e1Gt -----END PGP SIGNATURE----- --fz0LNKsoEivY4NpG--