From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 24E41138247 for ; Mon, 30 Dec 2013 04:09:38 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 92264E0ACF; Mon, 30 Dec 2013 04:09:36 +0000 (UTC) Received: from qmta07.westchester.pa.mail.comcast.net (qmta07.westchester.pa.mail.comcast.net [76.96.62.64]) by pigeon.gentoo.org (Postfix) with ESMTP id 1125DE0ACF for ; Mon, 30 Dec 2013 04:09:35 +0000 (UTC) Received: from omta13.westchester.pa.mail.comcast.net ([76.96.62.52]) by qmta07.westchester.pa.mail.comcast.net with comcast id 7g841n00217dt5G57g9bX7; Mon, 30 Dec 2013 04:09:35 +0000 Received: from odin.tremily.us ([24.18.63.50]) by omta13.westchester.pa.mail.comcast.net with comcast id 7g9a1n00B152l3L3Zg9bcG; Mon, 30 Dec 2013 04:09:35 +0000 Received: by odin.tremily.us (Postfix, from userid 1000) id 2F2A4E368A8; Sun, 29 Dec 2013 20:09:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tremily.us; s=odin; t=1388376574; bh=qRHHo//eoaE7pzcDeyLeLJLFrZv/SYL7js3aOFXj7ls=; h=Date:From:To:Subject:References:In-Reply-To; b=NxQYJ6MzZZ7DyWeT6LWP/bYMFpW0FzyDaxoW4deuuc3LcocAJIh5x/F1lm5RsNLhJ nA/j3Wz1n+hiGVMtDMShDwhrMkg5ydnNFXdWlciDUYLm0oioZri/DFseF/tSYyHquj 9R9MrXCrHrhV6SFeddosdv3Q/gf7/EVqV7bLjlDU= Date: Sun, 29 Dec 2013 20:09:34 -0800 From: "W. Trevor King" To: gentoo-catalyst@lists.gentoo.org Subject: Re: [gentoo-catalyst] [PATCH 4/6] Fix mounts and mountmap port_logdir code block. Message-ID: <20131230040933.GQ29195@odin.tremily.us> References: <1388282230-3563-1-git-send-email-dolsen@gentoo.org> <1388368253-22018-1-git-send-email-dolsen@gentoo.org> <1388368253-22018-5-git-send-email-dolsen@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="gblAvmLjk8yGG9If" Content-Disposition: inline In-Reply-To: <1388368253-22018-5-git-send-email-dolsen@gentoo.org> OpenPGP: id=39A2F3FA2AB17E5D8764F388FC29BDCDF15F5BE8; url=http://tremily.us/pubkey.txt User-Agent: Mutt/1.5.22 (2013-10-16) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20121106; t=1388376575; bh=KDwsJY+7xS1LfkXuUP49k211oD966RtBC4FhfJdCl3k=; h=Received:Received:Received:Date:From:To:Subject:Message-ID: MIME-Version:Content-Type; b=NM2Yc7HqCJ2eUPu5MXAR9+ESesPCofkEEH4zVzrA1bDxsiLZMcb9Frz5etky4cg/+ jxJ8kHZij2c+BxhpTRpaYpj/jZDEiaDqFxPr4jlHB9m0KmIKlJoAoi7Qy2eo7b/2+D 1TFixIO2BeoS06rxqtVDVXwUwM8/l4M8gV08spzQ0AL5DZcHgr5do6oDTcsd/T1srY JcvmDyN4eHOBkKoMTRJaHK3WeKigFGePCs3Im+djauK4eg0ZqZeU39o+GwzkUXDK/Z KAP6Bp7j7MWY0CEWReis75v8mVCuQFheRY29e+iVzzRirMAO369pizVYoE3DAZe4v5 GnULnTRmiecZw== X-Archives-Salt: 2c22d8b0-0a43-4df1-8726-1a701c83512b X-Archives-Hash: 5842d4f5d8c0e44f0eb6123699d7a0b4 --gblAvmLjk8yGG9If Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Dec 29, 2013 at 05:50:51PM -0800, Brian Dolbec wrote: > +PORT_LOGDIR_CLEAN =3D \ > + 'find "${PORT_LOGDIR}" -type f ! -name "summary.log*" -mtime +30 -delet= e' Pulling out this global variable is new for v2. I don't think I'm a fan. I think it should either be hard-coded where we setup env["PORT_LOGDIR_CLEAN"] (as it was before) or pulled out of self.settings (like PORT_LOGDIR). > - self.mounts.append("/var/log/portage") > - self.mountmap["/var/log/portage"]=3Dself.settings["port_logdir"] > - self.env["PORT_LOGDIR"]=3D"/var/log/portage" > - self.env["PORT_LOGDIR_CLEAN"]=3D'find "${PORT_LOGDIR}" -type f ! -nam= e "summary.log*" -mtime +30 -delete' > + self.mounts.append("port_logdir") > + self.mountmap["port_logdir"] =3D self.settings["port_logdir"] > + self.env["PORT_LOGDIR"] =3D self.settings["port_logdir"] > + self.env["PORT_LOGDIR_CLEAN"] =3D PORT_LOGDIR_CLEAN Other than the newly-global PORT_LOGDIR_CLEAN, this looks good to me. Cheers, Trevor --=20 This email may be signed or encrypted with GnuPG (http://www.gnupg.org). For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy --gblAvmLjk8yGG9If Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJSwPH9AAoJEKKfehoaNkbtTT8P/jLMYXW6AvpE855YbQjuAT6F lnaBspLNXW9GU3EIw/asNHsYJN6n2XwmrKtc1yVa8uzqLYUrUZZGv//UkNl8OhPp lMxBKU9V9zPsLViGEeEDxTOUKysEwf4diWNOgR/rKZMPNv6W919iXsYARwOpJwOJ NZ2GufcuoiJ6ETRLZsjnSH4McQa2fkZEPUlSBNBhRArXRwApEKEdCkJYPGmBhwBC +qAdxRU+KG5vpglBflbi942asXKt5mXPfJtzr5oi3ocSWZtGb1PhbHqcxEpLE+un k0tUHp9Rz2qpLtToSWm7w7xy88vEwreFekU6oL9InH3aq8ycvcqtu4ciF7HZEWQB difQBVJ1gcfH4ThfHGJBjNRSuSsn7YcF/mKTsEncI1bkqpYUff70tydzSEMr/xqT 670W9FN7et0VG2rv78C8gr7NnlY+40gHb2PvU+7A0MUfHjKKi0JV4bBIGgs/K0Bd RM7SHTAmCKo/aLQsaIZQ7MXgGt1ManLQtINoszZ1asARDwGgY7ExpyPH95r7PQO+ s3bTM2SJa+gZZF+GN7wRYVccgh865wBrE6DbS7Du40lG3tSqH13l8OTHWt0Ag+Ha 46bwkaYmH226OdAmNK8YwKG5X6/0FfwTw+VhWHY0UwDayP+N/C0cNJMPhJSJ3Crf kWnZrdjjlaF75HfeKQUT =8v7p -----END PGP SIGNATURE----- --gblAvmLjk8yGG9If--