From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id D7BDE138247 for ; Mon, 30 Dec 2013 04:16:56 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id BDD01E0A86; Mon, 30 Dec 2013 04:16:54 +0000 (UTC) Received: from qmta07.westchester.pa.mail.comcast.net (qmta07.westchester.pa.mail.comcast.net [76.96.62.64]) by pigeon.gentoo.org (Postfix) with ESMTP id 46558E0A86 for ; Mon, 30 Dec 2013 04:16:54 +0000 (UTC) Received: from omta02.westchester.pa.mail.comcast.net ([76.96.62.19]) by qmta07.westchester.pa.mail.comcast.net with comcast id 7gGA1n0010QuhwU57gGtqS; Mon, 30 Dec 2013 04:16:53 +0000 Received: from odin.tremily.us ([24.18.63.50]) by omta02.westchester.pa.mail.comcast.net with comcast id 7gGs1n00R152l3L3NgGtV5; Mon, 30 Dec 2013 04:16:53 +0000 Received: by odin.tremily.us (Postfix, from userid 1000) id 3E5F9E36989; Sun, 29 Dec 2013 20:16:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tremily.us; s=odin; t=1388377012; bh=mzivTnt5jc6NZbop42qjm7tJeVaOSLRtJ2NW6O/UUMI=; h=Date:From:To:Subject:References:In-Reply-To; b=PstJqiw6ROatiJpjeE4AQDNe6fibRuqmgI7yEsqOt9TYoG5VD/CcNfffMP3cpUPnZ FvHVx5tLb/TKS80lYb5XLkm+I19DYHUGmkQ00YrhpQza5rMb824KDi64UpdnNds+fg DOepN6EmBv4bYaMYkbynLGTC9fUO2taql42WyxL0= Date: Sun, 29 Dec 2013 20:16:52 -0800 From: "W. Trevor King" To: gentoo-catalyst@lists.gentoo.org Subject: Re: [gentoo-catalyst] [PATCH 5/6] modules/generic_stage_target.py, modules/stage1_target.py: Add a target_mounts dictionary Message-ID: <20131230041652.GR29195@odin.tremily.us> References: <1388282230-3563-1-git-send-email-dolsen@gentoo.org> <1388368253-22018-1-git-send-email-dolsen@gentoo.org> <1388368253-22018-6-git-send-email-dolsen@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="/Isdj7O9hWi8F9Bn" Content-Disposition: inline In-Reply-To: <1388368253-22018-6-git-send-email-dolsen@gentoo.org> OpenPGP: id=39A2F3FA2AB17E5D8764F388FC29BDCDF15F5BE8; url=http://tremily.us/pubkey.txt User-Agent: Mutt/1.5.22 (2013-10-16) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20121106; t=1388377013; bh=ZR5LDiW1AsCpg+hWnbxSEvvnuYlb3HsFivzNtrXbyMs=; h=Received:Received:Received:Date:From:To:Subject:Message-ID: MIME-Version:Content-Type; b=qLWgE8uJ1L39s/k/vTQMgs6AovC4UymbPHuIAuYg4XhCyiBLkrkOXNVMnnfIsHcg4 VcVXGTwjuQuYQsv+WJHec4WBWpeAlzVpY7v6ytKB9aNWrF8pf85VQQ69f+KCMxVQP1 u/c6cjVQzLBraAN3eSzMM3d1Ijr+5ujwPGNAo1OZgd8UDZRxpDRZcpm1FeWbTRO6Nz a624T92k6jKpxKNZRT1uHDZdnLBMjc/+OLrFBcpXGFhE2cbnGdPgTwhhkDtsHSXQD5 lRTagPLmHHwMaSzP9jH2uKwjQ+qxVjtP/rhqpygIrr05WWOmkV3bevIBf+zZYBSB2H 1jtCXMu7WznaQ== X-Archives-Salt: 28ae82d5-abc6-48b4-a07e-6d26499cbd33 X-Archives-Hash: 66101592bf12e679a8a4a45e8a51f1b6 --/Isdj7O9hWi8F9Bn Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Dec 29, 2013 at 05:50:52PM -0800, Brian Dolbec wrote: > Temporary location to define TARGET_MOUNTS, IT will be moved to a new def= aults.py file in a later commit. =E2=80=9CTARGET_MOUNTS, IT=E2=80=9D =E2=86=92 =E2=80=9CTARGET_MOUNTS_DEFAUL= TS. It=E2=80=9D. I'd also wrap the long lines into paragraphs (just like email :), but I'm fine if you'd rather stick with one line per sentence. > +TARGET_MOUNTS_DEFAULTS =3D { > + "ccache": "/var/tmp/ccache", > + "dev": "/dev", > + "devpts": "/dev/pts", > + "distdir": "/usr/portage/distfiles", > + "icecream": "/usr/lib/icecc/bin", > + "kerncache": "/tmp/kerncache", > + "packagedir": "/usr/portage/packages", > + "portdir": "/usr/portage", > + "port_tmpdir": "/var/tmp/portage", > + "port_logdir": "/var/log/portage", > + "proc": "/proc", > + } > + +1 for alphebetizing this. The rest of the patch matches v1#5 (less the v2#4 changes) with the future-predicting comments pulled out. All of that looks good too. Cheers, Trevor --=20 This email may be signed or encrypted with GnuPG (http://www.gnupg.org). For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy --/Isdj7O9hWi8F9Bn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJSwPOzAAoJEKKfehoaNkbtisAQALPYAApO1xRE+cC0TgIEI4Fj 75niXwwMRA5NUDkhCU/dpGsJSmtmjhjpfC/SwDI2o1CW3y3lhqf7X3sazo60lq+y PqVldA2SAZh3H8XAJpEaKExy3JHhO3tqBmJxfNo8p/UiSBFAbuDH69353n4zd5/H mNRRfB61XTAFuaZzv/szkc+nXkZZBBRel1HalleQQcTjlgvlh6rM3ulC3Xr1ZN2k qTprhFcEmO7BOWMrzeMWYPR7X//RdSUCFaZlKDphy3k5bH2BkBW9oOwjKEubb7YL 2B4ImaxrG/VdnK7QZTi/Rxpmn7oj3ZtqIIyTw+PncOiU3hjjTszWqCtSJrn7HC6T 4jDVtRA8psYqRWourc9d1EBlXiFcZBjOCRWUUIdQJqBk4kAtVvXn6iBLWRuuWP7S SPfwjzPrwvmaFUqJ0qYQZGmK7SJWLql5dzViWWXBrILQ1QiWf3BUx+OyEEQiLiHZ xEm+J/maE+1j8R5V2K4X4hmfUt1JK7LLDvbuvPWWo0BexchhIg2F/XcEtb2CC8py p+8+T+dXzg+o+aoyuNoJCS4JnjjOKbOAepA4eNfUOtCmFkcdbnUNzKTr41s3LVfX yMwZJKzdDwT+CxfYqzp4BlohHtN94cp3SsIQjHQM5wNCilKHREjqk2mj5+uJkWoZ KuOlZVUd2kEY2xOKIWbZ =kd3P -----END PGP SIGNATURE----- --/Isdj7O9hWi8F9Bn--