From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 348EF138247 for ; Mon, 30 Dec 2013 06:35:20 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id A81E3E0A92; Mon, 30 Dec 2013 06:35:18 +0000 (UTC) Received: from qmta01.westchester.pa.mail.comcast.net (qmta01.westchester.pa.mail.comcast.net [76.96.62.16]) by pigeon.gentoo.org (Postfix) with ESMTP id 27331E0A92 for ; Mon, 30 Dec 2013 06:35:17 +0000 (UTC) Received: from omta19.westchester.pa.mail.comcast.net ([76.96.62.98]) by qmta01.westchester.pa.mail.comcast.net with comcast id 7iZJ1n00327AodY51ibHNx; Mon, 30 Dec 2013 06:35:17 +0000 Received: from odin.tremily.us ([24.18.63.50]) by omta19.westchester.pa.mail.comcast.net with comcast id 7ibF1n00G152l3L3fibGJF; Mon, 30 Dec 2013 06:35:17 +0000 Received: by odin.tremily.us (Postfix, from userid 1000) id 43F05E375AE; Sun, 29 Dec 2013 22:35:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tremily.us; s=odin; t=1388385315; bh=JmT40duLNHFMQT1RLgBgoVP/Do1su4jMzocvmgF1Hak=; h=Date:From:To:Subject:References:In-Reply-To; b=n7CJwpmftiEvRJP5ux7bD/cJNgxraNTOWlx+NwXYkSm0UlN1VTW4b1bcsSPkxBZYu J+C1Po6aBF718pQNxm48f3DHrup2S4Ng8wzPvIwOH0eWumBHdkl7LlIwmrIHM9bU5/ G+0706262c3Fkigl0+M6YwVwfBtYfDEfhxmsqn6g= Date: Sun, 29 Dec 2013 22:35:15 -0800 From: "W. Trevor King" To: gentoo-catalyst@lists.gentoo.org Subject: Re: [gentoo-catalyst] [PATCH 3/6] Fixes commit 463d98f (modules/generic_stage_target.py: Use a 'local_overlay' setting instead of hard-coding '/usr/local/portage', 2012-12-19).Add "local_overlay" to configdefaults. Message-ID: <20131230063515.GT29195@odin.tremily.us> References: <1388282230-3563-1-git-send-email-dolsen@gentoo.org> <1388368253-22018-1-git-send-email-dolsen@gentoo.org> <1388368253-22018-4-git-send-email-dolsen@gentoo.org> <20131230040215.GP29195@odin.tremily.us> <1388381555.24088.63.camel@big_daddy.dol-sen.ca> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="fberPwKQctZF/fXp" Content-Disposition: inline In-Reply-To: <1388381555.24088.63.camel@big_daddy.dol-sen.ca> OpenPGP: id=39A2F3FA2AB17E5D8764F388FC29BDCDF15F5BE8; url=http://tremily.us/pubkey.txt User-Agent: Mutt/1.5.22 (2013-10-16) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20121106; t=1388385317; bh=Jc6luvBYmG/ksLAAxsZcghF6IbTFyrhP3zfP+s5PtGE=; h=Received:Received:Received:Date:From:To:Subject:Message-ID: MIME-Version:Content-Type; b=BHb7Rv7m80h7H7UOLho71z7LXZhw76FQpffIUeEZFALWC/VoFBVkFvANH43AQR6Iz rUXOswij33mdUkwd4+t8K9LFnD9LbbnRlxUJqQZ1HYmFfWrE79O72HxRec+pHc6xNM 2WjqfsHpY6yOAcPiVyJMOtynS+uupmM3t3EDjqetZqn2KJ+xeTJrsM7JRtmkQmcSb4 Z/OQLtQ8OSBXzf95MS/UEbNQA30B4yOB/zn1h2O/xS5CB/aNfk5uwjl7E3NHXiRThs cvBr33PuO8Yis82MDKAhNIynHa3Ajzsfv9g5QFKZqGCINzfiVKkvfMfSTeBGB5elWo SEpkpIWYzMefg== X-Archives-Salt: 800a050d-3d14-4c06-a9a1-17666158fad8 X-Archives-Hash: 68850cc8dbb699ca3d33e4269f958751 --fberPwKQctZF/fXp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Dec 29, 2013 at 09:32:35PM -0800, Brian Dolbec wrote: > On Sun, 2013-12-29 at 20:02 -0800, W. Trevor King wrote: > > That's a long subject ;). How about: > >=20 > > Add "local_overlay" to configdefaults > >=20 > > Fixes commit 463d98f (modules/generic_stage_target.py: Use a > > 'local_overlay' setting instead of hard-coding '/usr/local/portage', > > 2012-12-19). > >=20 > > That gives you both a concise summary and a more detailed body without > > making wrapping in `git log --oneline`. >=20 > First: I'm not feeling well, so please don't take this too personally. No problem. I don't think there's a particular hurry to address everything either, so if you want to just let things cook for a week and then get back to them when you're feeling better, that's certainly fine with me. > I committed exactly what you had in the previous review > (copy/paste). I knew it was too long, but when I tried breaking it > up, git puked on it. so I thought what the hell and left it. I > wasn't going to "waste" more time on it. I've pushed: git://tremily.us/catalyst.git pending with the commit-message cleanups I've suggested on v2. If you want me to help figure out why Git didn't like your earlier attempt, just let me know. Cheers, Trevor --=20 This email may be signed or encrypted with GnuPG (http://www.gnupg.org). For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy --fberPwKQctZF/fXp Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJSwRQhAAoJEKKfehoaNkbt5YkP/jY7pXA61Fa2wUqP5O8PLXfa VQB5IOP4ZhUm3i7hRjb0/mRF63b0LsX7js6xb9D5gy2h8bN3pZE/kVG7AH04TN6s eWOo3YCLid0V51B0/O0sa7WhnH2gAC9PyrAZqQ27FcFYpfbNBGK6aBawebrFCU6M 9JZoqUzWWs4TYwldZ8Z8ovTf92UzvnMlWJYWWvxZRwOEzuq7W8wuqOmI/q4WqGkb gP2CGI1x1d2D10HUIBAl6jzYRJMXk7VgePWoHApv6c85ny8/SmAalIZtoCCXs5qZ l8uNiI16vAu1Tw/JJ4rm3r/Df07lZiVunJhP3n8z9/LhAVa7nUYj2OgXNEbmQ+Iu iobWr0ROrf3/wZTeeh83uupSRcghsQO7hfQL/ectv43IUr0AQmznBPQOUa++bXlC n1o6SBxA3fokSj4IHM0xLgf+/qk0RB74savX0CTIqsaFQkWkEys/shIuByM8OejG 4w0q140GJiabGHKhUoKScPkrVYSIPpHNmrX80s5RWRSyN2DB1p+A1LHKipXX0w9d IOeRWmkksk4tRPXvEqvey7CxkIiI9b+KmE9p4yBsthiQaTsasFfm/HomLY+jVzSx 5pp2Ese7sbyY//gYd7GFzyX3WqIl25uuNkX2YisEtBWfBra+E9TjypZ7egWEGqB+ Hg2zTFOFG/7gI3M3mTbr =J2S1 -----END PGP SIGNATURE----- --fberPwKQctZF/fXp--