From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 8211A138247 for ; Fri, 3 Jan 2014 04:33:56 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id E830DE09D5; Fri, 3 Jan 2014 04:33:54 +0000 (UTC) Received: from qmta13.westchester.pa.mail.comcast.net (qmta13.westchester.pa.mail.comcast.net [76.96.59.243]) by pigeon.gentoo.org (Postfix) with ESMTP id 51771E09D5 for ; Fri, 3 Jan 2014 04:33:54 +0000 (UTC) Received: from omta11.westchester.pa.mail.comcast.net ([76.96.62.36]) by qmta13.westchester.pa.mail.comcast.net with comcast id 9GQ41n0050mv7h05DGZt2d; Fri, 03 Jan 2014 04:33:53 +0000 Received: from odin.tremily.us ([24.18.63.50]) by omta11.westchester.pa.mail.comcast.net with comcast id 9GZs1n00M152l3L3XGZt75; Fri, 03 Jan 2014 04:33:53 +0000 Received: by odin.tremily.us (Postfix, from userid 1000) id 20231E62475; Thu, 2 Jan 2014 20:33:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tremily.us; s=odin; t=1388723632; bh=nOxaQvpl5XIL0LoScrE5DhCNhmwCCMGP+0oOiee0Jm8=; h=Date:From:To:Subject:References:In-Reply-To; b=k2KuvTxI7i2yX6Vk8D9fzJBGmhDNzaFI9J41ZIHN5qjtIZS/RyClSI6XuGZ9u/9d4 jQuO9ttYjT/xAJHo2vuHA8YA21+p95mvTY3cNG7/rwTF/CukBegUuuegMu0NCBRXNT 1z2BoG1hftF55Wnrrb+YwIW3SwaudGjaxGRidtLo= Date: Thu, 2 Jan 2014 20:33:52 -0800 From: "W. Trevor King" To: gentoo-catalyst@lists.gentoo.org Subject: Re: [gentoo-catalyst] [PATCH v3 2/6] Fix a missed self.settings["repo_name"] migration Message-ID: <20140103043351.GC4680@odin.tremily.us> References: <1388282230-3563-1-git-send-email-dolsen@gentoo.org> <1388722582-27657-1-git-send-email-dolsen@gentoo.org> <1388722582-27657-3-git-send-email-dolsen@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="uXxzq0nDebZQVNAZ" Content-Disposition: inline In-Reply-To: <1388722582-27657-3-git-send-email-dolsen@gentoo.org> OpenPGP: id=39A2F3FA2AB17E5D8764F388FC29BDCDF15F5BE8; url=http://tremily.us/pubkey.txt User-Agent: Mutt/1.5.22 (2013-10-16) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20121106; t=1388723633; bh=YZgac3BT43PMY0iYCHUB1MJP+7Sp1Oiwsbt/Z3raV0g=; h=Received:Received:Received:Date:From:To:Subject:Message-ID: MIME-Version:Content-Type; b=A5P0ShE5PanKd9wsDwnpLyLrksYIvbISiV7jjGVijGe2o/8Z4/g16muq+Ov0XRge2 yHbptn1iaHVLclVW2BaqpGd2KFCWz9fkjUNBoQbOR8o/Dxo2UhYf20zo2DXDHg79e5 qSNrBLcGZeUGJkpE/2kPyOgbkhXOeJ0lbBL90aLC+WDsE57VIaM3HsnV0pPhf5VVNm iUevKDEqiSJccYPcSHaerbj+p9//b5540Gm9ef7NCWmDGc8Oh6SVr4jS9vGMrh6VGy 4ImYLAPj1aKiZrtT5+8otLuTYtvwGp+/APssss/PrKW6HwisHY6KVz2QUFtQWgACy9 HgpbEqZZRr37w== X-Archives-Salt: 7550d618-b6b6-484b-8c74-827a4fd1247b X-Archives-Hash: 4856341138e372539a5e1d53284da15e --uXxzq0nDebZQVNAZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 02, 2014 at 08:16:18PM -0800, Brian Dolbec wrote: > - self.mounts=3D["proc", "dev", "portdir", "distdir", "port_tmpdir"] > - self.mountmap=3D{"proc": "/proc", "dev": "/dev", "devpts": "/dev/pts", > - "portdir": self.settings["snapshot_cache_path"] + "/portage", > - "distdir": self.settings["distdir"], "port_tmpdir": "tmpfs"} > + self.mounts =3D ["proc", "dev", "portdir", "distdir", "port_tmpdir"] > + self.mountmap =3D { > + "dev": "/dev", > + "devpts": "/dev/pts", > + "distdir": self.settings["distdir"], > + "portdir": normpath("/".join([ > + self.settings["snapshot_cache_path"], > + self.settings["repo_name"], > + ])), > + "port_tmpdir": "tmpfs"} > + "proc": "/proc", Oops, trailing paren should follow the "proc" entry. A good reason to have it on it's own line: self.mountmap =3D { "dev": "/dev", "devpts": "/dev/pts", "distdir": self.settings["distdir"], "portdir": normpath("/".join([ self.settings["snapshot_cache_path"], self.settings["repo_name"], ])), "port_tmpdir": "tmpfs", "proc": "/proc", } Otherwise looks good. Cheers, Trevor --=20 This email may be signed or encrypted with GnuPG (http://www.gnupg.org). For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy --uXxzq0nDebZQVNAZ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJSxj2uAAoJEKKfehoaNkbtoSoP/1+wEQgVXVqlDgqrftQcUjrI E23tA65k2CztOUd1y6iI+Tgey5wA2RX4EU6pzuNmIMgTLsHV5QlyVqQBrGmE6awu bTho6mWXZM6IYSVd6wZ/vFTg/YRsES9cFZZrvmLtxStOi8f+YAKCLOtUlvovOcKg 5iI+BqBbbDnu9tny6fNCq6i4EjuXLYD41fvFWa8P9iqKLZ0nq6VjsdisrTa345aT Xvn7toUIojDrL1NZNq5qAE5AbEkw/6vnpuMSNXlw5FWupNk/0MQEsXYjmxcf324H UfYWOwF4Apw40XZkRocI1sLfB7alK2W038Iixc5QtezlzPBRdk//f6wdj1EB4gv6 fGAOGtR4Wh6B2VhrrLBYp3X5tipEqU/djd1zSi4X0V1oMyekpHYqw6Rh4EwLdS0b nm7L3uLyXhRqzRBDePlzb1LerMSExyGmj43f1ePPHQKgU2CAc912SzvSchw0ezki +zIwkHqPDSrq7dxeEIaiLwNRog4sPivbS6+fXeE8abw1cYwTIFRI0tY7wRVpcg8z fUX7b0raOgEorgjsZDxUEADuxoAD8DAt7B0yY29IuLVufatXlnEtvYQGYC2eQgcS E8JOF3/S0hClAkl/TXzt5NwZhT9jmtCRYhuGzK8oloba+zXSP8Ryh2uKiY8ZId9z 6gjyTWKpZbbth+fVmURX =/7vB -----END PGP SIGNATURE----- --uXxzq0nDebZQVNAZ--