From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 0BA0C138247 for ; Fri, 3 Jan 2014 04:47:40 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 89545E0A70; Fri, 3 Jan 2014 04:47:37 +0000 (UTC) Received: from qmta01.westchester.pa.mail.comcast.net (qmta01.westchester.pa.mail.comcast.net [76.96.62.16]) by pigeon.gentoo.org (Postfix) with ESMTP id ED287E0A70 for ; Fri, 3 Jan 2014 04:47:36 +0000 (UTC) Received: from omta09.westchester.pa.mail.comcast.net ([76.96.62.20]) by qmta01.westchester.pa.mail.comcast.net with comcast id 9Gho1n0040SCNGk51GncXi; Fri, 03 Jan 2014 04:47:36 +0000 Received: from odin.tremily.us ([24.18.63.50]) by omta09.westchester.pa.mail.comcast.net with comcast id 9Gnb1n00G152l3L3VGnc94; Fri, 03 Jan 2014 04:47:36 +0000 Received: by odin.tremily.us (Postfix, from userid 1000) id 248D2E626A1; Thu, 2 Jan 2014 20:47:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tremily.us; s=odin; t=1388724455; bh=PToLHI0Absv4S7lfXCBfp0n0LkYHCLHc2ruLptZyN88=; h=Date:From:To:Subject:References:In-Reply-To; b=AerDL8ebtbDLAcOCC8piO28d0jn+ERI+7gNutbgy8r2h9hBXJ/9TZ/FHYqI/Bg7L6 i9mJeeyhtk7B73n7hC+GoIcQTU3EsZ/ccgGZiV/kflWf3zgQNmlH1FPwIb6btS2SmM 8nBUEYKXcsjZTtCSqbNGNuuQrTrd4mhZSRqWT62k= Date: Thu, 2 Jan 2014 20:47:35 -0800 From: "W. Trevor King" To: gentoo-catalyst@lists.gentoo.org Subject: Re: [gentoo-catalyst] [PATCH v3 5/6] modules/generic_stage_target.py, modules/stage1_target.py: Add a target_mounts dictionary Message-ID: <20140103044734.GF4680@odin.tremily.us> References: <1388282230-3563-1-git-send-email-dolsen@gentoo.org> <1388722582-27657-1-git-send-email-dolsen@gentoo.org> <1388722582-27657-6-git-send-email-dolsen@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="A9z/3b/E4MkkD+7G" Content-Disposition: inline In-Reply-To: <1388722582-27657-6-git-send-email-dolsen@gentoo.org> OpenPGP: id=39A2F3FA2AB17E5D8764F388FC29BDCDF15F5BE8; url=http://tremily.us/pubkey.txt User-Agent: Mutt/1.5.22 (2013-10-16) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20121106; t=1388724456; bh=yNTm88mpKIvF1nur/FTIZz52VIfgz83HlDFLzt3fo0Y=; h=Received:Received:Received:Date:From:To:Subject:Message-ID: MIME-Version:Content-Type; b=jESqEozJJDB392QNdL/CaF3l85f7wY1N3vThsEh7mD8yWXnvAop7FKCkmS2ZBDYBI TBRREWwF5ehPCtYzPiDrapUGxPnlLDWpSZhA2uJQvvDzQ88F6B4WMc3dyE6f69lGzh WGFjzX2YUPOAGeVT+V+dfSdrxqTRBhxSlGudqFbKMsvCLa6vgqlFetCJ5SOlHnZ+lO 0F4H5GH7qPnN/7PmByj7nWajdeBNVBsppeDW1W/DyFkgIfaz6Dhw3AItpUgQBZ965S sU3v7/aqiYJ8tWqJifqLRGnMUcge+gUB3pajS7JBeFGniSa8WE3/iUviltzJHWw4Au s6/P2leX02YOg== X-Archives-Salt: 61a215f7-fc55-4654-a55f-d67ed0d1ceee X-Archives-Hash: 39ce04ed141f28a10caa3c89c74f30e3 --A9z/3b/E4MkkD+7G Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 02, 2014 at 08:16:21PM -0800, Brian Dolbec wrote: > Temporary location to define TARGET_MOUNTS_DEFAULTS. > It will be moved to a new defaults.py file in a later commit. > I also plan to make them configurable. >=20 > Also: > * Clean up all self.mounts, self.mountmap usage. > * Replace multiple path additions with one instance at the > beginning of the function, reuse the result multiple times. > * Add some extra debug prints (to be converted to logging later) Commit message looks great. The content is the same as v2, so I like it. Cheers, Trevor --=20 This email may be signed or encrypted with GnuPG (http://www.gnupg.org). For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy --A9z/3b/E4MkkD+7G Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJSxkDkAAoJEKKfehoaNkbtrDwP/jMoYyvGNx8QTqSzFfpqOQa6 pgs1bug4j731DYeiuWXg5T4V4GPq9H/CR6ELB7oQxd+F6viwyS1vkcfyt6LhRJaM SuwBOk+6q85kauYBEAE+t/PaGTuGPcUzSupq5QH2pJY10r2Bkn0ZIsyalf2/K7mv XpyO625LRgBqcXlJOUpT3rXEAp8uJFFaiuFkcuLEwp6PvhP28++YaZr8gZajYC5y 1nqTwle3Dgj7qWg9twSV5z2SEeRMTt99CVgLaGlUqt1DtpHGiF4a3flapx9PVXTQ o0o+Iw4W8YpFcQq52nPNt89pxJWpkdLoyRuuNQxrAPdkd6yNa4FqjGGQKS0IAbR5 bDlJcPWjMOWTGezySVBYmkmp8GQZIwxJbITvkqjjpslV6bnc8ZLwkE3ro1fgVFls dggaVHFjke89ktql4mt5gsv0TbYeYx+j3aLCW05LMTDQyRA1M8OtcUa+PUxaGYmC qi11Ibm3BzgIADsT5UjJTI0hKSjUXA7xc//sLbMfg+6/FBi53kGAuvuZjsH07yUe PHVcXofyN/6yt0bM6rAWKYSzWeY1QnEDpJuvUHev5ZTpijQBRHUQUYQmqh1lzoKq LboVZMJmcxQHEboXXOiCO+kqcaZq2kN3j4WZFsp/No1LoEweUlKbVKUHv0uL0AQC xo3oPE8C8F3QKVkKk8NP =tkvk -----END PGP SIGNATURE----- --A9z/3b/E4MkkD+7G--