On Wed, Jan 29, 2014 at 05:24:30PM -0500, Rick "Zero_Chaos" Farina wrote:
> Please use the gentoo-catalyst ML for these.  I have added to the cc
> so the proper eyes will see it.

Thanks.  Should I cull catalyst@ and hppa@ from future responses?

> On 01/29/2014 10:19 AM, Guy Martin wrote:
> > https://github.com/gmsoft-tuxicoman/catalyst/compare/6046e57...gmsoft?expand=1

Since the patches aren't inline, I'll respond to the log output:

  $ git log --graph --topo-order --oneline --decorate origin/2.X..gmsoft/gmsoft
  * 333808b (gmsoft/gmsoft) Fix kernel build when kerncache is disabled.
  * a5b80e5 update-modules doens't exists anymore.
  * 0f4c970 Add 'panic=30' to palo's command line.
  * 6046e57 Add the executable bit to all shell script.

I think 6046e57 is useful, but it's already in pending with 70f7cfc
and fcbcea4 [1].  That series has been warmly received by me on the
mailing list, although others have been silent ;).  I think we should
just merge that into master instead of 6046e57.  I don't care if it's
backported to 2.X.

I've never used PALO [2], so I'm agnostic on 0f4c970.  I agree with
dol-sen's #gentoo-releng comment that it would be better to make this
timeout configurable, but since this is code I'll never use, I don't
feel very strongly about it ;).

a5b80e5 looks good to me; I'd merge it into master too.  In general, I
think better error detection in Catalyst's target scripts would be
useful to help catch this sort of thing.

> > Regarding commit 333808b,

I don't understand the first hunk in 333808b:

  --- a/targets/support/kmerge.sh
  +++ b/targets/support/kmerge.sh
  @@ -199,9 +199,10 @@ fi
   [ -e /etc/portage/make.conf ] && \
          echo "USE=\"\${USE} ${clst_kernel_use} \"" >> /etc/portage/make.conf

  +mkdir -p /tmp/kerncache/${clst_kname}
  +
   if [ -n "${clst_KERNCACHE}" ]
   then
  -       mkdir -p /tmp/kerncache/${clst_kname}
          clst_root_path=/tmp/kerncache/${clst_kname} PKGDIR=${PKGDIR} clst_myemergeopts="--quiet --update --newuse" run_merge "${clst_ksource}" || exit 1
          KERNELVERSION=`portageq best_visible / "${clst_ksource}"`
          if [ ! -e /etc/portage/profile/package.provided ]

Why create /tmp/kerncache if kerncache is disabled?

> > the second hunk adds --selective=n to emerge always merge the
> > kernel. When having two kernels in the livecd specs, the first
> > build works fine but the second one fails because the sources are
> > removed and not reemerged.

I'm not entirely sure how this is supposed to work, but I'm not wild
about --selective=n.  Are the two kernels you're adding to the livecd
both from the same package?  I don't see how that could be, but
otherwise I'm not sure why the current invocation doesn't work.  Maybe
there were more details in the original message?  I haven't built a
livecd stage in a while, so I don't have much more than vague
skepticism here.  I'll try and run some local tests this weekend.

Cheers,
Trevor

[1]: http://thread.gmane.org/gmane.linux.gentoo.catalyst/2614
[2]: http://www.pateam.org/parisc-linux-boot/PA-RISC-Linux-Boot-HOWTO/palo.html

-- 
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy