Re: [gentoo-catalyst] Re: [PATCH] Fix autoresume file paths to only be configured once.

[Brian Dolbec <dolsen@gentoo.org>]

On Tue, 4 Mar 2014 22:27:44 -0800
"W. Trevor King" <wking@tremily.us> wrote:

> On Tue, Mar 04, 2014 at 09:07:03PM -0800, Brian Dolbec wrote:
> > The unfortunate part is that a bunch of these changes will be
> > replaced by other code later in the patch series.
> 
> I don't think there are any critical fixes here.  If it's easier to
> drop this cleanup and just jump straight to the final version, that's
> fine with me too.

Yeah, they aren't critical, but I'd like to land them now anyway.

> 
> > > On Sun, Mar 02, 2014 at 03:05:35PM -0800, Brian Dolbec wrote:
> > > > Use: pjoin as a shorter alias to os.path.join()
> > > 
> > > I think the saved characters are not worth the mental overhead of
> > > an additional layer of indirection.
> > > …
> > 

I'll look at the pjoin use again.


> > The autoresume stuff is later replaced with a self contained class.
> > I was never sure if I should submit it, but it did fix a couple
> > small issues.  I can go either way with this one.
> 
> Pulling it out into a class sounds good to me, but if it's easier to
> land this first (after fixing the exists() typo) and submit the
> class-based autoresume later, I'm fine with that.  I wanted to point
> out possible style changes, but none of that needs to be settled by
> this particular patch.  I think the removal of duplicate path
> calculations is a step in the right direction.
> 
> Cheers,
> Trevor
>

-- 
Brian Dolbec <dolsen>