From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 26B6F1391DB for ; Sun, 23 Mar 2014 00:19:24 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id CCF9AE0ADC; Sun, 23 Mar 2014 00:19:18 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 4E16EE0ADC for ; Sun, 23 Mar 2014 00:19:18 +0000 (UTC) Received: from big_daddy.dol-sen.ca (S010600222de111ff.vc.shawcable.net [96.49.5.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dolsen) by smtp.gentoo.org (Postfix) with ESMTPSA id 5CE7E33FB5E for ; Sun, 23 Mar 2014 00:19:17 +0000 (UTC) Date: Sat, 22 Mar 2014 17:19:02 -0700 From: Brian Dolbec To: gentoo-catalyst@lists.gentoo.org Subject: Re: [gentoo-catalyst] Re: [PATCH] Fix autoresume file paths to only be configured once. Message-ID: <20140322171902.44df15fc.dolsen@gentoo.org> In-Reply-To: <20140305062744.GF25297@odin.tremily.us> References: <1393801535-13921-1-git-send-email-dolsen@gentoo.org> <20140305043528.GB25297@odin.tremily.us> <20140304210703.1fae17d0.dolsen@gentoo.org> <20140305062744.GF25297@odin.tremily.us> Organization: Gentoo Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Archives-Salt: 5c8c3349-4bf5-41ee-b448-3e2e55c30d03 X-Archives-Hash: 899e68240ec49cefae3238e9788b4fe8 On Tue, 4 Mar 2014 22:27:44 -0800 "W. Trevor King" wrote: > On Tue, Mar 04, 2014 at 09:07:03PM -0800, Brian Dolbec wrote: > > The unfortunate part is that a bunch of these changes will be > > replaced by other code later in the patch series. >=20 > I don't think there are any critical fixes here. If it's easier to > drop this cleanup and just jump straight to the final version, that's > fine with me too. Yeah, they aren't critical, but I'd like to land them now anyway. >=20 > > > On Sun, Mar 02, 2014 at 03:05:35PM -0800, Brian Dolbec wrote: > > > > Use: pjoin as a shorter alias to os.path.join() > > >=20 > > > I think the saved characters are not worth the mental overhead of > > > an additional layer of indirection. > > > =E2=80=A6 > >=20 I'll look at the pjoin use again. > > The autoresume stuff is later replaced with a self contained class. > > I was never sure if I should submit it, but it did fix a couple > > small issues. I can go either way with this one. >=20 > Pulling it out into a class sounds good to me, but if it's easier to > land this first (after fixing the exists() typo) and submit the > class-based autoresume later, I'm fine with that. I wanted to point > out possible style changes, but none of that needs to be settled by > this particular patch. I think the removal of duplicate path > calculations is a step in the right direction. >=20 > Cheers, > Trevor > --=20 Brian Dolbec