From: Brian Dolbec <dolsen@gentoo.org>
To: gentoo-catalyst@lists.gentoo.org
Subject: Re: [gentoo-catalyst] [PATCH 7/7] Fix a relative path bug
Date: Mon, 1 Sep 2014 22:26:40 -0700 [thread overview]
Message-ID: <20140901222640.78f9d3a9.dolsen@gentoo.org> (raw)
In-Reply-To: <20140902050634.GI8263@odin.tremily.us>
[-- Attachment #1: Type: text/plain, Size: 985 bytes --]
On Mon, 1 Sep 2014 22:06:34 -0700
"W. Trevor King" <wking@tremily.us> wrote:
> On Mon, Sep 01, 2014 at 07:31:41PM -0700, Brian Dolbec wrote:
> > Conflicts:
> > targets/support/functions.sh
>
> Presumably these are conflicts from rebasing from 3.0. I don't think
> we care about those, so I'd remove this note from the commit message.
>
> What are the symptoms of the bug this fixes? How do I trigger it in
> Catalysts without this patch?
>
> Cheers,
> Trevor
>
Yeah, sorry, I was leaving those in place while fixing rebase errors...
it helps to find them. I'll clean them out once review is done.
This is only half the original problem. The other half is fixed in a
previous commit. What it orginally did was assign destdir with a
leading '.' then when I made some other seemingly unrelated change,
moving the '.' from the assignment to the usage fixed the relative path
issue. It drove me nuts trying to find it.
--
Brian Dolbec <dolsen>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 620 bytes --]
next prev parent reply other threads:[~2014-09-02 5:28 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 2:31 [gentoo-catalyst] [PATCH 0/7] Pending branch patches (various) Brian Dolbec
2014-09-02 2:31 ` [gentoo-catalyst] [PATCH 1/7] Remove unused urllib import Brian Dolbec
2014-09-02 5:22 ` W. Trevor King
2014-09-02 2:31 ` [gentoo-catalyst] [PATCH 2/7] Remove unused variable new and an undefined variable s Brian Dolbec
2014-09-02 5:43 ` W. Trevor King
2014-09-05 18:16 ` W. Trevor King
2014-09-02 2:31 ` [gentoo-catalyst] [PATCH 3/7] stage1-controller.sh: Fix portage bin path hard coding Brian Dolbec
2014-09-02 3:35 ` Rick "Zero_Chaos" Farina
2014-09-02 5:05 ` [gentoo-catalyst] [PATCH v2] stage1-controller.sh: Remove some old poor cleaning code Brian Dolbec
2014-09-02 5:19 ` [gentoo-catalyst] [PATCH v2 3/7] " Brian Dolbec
2014-09-02 5:31 ` [gentoo-catalyst] [PATCH v2] " W. Trevor King
2014-09-09 18:38 ` Brian Dolbec
2014-09-10 17:16 ` Rick "Zero_Chaos" Farina
2014-09-10 21:00 ` Anthony G. Basile
2014-09-02 2:31 ` [gentoo-catalyst] [PATCH 4/7] chroot-functions.sh: Remove --nodeps option from portage update Brian Dolbec
2014-09-02 2:31 ` [gentoo-catalyst] [PATCH 5/7] chroot-functions.sh: Fix a mis-worded comment Brian Dolbec
2014-09-02 2:31 ` [gentoo-catalyst] [PATCH 6/7] setup_pkgmgr(): WIP Make the 'build' use flag optional Brian Dolbec
2014-09-09 18:27 ` Brian Dolbec
2014-09-02 2:31 ` [gentoo-catalyst] [PATCH 7/7] Fix a relative path bug Brian Dolbec
2014-09-02 5:06 ` W. Trevor King
2014-09-02 5:26 ` Brian Dolbec [this message]
2014-09-09 17:20 ` Brian Dolbec
2014-09-11 3:30 ` [gentoo-catalyst] [PATCH 0/7] Pending branch patches (various) Brian Dolbec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140901222640.78f9d3a9.dolsen@gentoo.org \
--to=dolsen@gentoo.org \
--cc=gentoo-catalyst@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox