Re: [gentoo-catalyst] [PATCH 1/7] Remove unused urllib import.

["W. Trevor King" <wking@tremily.us>]

[-- Attachment #1: Type: text/plain, Size: 1908 bytes --]

Previous submissions for this patch: [1,2].  It's already been acked
by Matt [3] and me [4].  I acked it again on IRC on 2014-06-15:

  08:02 < wking> dol-sen: I don't see how c718315 (Remove unused
    urllib import, 2013-02-11) could possibly break anything ;).
  08:02 < wking> But I'm going through stages one through three anyway
    just to be sure ;)
  08:03 < wking> Are you going to mail these to the list, or are you
    planning on polishing them first, and then submitting them to the
    list?
  08:03 <@dol-sen> they need some work
  …
  18:16 < wking> dol-sen: c718315 is now 135 of 263 in my stage 3, so
    I think it's good to merge to master (after floating on the list,
    if that's still Catalyst policy).
  21:50 <@jmbsvicetto> dol-sen / wking: please keep reviewing those
    patches with any help in the catalyst ml. I'll likely be tied for
    a while and won't have time to go over them, but I trust your
    judgement
  21:50 <@jmbsvicetto> dol-sen: feel free to commit them whenever
    you're happy.
  21:51 <@jmbsvicetto> Zero_Chaos: ^^ Please try to review them when
    you can to ensure you don't get any surprises
  21:52 <@jmbsvicetto> dol-sen: I can try to setup automated builds
    with the rewrite branch on my server so we can get automated
    feedback about it

So after three submissions and three acks (one on this exact c718315
commit), I think we can safely land this one ;).

Cheers,
Trevor

[1]: http://article.gmane.org/gmane.linux.gentoo.catalyst/2158
[2]: http://article.gmane.org/gmane.linux.gentoo.catalyst/2364
[3]: http://thread.gmane.org/gmane.linux.gentoo.catalyst/2361/focus=2378
[4]: http://thread.gmane.org/gmane.linux.gentoo.catalyst/2361/focus=2425

-- 
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]