From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 0820413838B for ; Tue, 9 Sep 2014 17:20:58 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 8FA92E05C1; Tue, 9 Sep 2014 17:20:57 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 34F97E05C1 for ; Tue, 9 Sep 2014 17:20:57 +0000 (UTC) Received: from big_daddy.dol-sen.ca (S010600222de111ff.vc.shawcable.net [96.49.5.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dolsen) by smtp.gentoo.org (Postfix) with ESMTPSA id 6439C33FFF7 for ; Tue, 9 Sep 2014 17:20:56 +0000 (UTC) Date: Tue, 9 Sep 2014 10:20:50 -0700 From: Brian Dolbec To: gentoo-catalyst@lists.gentoo.org Subject: Re: [gentoo-catalyst] [PATCH 7/7] Fix a relative path bug Message-ID: <20140909102050.74fa1d97.dolsen@gentoo.org> In-Reply-To: <20140901222640.78f9d3a9.dolsen@gentoo.org> References: <1409625101-27112-1-git-send-email-dolsen@gentoo.org> <1409625101-27112-8-git-send-email-dolsen@gentoo.org> <20140902050634.GI8263@odin.tremily.us> <20140901222640.78f9d3a9.dolsen@gentoo.org> Organization: Gentoo Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/5z54NL8fa=_w17sQfxGH9C5"; protocol="application/pgp-signature" X-Archives-Salt: e2984729-37c1-412c-ba3b-5eed1c1c9e1c X-Archives-Hash: ddbded21055dbd374cd8a843a895ced0 --Sig_/5z54NL8fa=_w17sQfxGH9C5 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Mon, 1 Sep 2014 22:26:40 -0700 Brian Dolbec wrote: > On Mon, 1 Sep 2014 22:06:34 -0700 > "W. Trevor King" wrote: >=20 > >=20 > > What are the symptoms of the bug this fixes? How do I trigger it in > > Catalysts without this patch? > >=20 > > Cheers, > > Trevor > >=20 >=20 > Yeah, sorry, I was leaving those in place while fixing rebase > errors... it helps to find them. I'll clean them out once review is > done. >=20 > This is only half the original problem. The other half is fixed in a > previous commit. What it orginally did was assign destdir with a > leading '.' then when I made some other seemingly unrelated change, > moving the '.' from the assignment to the usage fixed the relative > path issue. It drove me nuts trying to find it. >=20 Here is the full change, already in the 2.X branch and 2.0.17 release. diff --git a/targets/support/functions.sh b/targets/support/functions.sh index 311ed7b..fba855c 100755 @@ -20,7 +20,7 @@ exec_in_chroot(){ # and executes it. local file_name=3D$(basename ${1}) local subdir=3D${2} - local destdir=3D".${subdir}/tmp" + local destdir=3D"${subdir}/tmp" =20 echo "Copying ${file_name} to ${destdir}" copy_to_chroot ${1} ${destdir} @@ -33,7 +33,7 @@ exec_in_chroot(){ chmod +x ${chroot_path}/${destdir}/${file_name} =20 echo "Running ${file_name} in chroot ${chroot_path}" - ${clst_CHROOT} ${chroot_path} ${destdir}/${file_name} || exit 1 + ${clst_CHROOT} ${chroot_path} .${destdir}/${file_name} || exit 1=20 delete_from_chroot ${destdir}/${file_name} =20 --=20 Brian Dolbec --Sig_/5z54NL8fa=_w17sQfxGH9C5 Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0 iQF8BAEBCgBmBQJUDzbyXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ4Njg4RkQxQ0M3MUMxQzA0RUFFQTQyMzcy MjE0RDkwQTAxNEYxN0NCAAoJECIU2QoBTxfLQXYIAKm4p5fPicX3D3K2YUuWo39/ 2x+0WHpizYhdnDrN95a01LMQdadFYYN9cs6Xjcv5ZN9lFkduqUuqiQJ64XRbEVS+ 6n6TxqLB0aBMdF08bMgWH0mDlyQSNgr1Hej+Z7TjYKHJA0qXtkeqXVRukbn3Gv9+ icE/df/113mGkNLRw3xKD8FOY4x93jZ+5aJkgb3bjkk2mk04fXyGh6vDYcDW1GcG OcvjMvj3Cy+J8xX2FAwKcXX+fu328x6WDxfbi5X/DjG1JKc9u+7S3N5EXOPVsUG5 K3DFyDIU7ti/hkJwjGLCZXsGSJyg/irzVAcCrbCm6W7XbsH8o7t59tw/O35TI3o= =/V3s -----END PGP SIGNATURE----- --Sig_/5z54NL8fa=_w17sQfxGH9C5--