From: Brian Dolbec <dolsen@gentoo.org>
To: gentoo-catalyst@lists.gentoo.org
Subject: Re: [gentoo-catalyst] [PATCH v2] stage1-controller.sh: Remove some old poor cleaning code
Date: Tue, 9 Sep 2014 11:38:44 -0700 [thread overview]
Message-ID: <20140909113844.6220aee6.dolsen@gentoo.org> (raw)
In-Reply-To: <1409634345-5378-1-git-send-email-dolsen@gentoo.org>
On Mon, 1 Sep 2014 22:05:45 -0700
Brian Dolbec <dolsen@gentoo.org> wrote:
> This code had portage bin path hard coded. That path needed to be
> changed for a new portage ebuild and install system.
> After testing the origianl code and comparing it with some updated
> code supplied by Douglas Freed. It turned out both code chunks
> resulted in nothing being cleaned.
>
> Tested and confirmed by zero_chaos.
I have gone over things more and tested the new find command. It does
work on my host system. However, the question remains... DOES this
particular cleaning operation NEED to be performed?
With current the tree snapshot for my testing 20140829. It does not
find anything to clean. BUT, will that remain the same in the future
as pkgs are bumped?
For safety, I'd be inclined to keep the find command (v1 of the
patch) and clean any it does find just in case.
--
Brian Dolbec <dolsen>
next prev parent reply other threads:[~2014-09-09 18:38 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 2:31 [gentoo-catalyst] [PATCH 0/7] Pending branch patches (various) Brian Dolbec
2014-09-02 2:31 ` [gentoo-catalyst] [PATCH 1/7] Remove unused urllib import Brian Dolbec
2014-09-02 5:22 ` W. Trevor King
2014-09-02 2:31 ` [gentoo-catalyst] [PATCH 2/7] Remove unused variable new and an undefined variable s Brian Dolbec
2014-09-02 5:43 ` W. Trevor King
2014-09-05 18:16 ` W. Trevor King
2014-09-02 2:31 ` [gentoo-catalyst] [PATCH 3/7] stage1-controller.sh: Fix portage bin path hard coding Brian Dolbec
2014-09-02 3:35 ` Rick "Zero_Chaos" Farina
2014-09-02 5:05 ` [gentoo-catalyst] [PATCH v2] stage1-controller.sh: Remove some old poor cleaning code Brian Dolbec
2014-09-02 5:19 ` [gentoo-catalyst] [PATCH v2 3/7] " Brian Dolbec
2014-09-02 5:31 ` [gentoo-catalyst] [PATCH v2] " W. Trevor King
2014-09-09 18:38 ` Brian Dolbec [this message]
2014-09-10 17:16 ` Rick "Zero_Chaos" Farina
2014-09-10 21:00 ` Anthony G. Basile
2014-09-02 2:31 ` [gentoo-catalyst] [PATCH 4/7] chroot-functions.sh: Remove --nodeps option from portage update Brian Dolbec
2014-09-02 2:31 ` [gentoo-catalyst] [PATCH 5/7] chroot-functions.sh: Fix a mis-worded comment Brian Dolbec
2014-09-02 2:31 ` [gentoo-catalyst] [PATCH 6/7] setup_pkgmgr(): WIP Make the 'build' use flag optional Brian Dolbec
2014-09-09 18:27 ` Brian Dolbec
2014-09-02 2:31 ` [gentoo-catalyst] [PATCH 7/7] Fix a relative path bug Brian Dolbec
2014-09-02 5:06 ` W. Trevor King
2014-09-02 5:26 ` Brian Dolbec
2014-09-09 17:20 ` Brian Dolbec
2014-09-11 3:30 ` [gentoo-catalyst] [PATCH 0/7] Pending branch patches (various) Brian Dolbec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140909113844.6220aee6.dolsen@gentoo.org \
--to=dolsen@gentoo.org \
--cc=gentoo-catalyst@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox