From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id D3BCC13888F for ; Tue, 6 Oct 2015 06:17:33 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 8CC82E07B3; Tue, 6 Oct 2015 06:17:31 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 029A9E07B3 for ; Tue, 6 Oct 2015 06:17:30 +0000 (UTC) Received: from professor-x (S010634bdfa9ecf80.vc.shawcable.net [96.49.31.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dolsen) by smtp.gentoo.org (Postfix) with ESMTPSA id 77A3B340976 for ; Tue, 6 Oct 2015 06:17:28 +0000 (UTC) Date: Mon, 5 Oct 2015 23:16:39 -0700 From: Brian Dolbec To: gentoo-catalyst@lists.gentoo.org Subject: Re: [gentoo-catalyst] [PATCH] lint: clean up unused imports Message-ID: <20151005231639.52e4d070.dolsen@gentoo.org> In-Reply-To: <1444104350-15916-1-git-send-email-vapier@gentoo.org> References: <1444104350-15916-1-git-send-email-vapier@gentoo.org> Organization: Gentoo Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Archives-Salt: 50f44547-c33b-49e5-9f51-06ac843cd028 X-Archives-Hash: 3ac2350746363cdbc128a2020eb3acf9 On Tue, 6 Oct 2015 00:05:50 -0400 Mike Frysinger wrote: > Delete imports that the modules don't actually utilize. > --- > catalyst/base/resume.py | 2 -- > catalyst/fileops.py | 2 ++ > catalyst/targets/grp.py | 3 +-- > catalyst/targets/livecd_stage1.py | 3 +-- > catalyst/targets/livecd_stage2.py | 3 +-- > catalyst/targets/netboot2.py | 3 +-- > 6 files changed, 6 insertions(+), 10 deletions(-) > > diff --git a/catalyst/base/resume.py b/catalyst/base/resume.py > index a03adf3..608f574 100644 > --- a/catalyst/base/resume.py > +++ b/catalyst/base/resume.py > @@ -12,8 +12,6 @@ set, unset, is_set, is_unset, enabled, clear_all > ''' > > import os > -import shutil > -from stat import ST_UID, ST_GID, ST_MODE > import sys > import traceback > > diff --git a/catalyst/fileops.py b/catalyst/fileops.py > index 129d967..8a05985 100644 > --- a/catalyst/fileops.py > +++ b/catalyst/fileops.py > @@ -16,8 +16,10 @@ from stat import ST_UID, ST_GID, ST_MODE > > # NOTE: pjoin and listdir_files are imported here for export > # to other catalyst modules > +# pylint: disable=unused-import > from snakeoil.osutils import (ensure_dirs as snakeoil_ensure_dirs, > pjoin, listdir_files) > +# pylint: enable=unused-import > from catalyst.support import CatalystError > > > diff --git a/catalyst/targets/grp.py b/catalyst/targets/grp.py > index 5a10fff..4814ac6 100644 > --- a/catalyst/targets/grp.py > +++ b/catalyst/targets/grp.py > @@ -8,8 +8,7 @@ import types > import glob > > > -from catalyst.support import (CatalystError, normpath, > - touch, cmd, list_bashify) > +from catalyst.support import (CatalystError, normpath, cmd, > list_bashify) from catalyst.fileops import ensure_dirs > from catalyst.base.stagebase import StageBase > > diff --git a/catalyst/targets/livecd_stage1.py > b/catalyst/targets/livecd_stage1.py index af59ed7..1930df1 100644 > --- a/catalyst/targets/livecd_stage1.py > +++ b/catalyst/targets/livecd_stage1.py > @@ -7,8 +7,7 @@ import os > import types > > > -from catalyst.support import (normpath, > - touch, cmd) > +from catalyst.support import (normpath, cmd) > from catalyst.fileops import ensure_dirs > > from catalyst.base.stagebase import StageBase > diff --git a/catalyst/targets/livecd_stage2.py > b/catalyst/targets/livecd_stage2.py index 77c6613..870dcf9 100644 > --- a/catalyst/targets/livecd_stage2.py > +++ b/catalyst/targets/livecd_stage2.py > @@ -5,8 +5,7 @@ LiveCD stage2 target, builds upon previous LiveCD > stage1 tarball > import os > > -from catalyst.support import (normpath, file_locate, CatalystError, > cmd, > - read_from_clst, touch) > +from catalyst.support import (normpath, file_locate, CatalystError, > cmd) from catalyst.fileops import ensure_dirs > from catalyst.base.stagebase import StageBase > > diff --git a/catalyst/targets/netboot2.py > b/catalyst/targets/netboot2.py index 3305a2a..5de1a74 100644 > --- a/catalyst/targets/netboot2.py > +++ b/catalyst/targets/netboot2.py > @@ -8,8 +8,7 @@ import types > import shutil > from stat import ST_UID, ST_GID, ST_MODE > > -from catalyst.support import (CatalystError, normpath, > - touch, cmd, list_bashify) > +from catalyst.support import (CatalystError, normpath, cmd, > list_bashify) from catalyst.fileops import ensure_dirs > > from catalyst.base.stagebase import StageBase yeah, another one approved :) and Thank you :) -- Brian Dolbec