public inbox for gentoo-catalyst@lists.gentoo.org
 help / color / mirror / Atom feed
From: Brian Dolbec <dolsen@gentoo.org>
To: gentoo-catalyst@lists.gentoo.org
Subject: Re: [gentoo-catalyst] [PATCH] lint: drop unnecessary semicolon
Date: Mon, 5 Oct 2015 23:18:31 -0700	[thread overview]
Message-ID: <20151005231831.4c9f0ebe.dolsen@gentoo.org> (raw)
In-Reply-To: <1444101551-13348-1-git-send-email-vapier@gentoo.org>

On Mon,  5 Oct 2015 23:19:11 -0400
Mike Frysinger <vapier@gentoo.org> wrote:

> ---
>  catalyst/arch/powerpc.py | 2 +-
>  catalyst/arch/sparc.py   | 2 +-
>  catalyst/arch/x86.py     | 2 +-
>  targets/stage1/build.py  | 6 +++---
>  4 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/catalyst/arch/powerpc.py b/catalyst/arch/powerpc.py
> index 8e0f540..fb98316 100644
> --- a/catalyst/arch/powerpc.py
> +++ b/catalyst/arch/powerpc.py
> @@ -14,7 +14,7 @@ class generic_ppc(builder.generic):
>  				raise CatalystError("required
> executable linux32 not found " "(\"emerge setarch\" to fix.)",
> print_traceback=True) self.settings["CHROOT"]="linux32 chroot"
> -			self.settings["crosscompile"] = False;
> +			self.settings["crosscompile"] = False
>  		else:
>  			self.settings["CHROOT"]="chroot"
>  
> diff --git a/catalyst/arch/sparc.py b/catalyst/arch/sparc.py
> index da2ad35..ec69386 100644
> --- a/catalyst/arch/sparc.py
> +++ b/catalyst/arch/sparc.py
> @@ -13,7 +13,7 @@ class generic_sparc(builder.generic):
>  				raise CatalystError("required
> executable linux32 not found " "(\"emerge setarch\" to fix.)",
> print_traceback=True) self.settings["CHROOT"]="linux32 chroot"
> -			self.settings["crosscompile"] = False;
> +			self.settings["crosscompile"] = False
>  		else:
>  			self.settings["CHROOT"]="chroot"
>  
> diff --git a/catalyst/arch/x86.py b/catalyst/arch/x86.py
> index 44a6a49..49500b9 100644
> --- a/catalyst/arch/x86.py
> +++ b/catalyst/arch/x86.py
> @@ -13,7 +13,7 @@ class generic_x86(builder.generic):
>  					raise
> CatalystError("required executable linux32 not found " "(\"emerge
> setarch\" to fix.)", print_traceback=True)
> self.settings["CHROOT"]="linux32 chroot"
> -			self.settings["crosscompile"] = False;
> +			self.settings["crosscompile"] = False
>  		else:
>  			self.settings["CHROOT"]="chroot"
>  
> diff --git a/targets/stage1/build.py b/targets/stage1/build.py
> index b2c8b0f..db6a93f 100755
> --- a/targets/stage1/build.py
> +++ b/targets/stage1/build.py
> @@ -10,12 +10,12 @@ import portage
>  # last case is for portage-2.1_pre*
>  def scan_profile(file):
>  	if "grab_stacked" in dir(portage):
> -		return portage.grab_stacked(file,
> portage.settings.profiles, portage.grabfile, incremental_lines=1);
> +		return portage.grab_stacked(file,
> portage.settings.profiles, portage.grabfile, incremental_lines=1)
> else: if "grab_multiple" in dir(portage):
> -			return
> portage.stack_lists( portage.grab_multiple(file,
> portage.settings.profiles, portage.grabfile), incremental=1);
> +			return
> portage.stack_lists( portage.grab_multiple(file,
> portage.settings.profiles, portage.grabfile), incremental=1) else:
> -			return
> portage.stack_lists( [portage.grabfile_package(os.path.join(x, file))
> for x in portage.settings.profiles], incremental=1);
> +			return
> portage.stack_lists( [portage.grabfile_package(os.path.join(x, file))
> for x in portage.settings.profiles], incremental=1) # loaded the
> stacked packages / packages.build files pkgs =
> scan_profile("packages")

looks good :)

-- 
Brian Dolbec <dolsen>



      reply	other threads:[~2015-10-06  6:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-06  3:19 [gentoo-catalyst] [PATCH] lint: drop unnecessary semicolon Mike Frysinger
2015-10-06  6:18 ` Brian Dolbec [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151005231831.4c9f0ebe.dolsen@gentoo.org \
    --to=dolsen@gentoo.org \
    --cc=gentoo-catalyst@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox