From: Brian Dolbec <dolsen@gentoo.org>
To: gentoo-catalyst@lists.gentoo.org
Subject: Re: [gentoo-catalyst] [PATCH] resume: fix missing sys import
Date: Mon, 5 Oct 2015 23:51:12 -0700 [thread overview]
Message-ID: <20151005235112.0e1c02d5.dolsen@gentoo.org> (raw)
In-Reply-To: <1444103297-14564-1-git-send-email-vapier@gentoo.org>
On Mon, 5 Oct 2015 23:48:17 -0400
Mike Frysinger <vapier@gentoo.org> wrote:
> This module uses the sys module but didn't actually import it.
> ---
> catalyst/base/resume.py | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/catalyst/base/resume.py b/catalyst/base/resume.py
> index 2c006ab..a03adf3 100644
> --- a/catalyst/base/resume.py
> +++ b/catalyst/base/resume.py
> @@ -14,6 +14,7 @@ set, unset, is_set, is_unset, enabled, clear_all
> import os
> import shutil
> from stat import ST_UID, ST_GID, ST_MODE
> +import sys
> import traceback
>
> from catalyst.fileops import ensure_dirs, pjoin, listdir_files,
> clear_dir
uh oh, this one is my bad. I usually run pyflakes on the code to pick
up these little things...
Thank you, merge please
--
Brian Dolbec <dolsen>
prev parent reply other threads:[~2015-10-06 6:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 3:48 [gentoo-catalyst] [PATCH] resume: fix missing sys import Mike Frysinger
2015-10-06 6:51 ` Brian Dolbec [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151005235112.0e1c02d5.dolsen@gentoo.org \
--to=dolsen@gentoo.org \
--cc=gentoo-catalyst@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox