From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 6192B13888F for ; Tue, 6 Oct 2015 15:28:46 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 68C5D21C010; Tue, 6 Oct 2015 15:28:39 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id DCC9F21C010 for ; Tue, 6 Oct 2015 15:28:38 +0000 (UTC) Received: from professor-x (S010634bdfa9ecf80.vc.shawcable.net [96.49.31.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dolsen) by smtp.gentoo.org (Postfix) with ESMTPSA id 8077A340A8E for ; Tue, 6 Oct 2015 15:28:36 +0000 (UTC) Date: Tue, 6 Oct 2015 08:27:47 -0700 From: Brian Dolbec To: gentoo-catalyst@lists.gentoo.org Subject: Re: [gentoo-catalyst] [PATCH 13/13] lint: clean up superfluous parens Message-ID: <20151006082747.2f3fb6ec.dolsen@gentoo.org> In-Reply-To: <1444143929-26705-13-git-send-email-vapier@gentoo.org> References: <1444143929-26705-1-git-send-email-vapier@gentoo.org> <1444143929-26705-13-git-send-email-vapier@gentoo.org> Organization: Gentoo Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Archives-Salt: 95f6230b-037d-48c8-a580-cf9ede5f1304 X-Archives-Hash: 5592bad9d441b55cbc79b588d4d6eff5 On Tue, 6 Oct 2015 11:05:29 -0400 Mike Frysinger wrote: > These don't need the parens, so omit them. > > In the case of setup.py, we were expecting a print function, not a > keyword, so make sure to import that module. > --- > catalyst/lock.py | 6 +++--- > doc/make_subarch_table_guidexml.py | 6 +++--- > setup.py | 1 + > 3 files changed, 7 insertions(+), 6 deletions(-) > > diff --git a/catalyst/lock.py b/catalyst/lock.py > index d079b2d..3d50c06 100644 > --- a/catalyst/lock.py > +++ b/catalyst/lock.py > @@ -179,7 +179,7 @@ class LockDir(object): > if not os.path.exists(self.lockfile): > print "lockfile does not exist '%s'" % > self.lockfile #print "fcntl_unlock() , self.myfd:", self.myfd, > type(self.myfd) > - if (self.myfd != None): > + if self.myfd != None: > #print "fcntl_unlock() trying to > close it " try: > os.close(self.myfd) > @@ -236,7 +236,7 @@ class LockDir(object): > #if type(lockfilename) == > types.StringType: # os.close(myfd) > #print "fcntl_unlock() trying a last ditch close", > self.myfd > - if (self.myfd != None): > + if self.myfd != None: > os.close(self.myfd) > self.myfd=None > self.locked=False > @@ -256,7 +256,7 @@ class LockDir(object): > start_time = time.time() > reported_waiting = False > > - while(time.time() < (start_time + max_wait)): > + while time.time() < (start_time + max_wait): > # We only need it to exist. > self.myfd = os.open(self.myhardlock, > os.O_CREAT|os.O_RDWR,0660) os.close(self.myfd) > diff --git a/doc/make_subarch_table_guidexml.py > b/doc/make_subarch_table_guidexml.py index 54e0a4a..a6a9022 100755 > --- a/doc/make_subarch_table_guidexml.py > +++ b/doc/make_subarch_table_guidexml.py > @@ -30,7 +30,7 @@ def handle_line(line, subarch_title_to_subarch_id, > subarch_id_to_pattern_arch_ge # Apply alias grouping > arch = _pattern_arch_genericliases.get(arch, arch) > > - assert(subarch not in > subarch_id_to_pattern_arch_genericrch_id) > + assert subarch not in > subarch_id_to_pattern_arch_genericrch_id > subarch_id_to_pattern_arch_genericrch_id[subarch] = arch > return > @@ -40,7 +40,7 @@ def handle_line(line, subarch_title_to_subarch_id, > subarch_id_to_pattern_arch_ge child_subarch = x.group(1) > parent_subarch = x.group(2) > > - assert(child_subarch not in > subarch_id_to_pattern_arch_genericrch_id) > + assert child_subarch not in > subarch_id_to_pattern_arch_genericrch_id > subarch_id_to_pattern_arch_genericrch_id[child_subarch] = > subarch_id_to_pattern_arch_genericrch_id[parent_subarch] return > @@ -49,7 +49,7 @@ def handle_line(line, subarch_title_to_subarch_id, > subarch_id_to_pattern_arch_ge subarch_title = x.group(1) > subarch_id = x.group(2) > > - assert(subarch_title not in > subarch_title_to_subarch_id) > + assert subarch_title not in > subarch_title_to_subarch_id > subarch_title_to_subarch_id[subarch_title] = subarch_id > > diff --git a/setup.py b/setup.py > index e4569ee..a875db1 100755 > --- a/setup.py > +++ b/setup.py > @@ -1,5 +1,6 @@ > """Catalyst is a release building tool used by Gentoo Linux""" > > +from __future__ import print_function > > import codecs as _codecs > from distutils.core import setup as _setup, Command as _Command I'll just reply to this last one. All patches in this series look good, Thank you. -- Brian Dolbec