From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id B706313888F for ; Tue, 6 Oct 2015 17:28:40 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 57A9021C001; Tue, 6 Oct 2015 17:28:40 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id EC92621C001 for ; Tue, 6 Oct 2015 17:28:39 +0000 (UTC) Received: from professor-x (S010634bdfa9ecf80.vc.shawcable.net [96.49.31.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dolsen) by smtp.gentoo.org (Postfix) with ESMTPSA id 08F5334076D for ; Tue, 6 Oct 2015 17:28:38 +0000 (UTC) Date: Tue, 6 Oct 2015 10:27:49 -0700 From: Brian Dolbec To: gentoo-catalyst@lists.gentoo.org Subject: Re: [gentoo-catalyst] [PATCH] lint: use comments for comments, not inline docstrings Message-ID: <20151006102749.0757db25.dolsen@gentoo.org> In-Reply-To: <1444152017-2406-1-git-send-email-vapier@gentoo.org> References: <1444152017-2406-1-git-send-email-vapier@gentoo.org> Organization: Gentoo Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-catalyst@lists.gentoo.org Reply-to: gentoo-catalyst@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Archives-Salt: 7ec8f44b-de21-45e1-a11d-4b8976e58529 X-Archives-Hash: e2d88a81537f9d70fcb7afe50f11e97f On Tue, 6 Oct 2015 13:20:17 -0400 Mike Frysinger wrote: > It's uncommon to dump docstrings in the middle of code in the place of > comments. Convert them all to standard comments. > --- > catalyst/base/stagebase.py | 219 > ++++++++++++++++++------------------------- > catalyst/fileops.py | 8 +- catalyst/targets/snapshot.py > | 8 +- 3 files changed, 99 insertions(+), 136 deletions(-) > > Works for me :) -- Brian Dolbec