From: Brian Dolbec <dolsen@gentoo.org>
To: gentoo-catalyst@lists.gentoo.org
Subject: Re: [gentoo-catalyst] [PATCH 4/4] config: convert to log module
Date: Fri, 9 Oct 2015 13:38:35 -0700 [thread overview]
Message-ID: <20151009133835.6f7042aa.dolsen@gentoo.org> (raw)
In-Reply-To: <1444419367-779-4-git-send-email-vapier@gentoo.org>
On Fri, 9 Oct 2015 15:36:07 -0400
Mike Frysinger <vapier@gentoo.org> wrote:
> ---
> catalyst/config.py | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/catalyst/config.py b/catalyst/config.py
> index ffad9b3..db81a96 100644
> --- a/catalyst/config.py
> +++ b/catalyst/config.py
> @@ -1,5 +1,7 @@
>
> import re
> +
> +from catalyst import log
> from catalyst.support import CatalystError
>
> class ParserBase(object):
> @@ -98,7 +100,7 @@ class ParserBase(object):
> for x in values.keys():
> # Delete empty key pairs
> if not values[x]:
> - print "\n\tWARNING: No value
> set for key " + x + "...deleting"
> + log.warning('No value set
> for key "%s"; deleting', x) del values[x]
>
> self.values = values
you have a go for all 4 in this series :)
--
Brian Dolbec <dolsen>
prev parent reply other threads:[~2015-10-09 20:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 19:36 [gentoo-catalyst] [PATCH 1/4] hash_utils: convert to log module Mike Frysinger
2015-10-09 19:36 ` [gentoo-catalyst] [PATCH 2/4] fileops: " Mike Frysinger
2015-10-09 19:36 ` [gentoo-catalyst] [PATCH 3/4] snapshot: " Mike Frysinger
2015-10-09 19:36 ` [gentoo-catalyst] [PATCH 4/4] config: " Mike Frysinger
2015-10-09 20:38 ` Brian Dolbec [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151009133835.6f7042aa.dolsen@gentoo.org \
--to=dolsen@gentoo.org \
--cc=gentoo-catalyst@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox