From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-catalyst+bounces-3343-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	by finch.gentoo.org (Postfix) with ESMTP id 99E8413888F
	for <garchives@archives.gentoo.org>; Fri,  9 Oct 2015 20:39:26 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id 55431E0817;
	Fri,  9 Oct 2015 20:39:24 +0000 (UTC)
Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by pigeon.gentoo.org (Postfix) with ESMTPS id CA0EFE0817
	for <gentoo-catalyst@lists.gentoo.org>; Fri,  9 Oct 2015 20:39:23 +0000 (UTC)
Received: from professor-x (S010634bdfa9ecf80.vc.shawcable.net [96.49.31.57])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	(Authenticated sender: dolsen)
	by smtp.gentoo.org (Postfix) with ESMTPSA id AB67B33FD3F
	for <gentoo-catalyst@lists.gentoo.org>; Fri,  9 Oct 2015 20:39:22 +0000 (UTC)
Date: Fri, 9 Oct 2015 13:38:35 -0700
From: Brian Dolbec <dolsen@gentoo.org>
To: gentoo-catalyst@lists.gentoo.org
Subject: Re: [gentoo-catalyst] [PATCH 4/4] config: convert to log module
Message-ID: <20151009133835.6f7042aa.dolsen@gentoo.org>
In-Reply-To: <1444419367-779-4-git-send-email-vapier@gentoo.org>
References: <1444419367-779-1-git-send-email-vapier@gentoo.org>
	<1444419367-779-4-git-send-email-vapier@gentoo.org>
Organization: Gentoo
Precedence: bulk
List-Post: <mailto:gentoo-catalyst@lists.gentoo.org>
List-Help: <mailto:gentoo-catalyst+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-catalyst+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-catalyst+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-catalyst.gentoo.org>
X-BeenThere: gentoo-catalyst@lists.gentoo.org
Reply-to: gentoo-catalyst@lists.gentoo.org
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Archives-Salt: aaf493d7-918f-40d7-ad44-47830a0427c7
X-Archives-Hash: 98c00920dc5448ddefd736b198ca748c

On Fri,  9 Oct 2015 15:36:07 -0400
Mike Frysinger <vapier@gentoo.org> wrote:

> ---
>  catalyst/config.py | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/catalyst/config.py b/catalyst/config.py
> index ffad9b3..db81a96 100644
> --- a/catalyst/config.py
> +++ b/catalyst/config.py
> @@ -1,5 +1,7 @@
>  
>  import re
> +
> +from catalyst import log
>  from catalyst.support import CatalystError
>  
>  class ParserBase(object):
> @@ -98,7 +100,7 @@ class ParserBase(object):
>  			for x in values.keys():
>  				# Delete empty key pairs
>  				if not values[x]:
> -					print "\n\tWARNING: No value
> set for key " + x + "...deleting"
> +					log.warning('No value set
> for key "%s"; deleting', x) del values[x]
>  
>  		self.values = values


you have a go for all 4 in this series :)

-- 
Brian Dolbec <dolsen>