From: Brian Dolbec <dolsen@gentoo.org>
To: gentoo-catalyst@lists.gentoo.org
Subject: Re: [gentoo-catalyst] [PATCH 7/9] hash_utils: decode output of popen
Date: Wed, 28 Oct 2015 07:49:11 -0700 [thread overview]
Message-ID: <20151028074911.0fe57236.dolsen@gentoo.org> (raw)
In-Reply-To: <1444624562-26162-7-git-send-email-vapier@gentoo.org>
On Mon, 12 Oct 2015 00:36:00 -0400
Mike Frysinger <vapier@gentoo.org> wrote:
> In py3, the return of popen is binary data. We need
> to decode it to get a string we can work with.
> ---
> catalyst/hash_utils.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/catalyst/hash_utils.py b/catalyst/hash_utils.py
> index 1161da3..6e08967 100644
> --- a/catalyst/hash_utils.py
> +++ b/catalyst/hash_utils.py
> @@ -117,7 +117,7 @@ class HashMap(object):
> log.debug('args = %r', args)
> source = Popen(args, stdout=PIPE)
> output = source.communicate()
> - lines = output[0].split('\n')
> + lines = output[0].decode('ascii').split('\n')
> log.debug('output = %s', output)
> header = lines[0]
> h_f = lines[1].split()
looks good
--
Brian Dolbec <dolsen>
next prev parent reply other threads:[~2015-10-28 14:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 4:35 [gentoo-catalyst] [PATCH 1/9] convert octals to py3 compat Mike Frysinger
2015-10-12 4:35 ` [gentoo-catalyst] [PATCH 2/9] make_target_table: rewrite for py3/stability Mike Frysinger
2015-10-28 14:46 ` Brian Dolbec
2015-10-28 16:49 ` Mike Frysinger
2015-10-28 17:15 ` Brian Dolbec
2015-10-12 4:35 ` [gentoo-catalyst] [PATCH 3/9] stagebase: disable undefined-variable lint warning Mike Frysinger
2015-10-12 4:35 ` [gentoo-catalyst] [PATCH 4/9] log: make sure NOTICE is an int Mike Frysinger
2015-10-12 4:35 ` [gentoo-catalyst] [PATCH 5/9] genbase: use sorted() with dict keys Mike Frysinger
2015-10-12 4:35 ` [gentoo-catalyst] [PATCH 6/9] hash_utils: fix bad keyword w/CatalystError Mike Frysinger
2015-10-12 4:36 ` [gentoo-catalyst] [PATCH 7/9] hash_utils: decode output of popen Mike Frysinger
2015-10-28 14:49 ` Brian Dolbec [this message]
2015-10-12 4:36 ` [gentoo-catalyst] [PATCH 8/9] lint: convert type/types to isinstance Mike Frysinger
2015-10-28 14:55 ` Brian Dolbec
2015-10-12 4:36 ` [gentoo-catalyst] [PATCH 9/9] lint: fix redefined-outer-name warnings Mike Frysinger
2015-10-28 14:58 ` Brian Dolbec
2015-10-12 4:41 ` [gentoo-catalyst] [PATCH 1/9] convert octals to py3 compat Mike Frysinger
2015-10-22 5:17 ` Mike Frysinger
2015-10-24 7:00 ` Mike Frysinger
2015-10-28 14:25 ` Brian Dolbec
2015-10-24 11:37 ` Anthony G. Basile
2015-10-24 14:16 ` Anthony G. Basile
2015-11-09 4:52 ` Brian Dolbec
2015-11-19 4:19 ` Brian Dolbec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151028074911.0fe57236.dolsen@gentoo.org \
--to=dolsen@gentoo.org \
--cc=gentoo-catalyst@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox